file transfer problem - Help!

I have this problem with my code, I can transfer text files from one directory to another directory. But when i change the file name to a jpeg file, the program just refuse to transfer my picture... I really cannot understand why? Can anyone help please? Thanks!

Code:

---


#include <stdio.h>

int main()
{
        int i,j;
        int success;
        char buffer;
        char *pbuffer = &buffer;
       
        FILE *source_fptr;            //file pointer
        FILE *dest_fptr;
                       
        source_fptr = fopen("../a/drama.jpg", "r");
        if (source_fptr == NULL)
                {
                fprintf(stderr,"Error - Cannot open the source file\n");
                exit(1);                //exits the program
                }
        dest_fptr = fopen("../b/copied_drama.jpg", "w");
        if (dest_fptr == NULL)
                {
                fprintf(stderr,"Error - Cannot open the destination file\n");
                exit(1);                //exits the program
                }
                               
        i=0;
        while(1)
        {
                fread(pbuffer, 1, 1, source_fptr);       
                if(feof(source_fptr))
                break;
                fwrite(pbuffer,1, 1, dest_fptr);
                if(feof(source_fptr))
                break;
                i++;
        }       
        //printf("\nThe number of loop iterations: %i\n", i);
               
        fclose(source_fptr);
        fclose(dest_fptr);       
       
        return 0;
}

---

Use "rb" and "wb" for the file open modes.

feof() may not work right for non-text files. Why not just check the return value from fread().

I would also suggest that you use a slightly bigger amount of data than 1 byte at a time, to make the copy more efficient.

It is also entirely meaningless to check if source_fptr is eof after you've already checked the same thing - just because you wrote to the destination another file doesn't make the source file any shorter. Checking for eof on the ouput file is also quite meaningless - if you created a new, empty, file and just wrote the first byte to it, you are, by definition standing at the end of the file, so it would be true, if it wasn't for the fact that eof is only valid when you have done a read of the file.

--
Mats

Thanks!