Use vector instead of fixed-size array

Hello,
This is has become a nightmare. I wrote a program that used two fixed-size arrays to read information from a text file that had a product number first and a price second. It was to use a linear search to find the product number the user entered from the keyboard to display that product number and corresponding price, (option a) or display the entire list (option b). Everything worked fine.

Then I got ambitious and decided I wanted to use vectors instead of arrays so they could grow as inventory does without changing code. That is where I am suffering. I am confusing myself when I work through the algorithm. It seems that everything should work the same with just minor alterations, but that isn't the case, or so it has become with the mess I have created.

Any help on telling me where I am going wrong would be huge. I just may go back to the fixed-size array and call it quits. I am running out of time for this class.

Code:

---

#include <iostream>       
#include <fstream>
#include <string>
#include <cassert>
#include <vector>
using namespace std;

int main()
{
    // menu for user
    const string MENU = "\nPlease select your inventory search option:"
                        "\n For a search by product number select A"
                        "\n For a list of the entire product line select B."
                        "\n Enter your selection ===>  ";
    // program banner
    cout << "\nThis program queries the inventory list of Rinky Dooflingy Co."
            << "\nfor the price by item number or it displays the entire inventory"
            << "\nlist.\n"
            << MENU;
    //read in inventory file
    ifstream readInFile("Inventory.txt");
    assert(readInFile.is_open());
    // item number from inventory list
    vector<int> productNumber;
    vector<double> productPrice;

    int n = 0;
    while (readInFile >> productNumber[n] >> productPrice[n])
    {
        if (readInFile.eof()) break;
        n++;
    }

    for(;;)       
    {
        char userChoice;
        cin >> userChoice;
        switch (userChoice)
        {
            case 'A':
            case 'a':
                cout << "\nEnter the product number:  ";
                int pNumber;
                cin >> pNumber;
                for (int i = 0; i < productNumber.size(); i++)
                {
                    int itemNum = productNumber[i];
                    if(itemNum == pNumber)
                    cout << productNumber[i] << productPrice[i] << "\n";
                }
                break;
            case 'B':
            case 'b':
                cout << "\nCurrent Inventory and Prices:\n\n";
                for (int i = 0; i < productNumber.size(); i++)
                    cout << "\t" << productNumber[i]<< productPrice[i] << "\n";
                break;
          default:
              cout << "\nInvalid selection.  Please try again."
                      << MENU;
        }
        break;
    }
    readInFile.close();
    cout << "\n";
    return 0;
}

---

i will take a look at the code, but before i do:

Quote:

---

Originally Posted by clegs

I can't get beyond compiler errors.

---

please post any compiler errors.

I changed my type on pNumber and itemNum to int which matched the vector type so I have been able to compile now. But I get an:
An exception 'Unhandled Win32 Exception' has occured in ...
error now. I have never encountered one of these in any of the code I have written. I really don't know where I have gone wrong now.

A vector starts out with a zero size if you don't provide an initial one for it. That means that productNumber and productPrice are empty at first. Then, you use while (readInFile >> productNumber[n] >> productPrice[n]). But using operator[] on a vector (or array) requires that it has an element at that position.

You don't know what size the vector will be, so you cannot give it an initial size in this code. Instead, what you should do is read into temporary variables in that while control. Then, inside the loop, use push_back to add an element to each vector.

You won't actually need the n variable either, since you can use productNumber.size() to count how many items were added after the loop ends. You also won't need the if (readInFile.eof()) break; code.

Code:

---

while (readInFile >> productNumber[n] >> productPrice[n])
{
    if (readInFile.eof()) break; //no point
    n++;
}

for(;;) //no point
{
    ...
    break;
}

---

OK Great!

I did that and I get beyong the compiler errrors. My new code snippet on that is:

Code:

---

while (readInFile >> number >> price)
        {
                if (readInFile.eof()) break;
                productNumber.push_back(number);
                productPrice.push_back(price);
        }

---

But, now my switch case, at least for a which is all I am focusing on right now doesn't work. What am I missing there? I enter the productNumber and it breaks out of the program.


I just inserted a for loop with a cout statement (see code below) to see if the vectors are populating and there is noting displayed, so I don't think my readInFile is populating my vectors as expected.

Code:

---

vector<int> productNumber;
vector<double> productPrice;
int number;
double price;

while (readInFile >> number >> price)
{
    productNumber.push_back(number);
    productPrice.push_back(price);
}
    for (int i = 0; i < productNumber.size(); i++)
        cout << productNumber[i] << productPrice[i];

---

>> if (readInFile.eof()) break;
Remove that line. Unless you have garbage at the end of your file, that line might cause your code to skip the last line and otherwise will do nothing. The code inside the while control checks for end of file correctly all by itself.

>> I enter the productNumber and it breaks out of the program.
As robwhit was trying to point out, you have a break at the end of your for (;;) loop which will cause it to always run only once. Perhaps you meant that break to be inside the switch as part of the default case?

Does your code output the found product number and price before it exits? From what I can tell, if you are entering the data correctly it should. The only problem would then be that it exits after that one time because of the break.

I removed the two "nothing" statments as robwhit suggested and I edited my code as I said above but not getting what I need.

I can repost what my new code looks like if needed. But, because the cout right after my while isn't sending anything to the screen I think that is where my issue is, still.

The following is what my Inventory.txt file looks like.

Code:

---

101    $ 45.00
303    $  3.00
707    $102.00
302    $ 13.45
555    $  7.97
999    $500.00
345    $ 76.99
325    $  3.33
769    $ 22.45
111    $  2.76

---

i think it would be good if you could also post your complete and updated code, especially now that we can see what data you are working with

Your input file indicates a problem. Your code reads in an int, then a double. It also skips over any whitespace (spaces, tabs, newlines) because that's what operator>> does automatically. But it doesn't skip over dollar signs. You need to add code to read in or ignore the '$'. The best choice would probably be to read it into a dummy variable since it is surrounded by whitespace that will be ignored by operator>> when you do that.

As soon as the first dollar sign is read, that will put the readInFile stream into a fail state and nothing else will get read. Your vectors will be empty.

Here is the new and inproved, but not quite:

Code:

---

#include <iostream>       
#include <fstream>
#include <string>
#include <cassert>
#include <vector>
using namespace std;


int main()
{

        // menu for user
        const string MENU = "\nPlease select your inventory search option:"
                                                "\n For a search by product number select A"
                                                "\n For a list of the entire product line select B."
                                                "\n Enter your selection ===>  ";
        // program banner
        cout << "\nThis program queries the inventory list of Rinky Dooflingy Co."
                << "\nfor the price by item number or it displays the entire inventory"
                << "\nlist.\n"
                << MENU;
        //read in inventory file
        ifstream readInFile("Inventory.txt");
        assert(readInFile.is_open());
        // item number from inventory list
        vector<int> productNumber;
        vector<double> productPrice;
        int number;
        double price;

        while (readInFile >> number >> price)
        {
                productNumber.push_back(number);
                productPrice.push_back(price);
        }
        for (int i = 0; i < productNumber.size(); i++)
                cout << productNumber[i] << productPrice[i];
               
        char userChoice;
    cin >> userChoice;
       
        switch (userChoice)
        {
        case 'A':
        case 'a':
                cout << "\nEnter the product number:  ";
                int pNumber;
                cin >> pNumber;
                for (int i = 0; i < productNumber.size(); i++)
                        if(pNumber == productNumber[i])
                                cout << productNumber[i] << productPrice[i] << "\n";
                break;
        case 'B':
        case 'b':
                cout << "\nCurrent Inventory and Prices:\n\n";
                for (int i = 0; i < productNumber.size(); i++)
                        cout << "\t" << productNumber[i]<< productPrice[i] << "\n";
                break;
        default:
                cout << "\nInvalid selection.  Please try again."
                        << MENU;
        }
        readInFile.close();
        cout << "\n";
        return 0;
}

---

Sorry! I didn't take the time to clean up the tab and space issue. Not quite sure how to get it posted correctly from the copy and paste function.

Ok So what if I remove the '$' from my file and then use it in my cout as a string when I display the info? Is that the easiest fix?

I removed the '$' from each price entry and it prints. So that is the issue.
I think that I can get teh rest to work from what I know. I will be back if I can't figure it all out.
Thanks everyone!

since the text file doesnt have to be user-friendly, that may be the quickest fix. have your product number and price separated by a single space.

if you leave it as-is, you could read in a double, then a string which would result in '101' and '$ 45.00' respectively, correct? again, i think editing the text file would be quickest. however, you should make it error-proof so whoever is editing the text file at any point, doesnt have to worry about following such a strict (ie "one space") template.

So should I change type of my price vector to string and that will eliminate ALL issues with reading in thefile correctly?

give it a shot and find out.
it would be a little more work to remove the $ in the file and just use two double's and making it error-proof, but would be better i think.

I tried it and becasue I had the '.' aligned in my text file, there were spaces between the '$' and the number on some prices. That means those didn't display anything except the '$'. So I eliminated the spaces and it prints correctly. I don't know what my best solution is. I think I am doing more than expected for this program assignment, but my intent is to learn the language and all its nuances not just pass the class. I may just go with it as is and move on to the next problem.

This class is tough. It is an online class. There are 6 tests. The first 5 have 6 programs to write; the last has 9 and there are 9 more labs programs besides and the text is 850 pages. I am to have it all done in 8 weeks.

if you have a lot of other work to do then it would probably be best to continue. since it seems you have completed the assignment to their requirements, and, more importantly, understand the flaws in their specifications and realize how to improve the program to make it more user-friendly and bug-free.

again, i would think allowing for 2 doubles on a line, product number first and price second, with no restriction on spacing, would be the best solution.

if this is an 'advanced' or sped-up course, you can now see the major downside to it: you will have the same amount of content to be covered, in a shortened period. often in beginner programming courses they require you to do many programs with the goal of having the expected output when a specific input is given. this is opposed to having the program work _completely_ and efficiently.

This is an intro course. But the time limit is a standard time limit for this university. I have been trying to convince the 'decision makers' that someone needs to evaluate the content of the classes to make sure the 'average student' can complete the course in the time allowed, especially with the lack of response from the instructors.
So far no one is listening.
I have been working on this class for 36 days with one more program for test 5 before moving onto test 6. So I am doing well, but...I have to have this class and the next one - Data Structures (35 programs) done by October 29th because of other issues with other classes. It is a pressure cooker.
So I thank you immensely for your help.