File output not working.

Hey all,

Been a while since I've done any file output, so I'm needing some help here.

I basically just want to save a one line string to a file with the current date and time as the file name. Everything compiles and runs fine, but it just doesn't save.

Code:

---

time_t now;
    time(&now);
   
    string filePath = "C:\\Kysat\\Ground Station\\Sent Packets";
    string fileName = ctime(&now);
    fileName += ".txt";
    filePath += "\\" + fileName;

    string packetString = "";
    cout << filePath << endl;
    char fullName[100];
    for(int i = 0; i < filePath.length(); i++)
    {
            fullName[i] = filePath[i];
    }
    for(int i = 0; i < (int)pkt_size; i++)
    {
            packetString += packet[i];
    }
    ofstream packetsent(fullName);
    packetsent << packetString << endl;
    packetsent.close();

---

Any help on why it's not creating the file would be awesome. Thanks!

It's quite likely that something in your filename is conflicting with the naming rules for the OS. For example, ":" is not allowed within Windows file-names. Other OS's and file-systems may have other rules. Try replacing any ":" with "_" or "-" or some such. Or use strftime() to format the name as you wish without ':' in the name.

--
Mats

Why do you bother to create a char array version of the filename, from the look of it, without a \0 at the end as well.

Use
ofstream packetsent( filePath.c_str() );

Quote:

---

Originally Posted by Salem

Why do you bother to create a char array version of the filename, from the look of it, without a \0 at the end as well.

Use
ofstream packetsent( filePath.c_str() );

---

Good spot, Having some random garbage at the end will OBVIOUSLY not help making the name valid.

--
Mats

Well, I went ahead and implemented what matsp suggested and it worked.

Code:

---

time_t rawtime;
    struct tm * timeinfo;
    char buffer [80];

    time ( &rawtime );
    timeinfo = localtime ( &rawtime );
   
    string filePath = "C:\\Kysat\\Ground Station\\Sent Packets";
    strftime(buffer,80, "%a_%b_%d__%H_%M_%S__%Y", timeinfo);
    string fileName = buffer;
    fileName += ".txt";
    filePath += "\\" + fileName;

    string packetString = "";
    cout << filePath << endl;
    char fullName[100];
    for(int i = 0; i < filePath.length(); i++)
    {
            fullName[i] = filePath[i];
    }
    for(int i = 0; i < (int)pkt_size; i++)
    {
            packetString += packet[i];
    }
    ofstream packetsent(fullName);
    packetsent << packetString << endl;
    packetsent.close();

---

As for why I made a character array instead of doing filePath.c_string(), I tried that, but got compile errors, so decided to do something different. I may try again like that if I've got time later.

Thanks for the help.

Quote:

---

As for why I made a character array instead of doing filePath.c_string(), I tried that, but got compile errors

---

That's because it's: filePath.c_str() not .c_string()