Invoice Record Class

I am trying to create a class called record... every thing seems to be ok but it wont let me compile it... i keep getting this error

Code:

---

error C3867: 'Record::printRecord': function call missing argument list; use '&Record::printRecord' to create a pointer to member

---

reffering to "a.printRecord;"

what am i doing worng :S

Code:

---

class Record {
private:
        std::string item;
        int invoiceNum;
        double cost;
        int date;
public:
        Record(std::string item, int invoiceNum, double cost, int date);
        void inputRecord(std::string, int, double, int);
        void printRecord();
};
Record::Record(std::string = "item", int = 0000000, double = 00.00, int =  32) {
        item = item;
        invoiceNum = invoiceNum;
        cost = cost;
        date = date;
}
void Record::inputRecord(std::string item, int invoiceNum, double cost, int date) {
        item = item;
        invoiceNum = invoiceNum;
        cost = cost;
        date = date;
}
void Record::printRecord() {
        printf("%s\t\t%i\t$ %f\t%i/08/06\n", item, invoiceNum, cost, date);
}
int _tmain(int argc, _TCHAR* argv[])
{
        Record a,b("Item", 1234567, 00.00, 12);

        a.inputRecord("sdersdfg sdf fff", 7654321, 99.99, 20);

        a.printRecord;
        b.printRecord;
        return 0;
}

---

Code:

---

    a.printRecord();
    b.printRecord();

---

Quote:

---

Originally Posted by robwhit

Code:

---

    a.printRecord();
    b.printRecord();

---

---

Thats, that was a stupid mistake... lol.. should of picked that up myself..

it all works now, but the data i am getting back is all over the shop :S

Code:

---

(null)          -858993460      $ -925596313493155010000000000000000000000000000
00000000000000000.000000        -858993460/08/06
(null)          -858993460      $ -925596313493155010000000000000000000000000000
00000000000000000.000000        -858993460/08/06
Press any key to continue . . .

---

Looks like there are other problems:
1. Your constructor definition has illegal syntax. For example, the first parameter does not have a name.

2. In both your constructor and inputRecord() member function, you assign the arguments to themselves. You either have to use different names for the member variables or arguments, or prefix the member variables with this->.

3. You attempt to use printf() with a %s format specifier on a std::string. I suggest either using an I/O stream, or using the c_str() member function of std::string.

EDIT:
Oh wait, looks like the constructor syntax is legal! Unfortunately, I cannot figure out what it means, and I am sure what it means is not what you want.

Quote:

---

Originally Posted by laserlight

Looks like there are other problems:
1. Your constructor definition has illegal syntax. For example, the first parameter does not have a name.

2. In both your constructor and inputRecord() member function, you assign the arguments to themselves. You either have to use different names for the member variables or arguments, or prefix the member variables with this->.

3. You attempt to use printf() with a %s format specifier on a std::string. I suggest either using an I/O stream, or using the c_str() member function of std::string.

EDIT:
Oh wait, looks like the constructor syntax is legal! Unfortunately, I cannot figure out what it means, and I am sure what it means is not what you want.

---

Thanks laserlight, It was my first attempt at a class... and it works now :D :D thanks

Code:

---

class Record {
private:
        std::string item;
        int invoiceNum;
        double cost;
        int date;
public:
        Record(std::string = "item", int = 0000000, double = 00.00, int =  32);
        void inputRecord(std::string, int, double, int);
        void printRecord();
};
Record::Record(std::string _item, int _invoiceNum, double _cost, int _date) {
        item = _item;
        invoiceNum = _invoiceNum;
        cost = _cost;
        date = _date;
}
void Record::inputRecord(std::string _item, int _invoiceNum, double _cost, int _date) {
        item = _item;
        invoiceNum = _invoiceNum;
        cost = _cost;
        date = _date;
}
void Record::printRecord() {
        std::cout << item << "\t\t"
                        << invoiceNum << "\t\t$ "
                        << cost << "\t"
                        << date << "/08/06\n";
}

---

include the header files string windows.h and cstdio, for std::string _TCHAR and printf. this does nothing:

Code:

---

        item = item;
        invoiceNum = invoiceNum;
        cost = cost;
        date = date;

---

haven't seen this notation before:

Code:

---

Record::Record(std::string = "item", int = 0000000, double = 00.00, int =  32)

---

I would suggest writing in the parameter names.

Ah, I kind of figured out what that syntax means, and I guess you might have as well: it is just the "parameter names can be left out until the definition" with a default argument thing. It is rather strange that it came with the member function definition rather than in the class declaration, and that threw me off.

In its current form, your code is fine, though I still suggest having the parameter names so as not to confuse others.

Incidentally, you might want to use a constructor initialisation list instead of assigning in your constructor.

I would also caution against using variable names with a leading underscore. If you happen to follow that with another underscore, or with an uppercase letter, or use the name for a global variable, then you would have used a name reserved to the implementation.