Struct error

I'm new in structs so this question might sound silly, but I cannot see the problem:

I'm defining a struct in the header. This is the struct:

Code:

---

// struct to sentencedata
struct sentencestruct {
        int numberOfSentences;
        char *sentenceArr[10000];
};

---

But when I'm trying to use it i get error-messages:

Code:

---

void speechrecognitioncontrol() {

int tempnt=0;
struct sentencestruct speechSentences;
signed int  pid;
int i;
....

---

Compiling gives this error:

control-module.c:380: error: storage size of 'speechSentences' isn't known


Somebody please help..

You need to include that header file in the source file which uses it.

Quote:

---

Originally Posted by Salem

You need to include that header file in the source file which uses it.

---

I have done that.. But i might not have written extern struct ... (like other extern variables is defined) in the beginning, now you mention it.. I'll try it out right away..

It don't seem to work.. in the beginning of the file is written:

Header:

Code:

---

// struct to sentencedata
struct sentencestruct {
        int numberOfSentences;
        char *sentenceArr[10000];
};

---

.c file:

Code:

---

#include "control-module.h"
extern struct sentencestruct;

....
void speechrecognitioncontrol() {

int tempnt=0;
struct sentencestruct speechSentences;
signed int  pid;
int i;
....

---

Now i only get one warning about this extern struct:
warning: useless keyword or type name in empty declaration
control-module.c:382: error: storage size of 'speechSentences' isn't known

extern struct sentencestruct;

is just like
extern int;

it has no meaning

is this code

Code:

---

// struct to sentencedata
struct sentencestruct {
        int numberOfSentences;
        char *sentenceArr[10000];
};

---

located in the "control-module.h" header? or some other header?

I know i has no meaning, but if its not defined as en extern ressource then it cannot refference it.. ;)

And no i is defined in global.h which is compiled together and all other variables in it is working fine.. But you caught the problem I think. :) Because after I tried to move it to my control-module header it can now find it; it seems at least at the moment.. Why can't I define this in the global header where all the files have access to. .?

Quote:

---

Originally Posted by sniper83

I know i has no meaning, but if its not defined as en extern ressource then it cannot refference it.. ;)

And no i is defined in global.h which is compiled together and all other variables in it is working fine.. But you caught the problem I think. :) Because after I tried to move it to my control-module header it can now find it; it seems at least at the moment.. Why can't I define this in the global header where all the files have access to. .?

---

Putting something in a header file means jack if the source file in question does not #include that header file. There is no global header file that is automatically accessed by all the source files. If the struct was defined in global.h then you should have #include'd global.h for the compiler to recognize the struct.

It seem that I can make a struct.h and put all the structs in it, and then include this one in both c-files where i use them..

But now I get another error due to these. It complains about this line in one of the files:

Code:

---

struct sentencestruct speechSentences;
...
speechSentences =        receiveMsgSpeechRecognition();

---

with this message:
control-module.c:518: error: incompatible types in assignment

but the metod is declared like this in the other one:

Code:

---

struct sentencestruct receiveMsgSpeechRecognition() { ... }

---

Doesn't it look right..? The sentencestruct now is defined in one header structs.h which is included in both files..

Quote:

---

Originally Posted by hk_mp5kpdw

Putting something in a header file means jack if the source file in question does not #include that header file. There is no global header file that is automatically accessed by all the source files. If the struct was defined in global.h then you should have #include'd global.h for the compiler to recognize the struct.

---

Thanks alot... But I have had no problems of the global variables.. :S Strange.. But I just included the global.h in all the files and now the other problem dissapered as well..

Thanks you all.. Great help.. :)

NO.. Maybe I was a litte fast.. The makefile just make it seem it was not there anymore.. It still exists.. :/
Help will be appresiated..

btw: All the extern references to the variables in the files i had in the header as it complaint about without extern, should i delete these..?

Post all your files for this project you're working on as attachments and all the error messages reported by the compiler.

Quote:

---

Originally Posted by hk_mp5kpdw

Post all your files for this project you're working on as attachments and all the error messages reported by the compiler.

---

It seriously a lot of code.. And alone the two files we talk about is around 3000-4000 lines.. I tries to seperate the problem in two c-files wih only the nessasary methods and their headers and upload them in a couple of minutes..

Okay.. Now I have seperated it.. Just run make, and you will see the problem.. EDIT: Cannot upload the makefile, but I uploads it in a second in makefile.h. Just erase the .h and run it.. Orelse the output is

[...Temp4]# make
cc -c -o control-module.o control-module.c
control-module.c: In function `speechrecognitioncontrol':
control-module.c:126: error: incompatible types in assignment
control-module.c:132: error: incompatible types in assignment
make: *** [control-module.o] Error 1

And the makefile..

Well, for the code you've provided, I also get undefined function messages for receiveMsgSpeechRecognition and also RecogniseWordInSentence which would account for those errors. If the compiler doesn't understand what those two functions are then it will assume they return an int and then you get the errors because it can't convert an int to type struct sentencestruct. So, where are the prototypes for those two functions located?

Also, instances of variables should be restricted to the source files and not put into headers like you've done in global.h. Header files should generally contain function prototypes and extern statements and struct definitions while the source file(s) that #include those headers contain the actual instances of any variables.

Quote:

---

Originally Posted by hk_mp5kpdw

Well, for the code you've provided, I also get undefined function messages for receiveMsgSpeechRecognition and also RecogniseWordInSentence which would account for those errors. If the compiler doesn't understand what those two functions are then it will assume they return an int and then you get the errors because it can't convert an int to type struct sentencestruct. So, where are the prototypes for those two functions located?

Also, instances of variables should be restricted to the source files and not put into headers like you've done in global.h. Header files should generally contain function prototypes and extern statements and struct definitions while the source file(s) that #include those headers contain the actual instances of any variables.

---

The two messages is alike and thats right, i only posted the receiveMsgSpeechRecognition-method in file: speechRecognition.c.. Just outcomment the other one..
..... DAMN ME....... The most obvious thing just happend.. The definition in the c-file is good enough, but the declaretion in the header speechRecognition.h have a return-type of int... I changed it when i reconstructed the code in the c-file..

But It's global variables that should be avaliable everywhere, in all the files..? It should be possible to change them from all c-files... Theres an excact reason for that.. How should I do it else..?

Once again I thought I had the error but appertently not.. :(

Okay I might have found the problem, but why..?!

I have changed a bit...

c-file:

Code:

---

void RecogniseWordInSentence(struct sentencestruct ........) {...}

---

if I define it in the header like this:

Code:

---

void RecogniseWordInSentence(struct sentencestruct *);

---

i get same error:
[ex44@jensen final]# make
cc -c -o control-module.o control-module.c
control-module.c: In function `speechrecognitioncontrol':
control-module.c:541: error: incompatible type for argument 1 of `RecogniseWordInSentence'
make: *** [control-module.o] Error 1


But if I remove it from header or refine header to:

Code:

---

void RecogniseWordInSentence();

---

then it accepts it.. I think it is strange..? And can I expect i works without..?

Code:

---

void RecogniseWordInSentence(struct sentencestruct ........)

---

I hope this isn't what you really have in the file.

Quote:

---

Originally Posted by sniper83

The two messages is alike and thats right, i only posted the receiveMsgSpeechRecognition-method in file: speechRecognition.c.. Just outcomment the other one..
..... DAMN ME....... The most obvious thing just happend.. The definition in the c-file is good enough, but the declaretion in the header speechRecognition.h have a return-type of int... I changed it when i reconstructed the code in the c-file..

But It's global variables that should be avaliable everywhere, in all the files..? It should be possible to change them from all c-files... Theres an excact reason for that.. How should I do it else..?

---

Let's say you have a project with 2 source files (example1.c and example2.c) and you need to have globals that can be used/accessed in both source files. You put the instances/declarations of the globals in one of the files and then have a header (example.h) with all those variables but declared with extern as well.

example.h

Code:

---

#ifndef EXAMPLE_H
#define EXAMPLE_H

// These externs represent some globals in example1.c
extern int global_ex1_1;
extern int global_ex1_2;

// These externs represent some globals in example2.c
extern int global_ex2_1;
extern int global_ex2_2;

#endif

---

example1.c

Code:

---

// By including example.h, we can also access the globals declared in example2.c
#include "example.h"

int global_ex1_1;
int global_ex1_2;

---

example2.c

Code:

---

// By including example.h, we can also access the globals declared in example1.c
#include "example.h"

int global_ex2_1;
int global_ex2_2;

---

You have it backwards currently, many of your extern'd variables are in the source file while the instances themselves are in the header file global.h. If you were to ever #include global.h (as it stands now) in two different source files then you'd get tons of errors when linking your project because of multiple definitions of the same variable name.

Quote:

---

Originally Posted by robwhit

Code:

---

void RecogniseWordInSentence(struct sentencestruct ........)

---

I hope this isn't what you really have in the file.

---

Of cause not..
Should have been

Code:

---

void RecogniseWordInSentence(struct sentencestruct ........){....}

---

WOW.. I cant scribe * s s in one word... :S Okay "........" means *ass minus the a..
EDIT: Redifined to ds instead of ss

Code:

---

void RecogniseWordInSentence(struct sentencestruct *ds){....}

---

Thanks hk_mp5kpdw, Then I'll turn it upside down and do it right this time.. ;)