What's wrong with my success statement??

Just a simple program to return an average value from a separate file. I can only type in the number 1 through 4 for the column_number. Any ideas?

Code:

---


#include <stdio.h>
#include "utils.h"
#define FILENAME "data.txt"


int main () {

        int column_number;
        double average;
        char success = 1;

        FILE *f;
        f=fopen("data.txt", "r");  //open file

        printf("Enter the source column: ");
        scanf("%i", &column_number);


switch (column_number) {

                case '1':

                        average = column_average(f,column_number);

                        break;

                case '2':

                        average = column_average(f,column_number);

                        break;

                case '3':

                        average = column_average(f,column_number);

                        break;

                case '4':

                        average = column_average(f,column_number);

                        break;


                default:

                success = 0;



break;

}

if (success)


        printf("The average of column %i is %.3e", column_number, average);

        else

        printf("Invalid column number");




return 0;


}

---

Thanks!!

Ty

> case '1':
You're typing in numeric 1, not character '1'
So drop the single quotes.

Quote:

---

Originally Posted by cool_dude07

Just a simple program to return an average value from a separate file. I can only type in the number 1 through 4 for the column_number. Any ideas?

Code:

---


#include <stdio.h>
#include "utils.h"
#define FILENAME "data.txt" // This is questionable

        f=fopen("data.txt", "r");  //open file
      // at this point, your actually calling fopen(""data.txt"", "r") 2 double quotes ??
      //  a better way is: char *filename = "data.txt";

        printf("Enter the source column: ");
        scanf("&#37;i", &column_number);


switch (column_number) {

                case '1':

                        average = column_average(f,column_number);

                        break;

                case '2':

                        average = column_average(f,column_number);

                        break;

                case '3':

                        average = column_average(f,column_number);

                        break;

                case '4':

                        average = column_average(f,column_number);

                        break;


                default:

                success = 0;



break;

}

if (success)


        printf("The average of column %i is %.3e", column_number, average);

        else

        printf("Invalid column number");




return 0;


}

---

Thanks!!

Ty

---

Check commets above, eh nvm I see your not using FILENAME as an argument but still it's questionable practice.
if you want to define a string literal use a char * or char[]

thanks for the tips...but still no success (no pun intended) in filtering the input

Quote:

---

Originally Posted by cool_dude07

thanks for the tips...but still no success (no pun intended) in filtering the input

---

Post complete code. I see no "column_number" defined anywhere.

Quote:

---

Originally Posted by MacNilly

Post complete code. I see no "column_number" defined anywhere.

---

Code:

---

int main () {

    int column_number;

---

You really don't need a switch statement. You just need

Code:

---

if (column_number < 1 || column_number > 4)
{
    printf("Invalid column number");
    return 0;
}

average = column_average(f,column_number);
printf("The average of column %i is %.3e", column_number, average);

return 0;

---

Quote:

---

Originally Posted by robwhit

Code:

---

int main () {

    int column_number;

---

---

Eh forget it

I think at least one of your problems was declaring an integer variable and then comparing it to character literals.

I'm not sure if that's guaranteed to work on all systems. If you want to compare an int to and int do that.