pigLatin, code prints funny characters

Hi,

This is a program which converts an english phrase to pigLatin. The algorithm is to take out the first letter of the word and puts it after the last character of the english word (ignoring '\0' ) plus adding 'ay' after that. Somehow, it doesn't work. Pls direct. Thnx in advance.

Code:

---

#include <stdio.h>
#include <string.h>

void printLatinWord( char *s );

int main()
{
  char engPhrase[] = "This is an english sentence.";

  printf( "Original string: \n%s\n\n", engPhrase );

  printf( "String converted to pigLatin: \n" );

  printLatinWord( engPhrase );

  system( "PAUSE" );
  return 0;
}

void printLatinWord( char *s )
{
  char *tokenPtr;
  char temp[ 4 ];
  char b[ 3 ] = "ay";

  tokenPtr = strtok( s, " " );

  while ( tokenPtr != NULL ) {
      temp[ 0 ] = tokenPtr[ 0 ];
      strcat( temp, b );
      strcat( tokenPtr, temp );
      printf( "%s\n", tokenPtr );
      tokenPtr = strtok( NULL, " " );
  }
}

---

>>> temp[ 0 ] = tokenPtr[ 0 ];

This line copies the first character of one string to the first character of the other, but the destination string is not correctly terminated, it contains the character you have copied plus any other rubbish that was there before. You need to put a '\0' character in position temp[1] before calling strcat().

You'll then discover you have another problem!

yea it still prints funny characters. How to fix THAT?

thnx

>>> tokenPtr = strtok( NULL, " " );

That NULL looks a bit suspicious...

nope, i checked the book, thats the right way. What are the other problems thats preventing the pro to work correctly?

When you first call strtok() it sets up a static context. I don't think you can muck about with things after this has happened.

Code:

---

void printLatinWord( char *s )
{
  char *tokenPtr;
  char temp[ 4 ];
  char b[ 3 ] = "ay";

  tokenPtr = strtok( s, " " );
  tokenPtr = strtok( s, " " );

  while ( tokenPtr != NULL ) {
      temp[ 0 ] = tokenPtr[ 0 ];
      strcat( temp, b );
      strcat( tokenPtr, temp );
      printf( "%s\n", tokenPtr );
      tokenPtr = strtok( NULL, " " );
  }
}

---

This, for example, correctly chooses "This" as the first word and "is" for the second. The way you have it, after processing the first word, (This -> ThisTay), strtok() returns "ay".

why strtok returns "ay" ? It returns the next word after the delimiter whitespace doesn't it?

It should, but if you run your code in the debugger, you will see that it is not, (or at least, it is not with my compiler). I, as I mentioned before, suspect your have done something to the static context that strtok() maintains.

I tend not to use the functions that maintain static context, (not just because you can't see what is going on, they are, for example, not thread safe).

what exacltly should i do to the code, like which part do i edit?

Can someone please post a solution to my problem? I am pretty new with string manipulations. Maybe the fix to the problem is just a line or two but i dunno it. Pls direct.

thnx

Quote:

---

Originally posted by Nutshell
Can someone please post a solution to my problem? I am pretty new with string manipulations. Maybe the fix to the problem is just a line or two but i dunno it. Pls direct.

thnx

---

Code:

---

#include <stdio.h>
#include <string.h>

void printLatinWord( char *s );

int main()
{
  char engPhrase[] = "This is an english sentence";

  printf( "Original string: \n%s\n\n", engPhrase );

  printf( "String converted to pigLatin: \n" );

  printLatinWord( engPhrase );

  //system( "PAUSE" );
  return 0;
}

void printLatinWord( char *s )
{
  char *tokenPtr;
  char b[] = "ay";

  tokenPtr = strtok( s, " " );
  while (tokenPtr) {
      printf( "%s%s ", tokenPtr,b );
      tokenPtr = strtok( NULL, " " );
  }
}

---

How's that?

Mind you...I dont know pig latin..........do you just add 'ay' on the end?

I'm informed that in Piglatin you take the first letter and put it on the end and follow with 'ay' (What is this crap!!??!?!?!)

If so ...try;

Code:

---

#include <stdio.h>
#include <string.h>

void printLatinWord( char *s );

int main()
{
  char engPhrase[] = "This is an english sentence";

  printf( "Original string: \n%s\n\n", engPhrase );

  printf( "String converted to pigLatin: \n" );

  printLatinWord( engPhrase );

  //system( "PAUSE" );
  return 0;
}

void printLatinWord( char *s )
{
  char *tokenPtr;
  char b[] = "ay";
  char first;

  tokenPtr = strtok( s, " " );
  while (tokenPtr) {
      first = tokenPtr[0];
      ++tokenPtr;
      tokenPtr[strlen(tokenPtr)] = '\0';
      printf( "%s%c%s ", tokenPtr,first,b );
      tokenPtr = strtok( NULL, " " );
  }
}

---

The point I was trying to make is demonstrated by Fordy's first program, (it may not do exactly what you want but...), you notice he does not interfere with the "str" static context. Change his routine to this...

Code:

---

void printLatinWord( char *s )
{
  char *tokenPtr;
  char b[] = "ay";

  tokenPtr = strtok( s, " " );
  while (tokenPtr) {
      printf( "%s%s ", tokenPtr,b );
      strcat(tokenPtr,b);
      tokenPtr = strtok( NULL, " " );
  }
}

---

... notice the call to strcat(), this program is now screwed.

ok so i understand now, i can't do anything with the token returned by strtok() right? New thing i learnt. At first i was trying to push everything ( first letter and "ay" ) into the string token and never thought of simply jsut printing it. Thnx guys, thats clever, or am i just stupid? dun say that....

be careful about your the bounds of your character array....it should be able to grow to accomodate the new characters...create your arrary dynamically...

i know, but i'm not up to that part of my book yet....:p