What am I doing wrong? Code?

I am making a tax calculator for my last week of my UOP programming class, it's my last class and I need help trying to figure out how to make an exit command. I am also getting my code ot compile but when it comes to the sales amount it will configure it plus give me the error message that I made to input a value for money. I f I am making sense can someone help me please? Oh yah this is an accelerated class so bare with me please.

Code:

---

//------------------------------------------------------------/
//Program Name: TaxCalc.c                            //////////
//Written By: Jerald Komer                          //////////
//Date: June 27, 2007                                //////////
//Description: Week 5 Individual Assignment          //////////
//              POS370 John Tatum                  //////////
//              University of Phoenix              //////////
//------------------------------------------------------------/

//------------------------
// Specific Functions
//------------------------
#include <stdio.h>
#include <stdlib.h>

//----------//
// Main    //
//----------//
main()
{
      //---------------////////////////////////
      //Variables//////////////////////////////
      //---------------////////////////////////
      int iSelection=0;
      float input_Valid=0;
      float z=0;
      float e=.0725;
      float f=.075;
      float g=.0775;
   
      //User View////////////////////////////////////////////////////
      printf("\nTax generated from sales for Kudler Fine Foods\n");
      printf("Three locations with the following tax rates.\n\n\n");
   
      printf("\n");
   
      //Tax rates for each location////////////////////////////
      printf("Kudler Del Mar Location\t\t\t\t 7.25&#37;%\n");
      printf("Kudler Encinitas Location\t\t\t 7.5%%\n");
      printf("Kudler La Jolla Location\t\t\t 7.75%%\n\n");
     
      printf("\n");
      printf("\n");
      ///// Input Location/////////////////////////////////
     
      printf("1\tKudler Del Mar Location\n");
      printf("2\tKudler Encinitas Location\n");
      printf("3\tKudler La Jolla Location\n");
      printf("4\tExit Menu\n");
      printf("\n");
      printf("\n");
      printf("\tEnter selection (1-4):");
      printf("\n");
      //Sale amount
do
      {
      printf("\n");     
      printf("\n\tPlease enter your selection:\t");
      input_Valid=scanf("%d",&iSelection);
      if(!input_Valid)
      {
      printf("\n\n Error:Incorrect Entry Type-Must be selection (1-4)!\n\n");
     
      system("pause");
      }
      fflush(stdin);
      rewind(stdin);
                           
      }while(!input_Valid);
      ///loop ends

      ///amount///
do
      {
           
      printf("\n Sale Amount:\t");
      input_Valid=scanf("%f",&z);
      if(!input_Valid);
      {
      printf("\n\n Error:Incorrect Entry Type-Must be money format!\n\n");
      }
      fflush(stdin);
      rewind(stdin);
                           
      }while(!input_Valid);
     
      //// Store selection/////
if (iSelection==1)//////Del Mar///////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for Del Mar is:\t\t%.2f\n", z*e);
      printf("\nThe total amount for Del Mar location is:\t%.2f\n\n", z*e+z);
      }
   
if (iSelection==2)///// Encinitas//////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for Encinitas is:\t\t%.2f\n", z*f);
      printf("\nThe total amount for Encinitas location is:\t%.2f\n\n", z*f+z);
      }

if (iSelection==3)/////La Jolla/////////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for La Jolla is:\t\t%.2f\n", z*g);
      printf("\nThe total amount for La Jolla location is:\t%.2f\n\n", z*g+z);
      }
     
if (iSelection==4)/////Exit/////////
      {
      printf("\nExit\n");
     
      }
      system("pause"); 
      }

---

okay I found an exit command but I am still doing something wrong when I enter 4 for exit it should close but it asks me for sales amount.

Code:

---

{
            exit(0);                /* Clean exit */
          }

---

This is what I put for 4

Code:

---

fflush(stdin);

---

Don't do that, see the FAQ. rewind()ing stdin is a bad idea, too. A recent thread showed that seeking stdin is not very portable.

input_Valid should be an int, that's what scanf() returns.

You can exit the program immediately within main with a return statement, or from anywhere in the program (including main()) with exit(). exit() is passed one parameter: the value to return. So exit(0) is like return 0 in main. exit(1) usually indicates an error, exit(0) normal termination. [edit] Never mind, you found this. Where did you add it in? [/edit]

I fixed the exit command by putting the command in another area.

Code:

---

do
      {
      printf("\n");     
      printf("\n\tPlease enter your selection:\t");
      input_Valid=scanf("%d",&iSelection);
      if(!input_Valid)
      {
      printf("\n\n Error:Incorrect Entry Type-Must be selection (1-4)!\n\n");
     
      system("pause");
      }
      if (iSelection==4)/////Exit/////////
      {
      exit(0);                /* Clean exit */
      }
      fflush(stdin);
      rewind(stdin);
                           
      }while(!input_Valid);
      ///loop ends

---

I also took out the fflush(stdin); this is how the instructor did it sorry. All I have wrong now is when I input the sales amount it does the calculations but also the error is this

Code:

---

printf("\n\n Error:Incorrect Entry Type-Must be money format!\n\n");

---

how do I fix that?

I think the instructor made those errors on purpose to test your ability to debug. Since that is part of the assignment, please do your own homework.

Someone please close this thread.

Quote:

---

Originally Posted by abachler

I think the instructor made those errors on purpose to test your ability to debug. Since that is part of the assignment, please do your own homework.

---

I think it's far more likely that the instructor is clueless. Seen it too many times.

I did do my own homework thanks. I am not asking anyone to correct my work am I asking does anyone know why my error input message is coming up when I enter my sale amount I am in class now and the instructor doesn't even know. I am in a 5 week class 1 day a week I am not doing a complete C programing class it's accelerated again. I dont know why my error message keeps coming up?

Well at any rate, this is what follows immediately after the printf and scanf part.

Code:

---

/* I did not make an attempt to fix the obvious detractions from the Standard. */
  do
  {
    printf( "\n Sale Amount:\t" );
    input_Valid = scanf( "%f", & z );
    if ( !input_Valid );
    {
      printf( "\n\n Error:Incorrect Entry Type-Must be money format!\n\n" );
    }
    fflush( stdin );
    rewind( stdin );
  }
  while ( !input_Valid );

---

A do..while loop is obviously not appropriate here, despite the code's other issues as discussed in this thread. This code is going to run at least once regardless of your input, and then it might quit, or crash, or do as you intended. Rethink the logic of this program, rewrite, and then debug it yourself.

Ummm not to sound stupid but we didn't cover debugging it has been all trial and error. I wrote the code off my week 2 assignment, when we first started copying and writing this code. the code as messed up as it is runs fine and as intended I take the loop out and it doesn't hmm dunno whats wrong lol thanks though.

Don't just delete the loop, you need to write the loop in a different way so that you can input values only when they're needed. In fact, did you learn what functions are and how to call them? If you broke up the program into simple tasks and wrote functions that complete those tasks, you'd have much better flow control.

The issue here is that you're using a do while loop immediately after your input section. If you ran the application and simply tried to quit, it would ask you for a sales amount before closing. That is indeed your problem.

when choosing 1-3 the program should ask for the sale amount after I choose my selection. When I choose the selection 4 it exits like it should also now. I am not understanding when I enter sale amount $20 it gives me "Error:Incorrect Entry Type-Must be money format" plus the calculated math tax and total. I just want the error to work when I enter anything other than a numeric expression but I am not understanding and class is almost over so I guess it won't matter.

can you post your modified code?

This is what my instructor said is okay it is doing as intended but the error no matter what when I enter the amount that is when I run it as stated.

Code:

---

/------------------------
// Specific Functions
//------------------------
#include <stdio.h>
#include <stdlib.h>

//----------//
// Main    //
//----------//
main()
{
      //---------------////////////////////////
      //Variables//////////////////////////////
      //---------------////////////////////////
      int iSelection=0;
      int input_Valid=0;
      float z=0;
      float e=.0725;
      float f=.075;
      float g=.0775;
   
      //User View////////////////////////////////////////////////////
      printf("\nTax generated from sales for Kudler Fine Foods\n");
      printf("Three locations with the following tax rates.\n\n\n");
   
      printf("\n");
   
      //Tax rates for each location////////////////////////////
      printf("Kudler Del Mar Location\t\t\t\t 7.25%%\n");
      printf("Kudler Encinitas Location\t\t\t 7.5%%\n");
      printf("Kudler La Jolla Location\t\t\t 7.75%%\n\n");
     
      printf("\n");
      printf("\n");
      ///// Input Location/////////////////////////////////
     
      printf("1\tKudler Del Mar Location\n");
      printf("2\tKudler Encinitas Location\n");
      printf("3\tKudler La Jolla Location\n");
      printf("4\tExit Menu\n");
      printf("\n");
      printf("\n");
      printf("\tEnter selection (1-4):");
      printf("\n");
      //Sale amount
do
      {
      printf("\n");     
      printf("\n\tPlease enter your selection:\t");
      input_Valid=scanf("%d",&iSelection);
      if(!input_Valid)
      {
      printf("\n\n Error:Incorrect Entry Type-Must be selection (1-4)!\n\n");
     
      system("pause");
     
      }
      if (iSelection==4)/////Exit/////////
      {
      exit(0);                /* Clean exit */
      }
      fflush(stdin);
      rewind(stdin);
                           
      }while(!input_Valid);
      ///loop ends

      ///amount///
do
      {
           
      printf("\n Sale Amount:\t");
   
      input_Valid=scanf("%f",&z);
      if(!input_Valid);
     
      {
      printf("\n\n Error:Incorrect Entry Type-Must be money format!\n\n");
     
     
      }
      fflush(stdin);
      rewind(stdin);       
      }while(!input_Valid);
     
      //// Store selection/////
if (iSelection==1)//////Del Mar///////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for Del Mar is:\t\t%.2f\n", z*e);
      printf("\nThe total amount for Del Mar location is:\t%.2f\n\n", z*e+z);
      }
   
if (iSelection==2)///// Encinitas//////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for Encinitas is:\t\t%.2f\n", z*f);
      printf("\nThe total amount for Encinitas location is:\t%.2f\n\n", z*f+z);
      }

if (iSelection==3)/////La Jolla/////////
      {
      printf("\nYour transaction amount input is:\t%.2f\n", z);
      printf("\nThe tax result for La Jolla is:\t\t%.2f\n", z*g);
      printf("\nThe total amount for La Jolla location is:\t%.2f\n\n", z*g+z);
      }
     


      system("pause"); 
      }

---

Okay I don't know what I did, but I copy pasted the same info in my code and I fixed my error and I don't know why but it's fixed thanks all.

Code:

---

input_Valid=scanf("%d",&iSelection);

if(!input_Valid)
}while(!input_Valid);

---

not good. the scanf return the number variables read in CORRECTLY. This will fail if the scanf function succeeds. fix it for all the places you use that variable like that.

http://www.cplusplus.com/reference/c...dio/scanf.html