Big Confusion on an easy Program

I am trying with all my power to make this little program work! I have to make a pogram that copies input to output and replaces each string of a blank or more by a single blank!

It is exercise 1-9 if you have The C Programming Language book, second edition!

This is how far I got of it, but I know it is wrong since the compilers prints 102 infinitely! I will post my wrong noob code hoping that someone capable will give me a hint and tell me what am I doing wrong!Here is the code:

Code:

---

#include <stdio.h>

main()
{
int blank;
int x;
blank = 0;
x = getchar();

while (x != EOF)
{
if (x == '  ');
    printf("%d\n", x);
}

}

---

Quote:

---

x == ' '

---

2 spaces instead of 1, you also don't change X on every loop (I think your supposed to...)

Code:

---

while ((x = getchar()) != EOF)
{
    if (x == ' ')
        printf("%d\n", x);
}

---

Also try and work on your indenting :)

Quote:

---

Originally Posted by cookie

I have to make a pogram

---

http://en.wikipedia.org/wiki/Pogram

Yikes! ;)

Quote:

---

Originally Posted by cookie

This is how far I got of it, but I know it is wrong since the compilers prints 102 infinitely!

---

Look at what is inside your loop. Of course it's just going to kee printing the same thing.

Quote:

---

Originally Posted by cookie

I will post my wrong noob code hoping that someone capable will give me a hint and tell me what am I doing wrong!

---

What you need to do is have a loop where the condition is to keep reading until EOF. Inside the loop, you need to a check if the character read is a blank char... Then if so, replace it and enter another loop that just eats the whitespace chars (by just reading and doing nothing until the next char is not a blank one).

If you are using C rather than C++, main() should be int main(). Also, a character uses the "char" variable type, not an "int". I don't have the book. EOF means "end of file" so unless reading or writing files, there's no need for this. Also, for single quotes, you should only have one character inside, not two. For multiple, you'd use double quotes and have one extra that's big enough to store the entire string plus the null character. Also, there shouldn't be a semicolon at the end of an if statement. I'm not sure if you've learned any of this or not. Also, better indentation could make the code easier to read, especially if it gets into the hundreds or thousands of lines with many nested things (like loops and if statements).

I see quite a few syntax errors and things that would show warnings in your compiler. What compiler do you use? You may want to turn up the warning level.

Quote:

---

Originally Posted by ulillillia

Also, a character uses the "char" variable type, not an "int".

---

getchar() returns an int. This is necessary due to EOF. Your data will be messed up in certain circumstances if you don't use an int.

I'm not familiar with getchar since I don't use it. I just saw the content in the quotes so I thought it should be a string, thus the "char" is used. Oh well.

> if (x == ' ');
What does that ; do ?

A semicolon ( ; ) is a punctuation mark used to separate words opposed in meaning and to mark off interdependent statements. It binds two sentences more closely than they would be if separated by a full stop/period. It often replaces a conjunction such as and or but. Writers might consider this appropriate where they are trying to indicate a close relationship between two sentences, or a 'run-on' in meaning from one to the next; they do not want the connection to be broken by the abrupt use of a full stop. It is used as a stronger division than a comma, or a "super comma", to make meaning clear in a sentence where commas are being used for other purposes. A common example of this use is to separate the items of a list when some of the items themselves contain commas.

Quote:

---

Originally Posted by ulillillia

If you are using C rather than C++, main() should be int main(). Also, a character uses the "char" variable type, not an "int". I don't have the book. EOF means "end of file" so unless reading or writing files, there's no need for this.

---

You can write EOF in the terminal (for example if you wanted to end the program...) And you should know that EOF doesn't fit into a char ;), getchar() is standard so you should also know that ;)

The code, my code, neither the one posted by zacs7 worked! All it would do, it would print 32 for each space I had in my sentence! But what I did, is made it print a blank space instead of x using this

printf(" \n");

instead of:

printf("%d\n", x); that woukd print 32 instead of a blank!


Thanks alot everybody! here is the final code

Code:

---

#include <stdio.h>

int main()
{
        int x;
        while ((x = getchar()) != EOF)
        {
            if (x == ' ')
            printf(" \n");
        }
}

---

P.S. I learned to indent properly!


Thanks Everybody!

Quote:

---

P.S. I learned to indent properly!

---

Nearly :P you if statement still is not indented inside the loop, but then I'm just nit picking ;)

:\ you never explained your problem... I assumed you wanted to print the ascii position of a space.