Switch structure not working

Hello again everyone... I'm kind of stumped on this one. I'm writing a small text based game, and none of my switch structures seem to be working. I am almost positive that the syntax is correct, but no matter what the input is, it always goes to the default choice, which returns to the menu. Here's my code:

Code:

---

switch(main_menu_choice){
                            case 1:
                            system("cls");
                            goto Play1;
                            case 2:
                            system("cls");
                            goto Help;
                            case 3:
                            exit(0);
                            default:
                            cout<<"Invalid entry. restarting game...";
                            system("Pause");
                            system("cls");
                            goto MainMenu;
                            }

---

I have no idea what goes wrong. This should work, shouldnt it?

You forgot your break; statements.

Code:

---

switch(main_menu_choice){
    case 1:
    system("cls");
    goto Play1;
    break;
    case 2:
    system("cls");
    goto Help;
    break;
    case 3:
    exit(0);
    break;
    default:
    cout<<"Invalid entry. restarting game...";
    system("Pause");
    system("cls");
    goto MainMenu;
    break;
}

---

Also you will want to try and avoid using goto. there are some places it is needed. Although they are few and far between.
Avoid system() as well, look at the FAQ for ways to clear the screen.

break statements dont help, I've been trying for hours. it compiles, but it does not work.
About goto:
I know very well that goto is evil, but it's the only statement that I know that jumps to a specific section of the program, which is what I need for this.

You might try surrounding statements with ({}) braces. Also, main_menu_choice is an int correct?

Code:

---

switch(main_menu_choice)
{
    case 1:
{
    system("cls");
    goto Play1;
    break;
}
    case 2:
{
    system("cls");
    goto Help;
}
    break;
    case 3:
{
    exit(0);
}
    break;
    default:
{
    cout<<"Invalid entry. restarting game...";
    system("Pause");
    system("cls");
    goto MainMenu;
}
    break;
}

---

sorry for poor indention, but I dont have my editor on this comp

>>I know very well that goto is evil, but it's the only statement that I know that jumps to a specific section of the program, which is >>what I need for this.
Umm, functions?

Yes, it is all correct, and yes, the use of goto (and the wish to jump to a place in code) in this way is awful.

May-be main_menu_choice is a char, and that's why if you type, say '1', it goes to the default case (because '1' != 1)?

print main_menu_choice, it might contain a value you dont expect.
and the break after the goto is not needed

Quote:

---

Originally Posted by him61

break statements dont help, I've been trying for hours. it compiles, but it does not work.
About goto:
I know very well that goto is evil, but it's the only statement that I know that jumps to a specific section of the program, which is what I need for this.

---

No no no!
If you continue to think like that you'll never be anything but a glorified assembly language programmer.
Get rid of those gotos and use structured programming. If you don't understand structured program then take the time to learn. One look at that code and any prospective employer will be screaming 'Next!'.

why using goto :(

Sorry for my n00bishness guys... I just haven't learned anything major yet in my c++ class, just a few basic structures, and the teacher told me to make an RPG game for a final project.
I experimented with char to begin with, and I discovered that I left it in on accident... Thanks again!
Again, I know that Goto is evil, and I will try to learn functions and use them before my class ends so that I can use it in here.

And again, many thanks! :D