Check for EOF when using fgets

hey.

Code:

---

#include <stdio.h>

FILE *fp;

int main (void)
{
  int x;
  char filename[80], buf[200];

  puts("Enter file to review");
  scanf("%s", filename);

  if ((fp = fopen(filename, "r")) == NULL)
  {
    puts("Error1");
    return(-1);
  }

  while(1)
  {
    if (fgets(buf, 200, fp) == NULL)
    {
      puts("Error2 or EOF");
      return(-1);
    }
  printf("%s", buf);
  }
 
  return 0;
}

---

anyone who can tell me about a way of checking for EOF within this while loop. I can't think of a good sollution. I would like to print an error if something else than EOF is found by fgets.

dagH

Something more like this:

Code:

---

while(fgets(buf, 200, fp) != NULL)
{
      printf("%s",buf);
}

/* fgets() returned NULL.  Now you can check why.... */

if(feof(fp)
{
      /* EOF */
}
else if(ferror(fp))
{
      /* Errror */
}
...

---

Hey.
That was what I was looking for. I haven't used ferror before so...
But is there a way to do the same thing without ferror?

hmm... but why do you want to avoid ferror()?

well for the simple reason that I thought I had seen an example not using ferror() and was just wondering if there was something I was missing... :)

In this example that I posted, ferror() just checks if there was an error that caused the fgets() to fail. If you're doing error checking, why wouldn't you want to use it?

It's not that hard to use. You just pass it a file pointer, and it returns non-zero if the file stream is in an error state. http://cppreference.com/stdio/ferror.html

Then you can call perror() to print what the actual error was. Just pass perror() a string to print before the error. http://cppreference.com/stdio/perror.html

They're both ANSI standard functions. There's nothing wrong with using them unless you have a specific reason not to.