Delete Files Older than 2 years

I'm writing this to delete PDF files that are older than two years. I have it right now so that it deletes all PDFs. It runs, but when the program finishes I get a segmentation fault. How do I fix this? Then how to I subtract 2 years from my variables st or ft?

Code:

---

#include <iostream>
#include <windows.h>
/*
    Deletes all PDF files older than 2 years
*/
using namespace std;

int main()
{   
    char delme[]="";
    int ErrorCode;
    SYSTEMTIME st;
    FILETIME ft;
    LARGE_INTEGER mine, file;
    HANDLE hFind;
    WIN32_FIND_DATA FindData;
   
    GetSystemTime(&st);
    SystemTimeToFileTime(&st, &ft);
    mine.LowPart=ft.dwLowDateTime;
    mine.HighPart=ft.dwHighDateTime;

    hFind=FindFirstFile("S:\\*.pdf", &FindData);
   
    if(hFind==INVALID_HANDLE_VALUE)
    {
        FindClose(hFind);
        return 0;
    }

    file.LowPart=FindData.ftCreationTime.dwLowDateTime;
    file.HighPart=FindData.ftCreationTime.dwHighDateTime;
    if(mine.QuadPart>file.QuadPart){
        strcat(delme,"del S:\\");
        strcat(delme,FindData.cFileName);
        system(delme);
    }
   
    while(FindNextFile(hFind, &FindData))
    {
        ErrorCode=GetLastError();
        if(ErrorCode==ERROR_NO_MORE_FILES)
            return 0;
        file.LowPart=FindData.ftCreationTime.dwLowDateTime;
        file.HighPart=FindData.ftCreationTime.dwHighDateTime;
        if(mine.QuadPart>file.QuadPart){
          strcat(delme,"del S:\\");
            strcat(delme,FindData.cFileName);
            system(delme);
        }
    }
   
    FindClose(hFind);
    return 0;
}

---

Quote:

---

Code:

---

strcat(delme,"del S:\\");

---

---

This corrupts your stack. When main() wants to return, it jumps into limbo.

Use std::string.

Also, don't use system(). Use remove()/unlink() or the appropriate API call - DeleteFile, I think.

With a decent shell, it's just one line

Code:

---

find . -name "*.pdf" -mtime +730 -exec rm {} \;

---

Don't you have to escape the braces too, in bash?

Thanks CornedBee! That worked. And althought I'd love to do it in bash it's going to run on a Windows server.

Can't you load cygwin or MinGW MSYS onto it?

Quote:

---

Originally Posted by Salem

With a decent shell, it's just one line

Code:

---

find . -name "*.pdf" -mtime +730 -exec rm {} \;

---

---

Code:

---

find . -iname "*.pdf" -mtime +730 -type f  -print0 | xargs -0 rm -f

---

exec is slower than xargs, since it forks a process for every single matching file.
iname is case-insensitive, thus matching *.PDF etc as well.
Besides that, find has a -delete action.

CornedBee:
You don't have to, but you should wrap the {} with single-quotes to ensure
that they're not interpreted as belonging to a shell script.

pjeremy, does your method work for spaces in the file name?

Yes, it may contain single/double quotes, spaces and newlines because of -print0 and -0.

So -print0 makes them separated by NUL, and -0 makes xargs split on the NUL?

Yes.