doubly linked lists insertion

Hey guys please correct me if im wrong but does all the code inside the if(*head ==NULL) its just initialize each to a safe state then creating a head node in our list.

Then if the head node is already created create prev and next pointers then create a new node with prev and next pointers to that as well.

Code:

---

void insertNode( struct node **head, int data)
{
    struct node *tempnode, *tempnode1;
   
    if( *head == NULL )
    {
        *head = createnode();
        (*head)->next = NULL;
        (*head)->prev = NULL;
        (*head)->data = data;
    }
    else
    {
        tempnode = *head;
       
        while( empnode->next != NULL )
            tempnode = tempnode->next;
       
        tempnode1 = createnode();
        tempnode1->prev = tempnode;
        tempnode1->next = NULL;
        tempnode1->data = data;
       
        tempnode->next = tempnode1;
    }
}

---

Yep, but unless you have a special reason you need to append nodes on the tail of the list, you could save yourself some trouble and just prepend them.

Code:

---

if( *head )
{
    temp = createnode( );
    if( temp )
    {
        temp->prev = NULL;
        temp->next = *head;
        temp->data = data;
        (*head)->prev = temp;
        *head = temp;
    }
}

---

It's not like you're sorting as you insert anyway, so why not take the easy way out?


Quzah.

Quote:

---

Then if the head node is already created create prev and next pointers then create a new node with prev and next pointers to that as well.

---

you check for head == null becuase to see is there any list already created. If there was no list created i traverse down to the end and add a new node. Or u could create a new node and add then in the front and the puch the list to grow toward to your right.

To be honest with you the if part will normally be excuted only once in the executing of the code. Its the else past which inserts the node.

ssharish2005

Looks okay. If the list is empty, you add a node at the front. If the list isn't empty, you add a node ad the end. I don't think createnode() is good though because it doesn't return an error status or you don't check for it. That leaves you with ignoring the error of not being able to create a node, or just closing the program. Both are bad. I'd write it something like this:

Code:

---

struct node *createnode( int data, struct node *prev, struct node *next ) {
  struct node *new = malloc( sizeof *new );

  if ( new ) {
    new->data = data;
    new->prev = prev;
    new->next = next;
  }

  return new;
}

---

Then you can use it like this:

Code:

---

int insertNode( struct node **head, int data)
{
    struct node *tempnode, *tempnode1;
   
    if( *head == NULL )
    {
        *head = createnode( data, NULL, NULL );

        if ( *head == NULL ) {
          return 0;
        }
    }
    else
    {
        tempnode = *head;
       
        while( empnode->next != NULL )
            tempnode = tempnode->next;
       
        tempnode1 = createnode( data, tempnode, NULL );

        if ( tempnode1 == NULL ) {
          return 0;
        }
       
        tempnode->next = tempnode1;
    }

    return 1;
}

---

okk and the tail is bascially the end of the list?

Yeah.

Thnks