Doubly Linked List Node

Hey i'm trying to create a header file for a doubly linked list node. So far i have

Code:

---

#ifndef DLLISTNODE_H
#define DLLISTNODE_H
#include <iostream>

using namespace std;

template <class T>
class DLListNode
{
    public:
                DLListNode();
                DLListNode(const T&)
                DLListNode(const T&, DLListNode<T>*
                ~DLListNode();
                void set(data, nextPtr, prevPtr)
                void retrieve(data)

    private:
                T data;
                DLListNode<T>* nextPtr;
                DLListNode<T>*prevPtr;
};
#include "DLListNode.template"
#endif

---

can someone let me know if any of this is right. The Set funtion is supposed to set the private data members, the retreive is supposed to retreive the private data members. And I need a constructor that allows a node to be immediately linked into a list. I have them in there just not sure if they are right.

Code:

---

DLListNode(const T&)
DLListNode(const T&, DLListNode<T>*

---

Looks like two typographical errors (missing terminating semi-colon and the the second constructor prototype I listed looks half finished). It would be good to give a name to the parameters to as to hint at what they are intended for.

Code:

---

void set(data, nextPtr, prevPtr)
void retrieve(data)

---

More typographical errors (missing terminating semi-colon), and more importantly, it looks like you are now providing names to the parameters, but forgot about the types.

Incidentally, remove the "using namespace std;" from your header file. Use fully qualified names in header files.

I've never not used namespace std in my header before. do i need the iostream there? and does everything else look right and do what i said in the previous one needed to do?

Code:

---

#ifndef DLLISTNODE_H
#define DLLISTNODE_H
#include <iostream>

using namespace std;

template <class T>
class DLListNode
{
    public:
                DLListNode();
                DLListNode(const T&)
                DLListNode(const T&, DLListNode<T>*);
                ~DLListNode();
                void set(T data, DLListNode<T>* nextPtr, DLListNode<T>* prevPtr);
                void retrieve(T data);

    private:
                T data;
                DLListNode<T>* nextPtr;
                DLListNode<T>*prevPtr;
};
#include "DLListNode.template"
#endif

---

Tell me, what here requires either <iostream> or using namespace std;?

Code:

---

template <class T>
class DLListNode
{
    public:
                DLListNode();
                DLListNode(const T&)
                DLListNode(const T&, DLListNode<T>*);
                ~DLListNode();
                void set(T data, DLListNode<T>* nextPtr, DLListNode<T>* prevPtr);
                void retrieve(T data);

    private:
                T data;
                DLListNode<T>* nextPtr;
                DLListNode<T>*prevPtr;
};

---

If your answer is "nothing", then the question is why?

Only to present extraneous problems to some code that includes it? Doesn't that sound like a reason to ditch it?

ok but everything else is correct? likes is the T data const T& data? or wat it is now?

Surely your compiler tells you no.

Code:

---

                DLListNode();
                DLListNode(const T&)

---

besides that

You should try and compile your code before asking questions on whether your code is correct.

this is not compiled, i'm answering it from a review book written on paper thats y i am asking, normally i would just compile and see

Quote:

---

this is not compiled, i'm answering it from a review book written on paper thats y i am asking, normally i would just compile and see

---

Type it into your editor, then compile and try it out. Alternatively, look at the answers provided by the book. If there are no answers, then the author probably expected you to confirm your answers by trying it out anyway.

hm ok in that case can u help me get mingw working i still can't get it to work

how would i compile just that one file anyway if i don't have a filled out DLListNode.template file?

Yes, but you should post about your MinGW installation problems. The Tech Board is a good place for that, unless you are just having problems compiling your program, in which case post in this forum with the code that you are trying to compile.

Quote:

---

how would i compile just that one file anyway if i don't have a filled out DLListNode.template file?

---

Create it yourself, with stubs for the implementation of your class template. Then you need another source file with the main() function used to test out your class template.

Quote:

---

Originally Posted by DarkDot

hm ok in that case can u help me get mingw working i still can't get it to work

---

Well, one might recommend posting the actual code, rather that just a snippet that you can't debug.

this is the whole code that i have. i meant just mingw in general working to compile in windows. Also i posted in the tech area

Quote:

---

Originally Posted by DarkDot

this is the whole code that i have. i meant just mingw in general working to compile in windows.

---

That isn't a complete code, which might be why any compiler would have issues. You don't compile headers, you compile source code.

there is no possible way you could just tell me if u see something wrong? i mean its just a review question i don't want to go through all that trobule when on the test i'm not going to be able to test it.

You showed part of a header. No code. What kind of help do you want?

all i need is to create the header. is that not the whole header?

Quote:

---

there is no possible way you could just tell me if u see something wrong?

---

So far what is wrong are just typographical errors. If the intention of this review question is to see if you can spot them, then clearly you have not, and need more practice. Asking us to help you spot them is a waste of our time, since it would just be feeding you the answers.

Quote:

---

Originally Posted by DarkDot

all i need is to create the header.

---

Well, you've done just that.

ok and again it all looks right to you? its not typographical errors, it actual coding syntax stuff. i saw that stuff and its stupid and i should have corrected it for being totally syntactically correct.

For what?

[edit]Problems without solutions are easier than solutions without problems.

what do u mean for what?

true....

Quote:

---

Originally Posted by DarkDot

The Set funtion is supposed to set the private data members, the retreive is supposed to retreive the private data members. And I need a constructor that allows a node to be immediately linked into a list.

---

From all of your efforts this seems tantamount to me saying this:

Code:

---

void SendMeAMillionDollars(void);

---

Hmm. Where's my money?

haha sure if u give me a straight answer :)

You have presented no source code to compile. So without a question, what are we supposed to answer?

source code...now i'm going to sound stupid...are u referring to the implementation file, in this case it would be the DLListNode.template? because the problem just said to create a header file and i didn't think that file was part of the header. otherwise if the header looks ok then i'm good to go.

Didn't I say that already?

But whether it's correct or not in part depends on the implementation.



Why does the set function need to know about prev and next?
Why does the retrieve function not return anything or take a modifiable argument?