Reading from a file using fstream.

Hi guys.

Can you please tell me why this code prints garbage and loops forever.

Code:

---

#include <iostream>
#include <fstream>

using namespace std;

int main (int agrc, char* argv[])
{
        fstream file;
        fstream output;
       
        wchar_t *c1;

        if (argv[1] == NULL)
        {
                cout << "Usage: Profiler <file-name.c>" << endl;
                exit (1);
        }
       
        file.open ("c:\258_assignment2\Profiling\ff.c", ios::in);
        output.open ("output", ios::out);

       
        while (!file.eof() )
        {
                char c;
                c = file.get();
                cout << c << endl;
                output << c << endl;
        }

        return 0;
}

---

I also have two questions:
1- how can i check if the file opened successfully?
2- i need to pass the argv[1] to open as filename, but i get an error about wchar_t type. I ca't seems to pass char*. How can i solve this?

Thanks!

Quote:

---

Can you please tell me why this code prints garbage and loops forever.

---

Not sure why it loops forever, but
1. You need to escape the backslashes in your input filename.
2. You should not control the loop with !file.eof()
You could consider file.good(), or just loop with while (file.get(c))

Quote:

---

1- how can i check if the file opened successfully?

---

Checking for file.good() is one way.

Quote:

---

2- i need to pass the argv[1] to open as filename, but i get an error about wchar_t type. I ca't seems to pass char*. How can i solve this?

---

It should take a char*, so I am not sure what is the problem.

Alright, thank you.
It seems i was trying without the escaping, and i was also trying just ff.c, thinking it should work since they're in the same forlder.