10 thousands dollars question about file

Hi,
If anyone can answer to that, he will deserve my most sincere admiration. In this code (french by the way, but I translated the printf content) , there is a problem with the output (related to the end of file). This program read names in a .txt file, ask you to modify one and then, he create a new .txt with the modified name. The problem is that the last name come two time
ex:

name.txt
John
Gill

modify John for Toto

the the output file is
newname.txt
Toto
Gill
Gill

why 2 Gill, and how can you fix that?
if you can solve this, you will beat a teacher I know that can't solve it.

Code:

---

#include <stdio.h>
#include <string.h>
#include <myconio.h>

void OuvrirFichier(char szNomPhys[40], FILE * * ref_fich, char szTypeAcces[3]);

int main(void)
{
  char szAncien[30], szNouveau[30];
  FILE *fEntree, *fSortie;
  char szNom[30], szNomModif[30], szNomNouveau[30];

  printf("Name of the old file (.txt) : ");
  scanf("&#37;s", szAncien);
  OuvrirFichier(szAncien,&fEntree,"r");

  printf("Name of the new file : ");
  scanf("%s", szNouveau);
  OuvrirFichier(szNouveau,&fSortie,"w");

  printf("name to modify : ");
  scanf("%s",szNomModif);

  printf("new name : ");
  scanf("%s",szNomNouveau);

  while (!feof(fEntree))
  {
      fscanf(fEntree, "%s", szNom);
      if (strcmp(szNom, szNomModif) == 0)
        fprintf(fSortie, "%s\n", szNomNouveau);
      else
        fprintf(fSortie, "%s\n", szNom);
  }

  fclose(fSortie);
  fclose(fEntree);
}


void OuvrirFichier(char szNomPhys[40], FILE * * ref_fich, char szTypeAcces[3])
{
    if (( *ref_fich = fopen(szNomPhys,szTypeAcces)) == NULL)
    {
      printf("Erreur: %s",szNomPhys);
      exit(1);
    }
}

---

thanks

It's like this... your reading in and writing out "Gill" once... your loop condition isn't meeting, you're next read is failing leaving Gill in your szNom buffer which is then getting printed to the file, again. There are several ways you can avoid this and I imagine you're up to the challenge of figuring it out on your own.

Here is your problem:

Code:

---

while (!feof(fEntree))

---

See this FAQ for why not to do that: http://faq.cprogramming.com/cgi-bin/...&id=1043284351

What happens is that your program works perfectly until it comes to the last line. Then the fscanf() discovers this and returns an error code (which you ignore). It leaves the string untouched. Then you process the string as normal, and only afterwards do you discover (with feof()) that the end of the file was reached.

There are several ways to fix this. The best in my opinion is to check the return value of scanf():

Code:

---

while(fscanf(fEntree, "%s", szNom) == 1)) {
    /* ... */
}

---

(*scanf() returns the number of items successfully read. Since you passed it one item, %s, it will return 1 on success. It could return 0 or EOF on failure.)

Where do schools get these teachers? And nevrax, you keep asking questions that are addressed in the FAQ. It's there for a reason, buddy.

Seriously, I didn't though that this one would be in a faq, it's an "experienced teacher" in C that didn't found the mistake, I wouldn't have given such a title if I knew it was such a little problem. Well, guess we don't have the teacher we once had...or the problem is that these teacher learned Cobol, Fortrean and Dbase and they never updated. And for the faqs, I kind of have some difficulty reading them ( English is not my primary language), I don't even know if what I write is good. The only way for me is to ask, or read French faqs...but they suck most of the time.