Menu like file, edit, help, etc...

Hi, i'm building a Program like Notepad or something. I just can't get it work. Everything works except the menu, can you fixa the menu thing?

Here is everything you need:
http://www.livijnproductions.se/Jinky.rar
The menu is in the .rc and the rest of the code is in the .o and .h

It's not a big file so you maybe should figure out whats wrong and tell me! :D

Thank you!


CODES

main.c

Code:

---

#include <windows.h>
#include <commctrl.h>
#include "resource.h"


const char g_szClassName[] = "myWindowClass";
const char g_szChildClassName[] = "myMDIChildWindowClass";

#define IDC_MAIN_MDI        101
#define IDC_MAIN_TOOL        102
#define IDC_MAIN_STATUS        103
#define IDC_CHILD_EDIT        101
#define ID_MDI_FIRSTCHILD 50000

HWND g_hMDIClient = NULL;
HWND g_hMainWindow = NULL;

BOOL LoadTextFileToEdit(HWND hEdit, LPCTSTR pszFileName)
{
        HANDLE hFile;
        BOOL bSuccess = FALSE;

        hFile = CreateFile(pszFileName, GENERIC_READ, FILE_SHARE_READ, NULL,
                OPEN_EXISTING, 0, NULL);
        if(hFile != INVALID_HANDLE_VALUE)
        {
                DWORD dwFileSize;

                dwFileSize = GetFileSize(hFile, NULL);
                if(dwFileSize != 0xFFFFFFFF)
                {
                        LPSTR pszFileText;

                        pszFileText = GlobalAlloc(GPTR, dwFileSize + 1);
                        if(pszFileText != NULL)
                        {
                                DWORD dwRead;

                                if(ReadFile(hFile, pszFileText, dwFileSize, &dwRead, NULL))
                                {
                                        pszFileText[dwFileSize] = 0; // Add null terminator
                                        if(SetWindowText(hEdit, pszFileText))
                                                bSuccess = TRUE; // It worked!
                                }
                                GlobalFree(pszFileText);
                        }
                }
                CloseHandle(hFile);
        }
        return bSuccess;
}

BOOL SaveTextFileFromEdit(HWND hEdit, LPCTSTR pszFileName)
{
        HANDLE hFile;
        BOOL bSuccess = FALSE;

        hFile = CreateFile(pszFileName, GENERIC_WRITE, 0, NULL,
                CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
        if(hFile != INVALID_HANDLE_VALUE)
        {
                DWORD dwTextLength;

                dwTextLength = GetWindowTextLength(hEdit);
                // No need to bother if there's no text.
                if(dwTextLength > 0)
                {
                        LPSTR pszText;
                        DWORD dwBufferSize = dwTextLength + 1;

                        pszText = GlobalAlloc(GPTR, dwBufferSize);
                        if(pszText != NULL)
                        {
                                if(GetWindowText(hEdit, pszText, dwBufferSize))
                                {
                                        DWORD dwWritten;

                                        if(WriteFile(hFile, pszText, dwTextLength, &dwWritten, NULL))
                                                bSuccess = TRUE;
                                }
                                GlobalFree(pszText);
                        }
                }
                CloseHandle(hFile);
        }
        return bSuccess;
}

void DoFileOpen(HWND hwnd)
{
        OPENFILENAME ofn;
        char szFileName[MAX_PATH] = "";

        ZeroMemory(&ofn, sizeof(ofn));

        ofn.lStructSize = sizeof(ofn);
        ofn.hwndOwner = hwnd;
        ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0";
        ofn.lpstrFile = szFileName;
        ofn.nMaxFile = MAX_PATH;
        ofn.Flags = OFN_EXPLORER | OFN_FILEMUSTEXIST | OFN_HIDEREADONLY;
        ofn.lpstrDefExt = "txt";

        if(GetOpenFileName(&ofn))
        {
                HWND hEdit = GetDlgItem(hwnd, IDC_CHILD_EDIT);
                if(LoadTextFileToEdit(hEdit, szFileName))
                {
                        SendDlgItemMessage(g_hMainWindow, IDC_MAIN_STATUS, SB_SETTEXT, 0, (LPARAM)"Opened...");
                        SendDlgItemMessage(g_hMainWindow, IDC_MAIN_STATUS, SB_SETTEXT, 1, (LPARAM)szFileName);

                        SetWindowText(hwnd, szFileName);
                }
        }
}

void DoFileSave(HWND hwnd)
{
        OPENFILENAME ofn;
        char szFileName[MAX_PATH] = "";

        ZeroMemory(&ofn, sizeof(ofn));

        ofn.lStructSize = sizeof(ofn);
        ofn.hwndOwner = hwnd;
        ofn.lpstrFilter = "Text Files (*.txt)\0*.txt\0All Files (*.*)\0*.*\0";
        ofn.lpstrFile = szFileName;
        ofn.nMaxFile = MAX_PATH;
        ofn.lpstrDefExt = "txt";
        ofn.Flags = OFN_EXPLORER | OFN_PATHMUSTEXIST | OFN_HIDEREADONLY | OFN_OVERWRITEPROMPT;

        if(GetSaveFileName(&ofn))
        {
                HWND hEdit = GetDlgItem(hwnd, IDC_CHILD_EDIT);
                if(SaveTextFileFromEdit(hEdit, szFileName))
                {
                        SendDlgItemMessage(g_hMainWindow, IDC_MAIN_STATUS, SB_SETTEXT, 0, (LPARAM)"Saved...");
                        SendDlgItemMessage(g_hMainWindow, IDC_MAIN_STATUS, SB_SETTEXT, 1, (LPARAM)szFileName);

                        SetWindowText(hwnd, szFileName);
                }
        }
}

HWND CreateNewMDIChild(HWND hMDIClient)
{
        MDICREATESTRUCT mcs;
        HWND hChild;

        mcs.szTitle = "[Untitled document]";
        mcs.szClass = g_szChildClassName;
        mcs.hOwner  = GetModuleHandle(NULL);
        mcs.x = mcs.cx = CW_USEDEFAULT;
        mcs.y = mcs.cy = CW_USEDEFAULT;
        mcs.style = MDIS_ALLCHILDSTYLES;

        hChild = (HWND)SendMessage(hMDIClient, WM_MDICREATE, 0, (LONG)&mcs);
        if(!hChild)
        {
                MessageBox(hMDIClient, "MDI Child creation failed.", "Oh Oh...",
                        MB_ICONEXCLAMATION | MB_OK);
        }
        return hChild;
}

LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
        switch(msg)
        {
                case WM_CREATE:
                {
                        HWND hTool;
                        TBBUTTON tbb[3];
                        TBADDBITMAP tbab;

                        HWND hStatus;
                        int statwidths[] = {100, -1};

                        CLIENTCREATESTRUCT ccs;

                        // Create MDI Client

                        // Find window menu where children will be listed
                        ccs.hWindowMenu  = GetSubMenu(GetMenu(hwnd), 2);
                        ccs.idFirstChild = ID_MDI_FIRSTCHILD;

                        g_hMDIClient = CreateWindowEx(WS_EX_CLIENTEDGE, "mdiclient", NULL,
                                WS_CHILD | WS_CLIPCHILDREN | WS_VSCROLL | WS_HSCROLL | WS_VISIBLE,
                                CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT,
                                hwnd, (HMENU)IDC_MAIN_MDI, GetModuleHandle(NULL), (LPVOID)&ccs);

                        if(g_hMDIClient == NULL)
                                MessageBox(hwnd, "Could not create MDI client.", "Error", MB_OK | MB_ICONERROR);

                        // Create Toolbar

                        hTool = CreateWindowEx(0, TOOLBARCLASSNAME, NULL, WS_CHILD | WS_VISIBLE, 0, 0, 0, 0,
                                hwnd, (HMENU)IDC_MAIN_TOOL, GetModuleHandle(NULL), NULL);
                        if(hTool == NULL)
                                MessageBox(hwnd, "Could not create tool bar.", "Error", MB_OK | MB_ICONERROR);

                        // Send the TB_BUTTONSTRUCTSIZE message, which is required for
                        // backward compatibility.
                        SendMessage(hTool, TB_BUTTONSTRUCTSIZE, (WPARAM)sizeof(TBBUTTON), 0);
                       
                        tbab.hInst = HINST_COMMCTRL;
                        tbab.nID = IDB_STD_SMALL_COLOR;
                        SendMessage(hTool, TB_ADDBITMAP, 0, (LPARAM)&tbab);

                        ZeroMemory(tbb, sizeof(tbb));
                        tbb[0].iBitmap = STD_FILENEW;
                        tbb[0].fsState = TBSTATE_ENABLED;
                        tbb[0].fsStyle = TBSTYLE_BUTTON;
                        tbb[0].idCommand = ID_FILE_NEW;

                        tbb[1].iBitmap = STD_FILEOPEN;
                        tbb[1].fsState = TBSTATE_ENABLED;
                        tbb[1].fsStyle = TBSTYLE_BUTTON;
                        tbb[1].idCommand = ID_FILE_OPEN;

                        tbb[2].iBitmap = STD_FILESAVE;
                        tbb[2].fsState = TBSTATE_ENABLED;
                        tbb[2].fsStyle = TBSTYLE_BUTTON;
                        tbb[2].idCommand = ID_FILE_SAVEAS;

                        SendMessage(hTool, TB_ADDBUTTONS, sizeof(tbb)/sizeof(TBBUTTON), (LPARAM)&tbb);

                        // Create Status bar

                        hStatus = CreateWindowEx(0, STATUSCLASSNAME, NULL,
                                WS_CHILD | WS_VISIBLE | SBARS_SIZEGRIP, 0, 0, 0, 0,
                                hwnd, (HMENU)IDC_MAIN_STATUS, GetModuleHandle(NULL), NULL);

                        SendMessage(hStatus, SB_SETPARTS, sizeof(statwidths)/sizeof(int), (LPARAM)statwidths);
                        SendMessage(hStatus, SB_SETTEXT, 0, (LPARAM)"Jinky");
                }
                break;
                case WM_SIZE:
                {
                        HWND hTool;
                        RECT rcTool;
                        int iToolHeight;

                        HWND hStatus;
                        RECT rcStatus;
                        int iStatusHeight;

                        HWND hMDI;
                        int iMDIHeight;
                        RECT rcClient;

                        // Size toolbar and get height

                        hTool = GetDlgItem(hwnd, IDC_MAIN_TOOL);
                        SendMessage(hTool, TB_AUTOSIZE, 0, 0);

                        GetWindowRect(hTool, &rcTool);
                        iToolHeight = rcTool.bottom - rcTool.top;

                        // Size status bar and get height

                        hStatus = GetDlgItem(hwnd, IDC_MAIN_STATUS);
                        SendMessage(hStatus, WM_SIZE, 0, 0);

                        GetWindowRect(hStatus, &rcStatus);
                        iStatusHeight = rcStatus.bottom - rcStatus.top;

                        // Calculate remaining height and size edit

                        GetClientRect(hwnd, &rcClient);

                        iMDIHeight = rcClient.bottom - iToolHeight - iStatusHeight;

                        hMDI = GetDlgItem(hwnd, IDC_MAIN_MDI);
                        SetWindowPos(hMDI, NULL, 0, iToolHeight, rcClient.right, iMDIHeight, SWP_NOZORDER);
                }
                break;
                case WM_CLOSE:
                        DestroyWindow(hwnd);
                break;
                case WM_DESTROY:
                        PostQuitMessage(0);
                break;
                case WM_COMMAND:
                        switch(LOWORD(wParam))
                        {
                                case ID_FILE_EXIT:
                                        PostMessage(hwnd, WM_CLOSE, 0, 0);
                                break;
                                case ID_FILE_NEW:
                                        CreateNewMDIChild(g_hMDIClient);
                                break;
                                case ID_FILE_OPEN:
                                {
                                        HWND hChild = CreateNewMDIChild(g_hMDIClient);
                                        if(hChild)
                                        {
                                                DoFileOpen(hChild);       
                                        }
                                }
                                break;
                                case ID_FILE_CLOSE:
                                {
                                        HWND hChild = (HWND)SendMessage(g_hMDIClient, WM_MDIGETACTIVE,0,0);
                                        if(hChild)
                                        {
                                                SendMessage(hChild, WM_CLOSE, 0, 0);
                                        }
                                }
                                break;
                                case ID_WINDOW_TILE:
                                        SendMessage(g_hMDIClient, WM_MDITILE, 0, 0);
                                break;
                                case ID_WINDOW_CASCADE:
                                        SendMessage(g_hMDIClient, WM_MDICASCADE, 0, 0);
                                break;
                                default:
                                {
                                        if(LOWORD(wParam) >= ID_MDI_FIRSTCHILD)
                                        {
                                                DefFrameProc(hwnd, g_hMDIClient, WM_COMMAND, wParam, lParam);
                                        }
                                        else
                                        {
                                                HWND hChild = (HWND)SendMessage(g_hMDIClient, WM_MDIGETACTIVE,0,0);
                                                if(hChild)
                                                {
                                                        SendMessage(hChild, WM_COMMAND, wParam, lParam);
                                                }
                                        }
                                }
                        }
                break;
                default:
                        return DefFrameProc(hwnd, g_hMDIClient, msg, wParam, lParam);
        }
        return 0;
}

LRESULT CALLBACK MDIChildWndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)
{
        switch(msg)
        {
                case WM_CREATE:
                {
                        HFONT hfDefault;
                        HWND hEdit;

                        // Create Edit Control

                        hEdit = CreateWindowEx(WS_EX_CLIENTEDGE, "EDIT", "",
                                WS_CHILD | WS_VISIBLE | WS_VSCROLL | WS_HSCROLL | ES_MULTILINE | ES_AUTOVSCROLL | ES_AUTOHSCROLL,
                                0, 0, 100, 100, hwnd, (HMENU)IDC_CHILD_EDIT, GetModuleHandle(NULL), NULL);
                        if(hEdit == NULL)
                                MessageBox(hwnd, "Could not create edit box.", "Error", MB_OK | MB_ICONERROR);

                        hfDefault = GetStockObject(DEFAULT_GUI_FONT);
                        SendMessage(hEdit, WM_SETFONT, (WPARAM)hfDefault, MAKELPARAM(FALSE, 0));
                }
                break;
                case WM_MDIACTIVATE:
                {
                        HMENU hMenu, hFileMenu;
                        UINT EnableFlag;

                        hMenu = GetMenu(g_hMainWindow);
                        if(hwnd == (HWND)lParam)
                        {          //being activated, enable the menus
                                EnableFlag = MF_ENABLED;
                        }
                        else
                        {                                                  //being de-activated, gray the menus
                                EnableFlag = MF_GRAYED;
                        }

                        EnableMenuItem(hMenu, 1, MF_BYPOSITION | EnableFlag);
                        EnableMenuItem(hMenu, 2, MF_BYPOSITION | EnableFlag);

                        hFileMenu = GetSubMenu(hMenu, 0);
                        EnableMenuItem(hFileMenu, ID_FILE_SAVEAS, MF_BYCOMMAND | EnableFlag);

                        EnableMenuItem(hFileMenu, ID_FILE_CLOSE, MF_BYCOMMAND | EnableFlag);
                        EnableMenuItem(hFileMenu, ID_FILE_CLOSEALL, MF_BYCOMMAND | EnableFlag);

                        DrawMenuBar(g_hMainWindow);
                }
                break;
                case WM_COMMAND:
                        switch(LOWORD(wParam))
                        {
                                case ID_FILE_OPEN:
                                        DoFileOpen(hwnd);
                                break;
                                case ID_FILE_SAVEAS:
                                        DoFileSave(hwnd);
                                break;
                                case ID_EDIT_CUT:
                                        SendDlgItemMessage(hwnd, IDC_CHILD_EDIT, WM_CUT, 0, 0);
                                break;
                                case ID_EDIT_COPY:
                                        SendDlgItemMessage(hwnd, IDC_CHILD_EDIT, WM_COPY, 0, 0);
                                break;
                                case ID_EDIT_PASTE:
                                        SendDlgItemMessage(hwnd, IDC_CHILD_EDIT, WM_PASTE, 0, 0);
                                break;
                        }
                break;
                case WM_SIZE:
                {
                        HWND hEdit;
                        RECT rcClient;

                        // Calculate remaining height and size edit

                        GetClientRect(hwnd, &rcClient);

                        hEdit = GetDlgItem(hwnd, IDC_CHILD_EDIT);
                        SetWindowPos(hEdit, NULL, 0, 0, rcClient.right, rcClient.bottom, SWP_NOZORDER);
                }
                return DefMDIChildProc(hwnd, msg, wParam, lParam);
                default:
                        return DefMDIChildProc(hwnd, msg, wParam, lParam);
       
        }
        return 0;
}

BOOL SetUpMDIChildWindowClass(HINSTANCE hInstance)
{
        WNDCLASSEX wc;

        wc.cbSize                = sizeof(WNDCLASSEX);
        wc.style                = CS_HREDRAW | CS_VREDRAW;
        wc.lpfnWndProc        = MDIChildWndProc;
        wc.cbClsExtra        = 0;
        wc.cbWndExtra        = 0;
        wc.hInstance        = hInstance;
        wc.hIcon                = LoadIcon(NULL, IDI_APPLICATION);
        wc.hCursor                = LoadCursor(NULL, IDC_ARROW);
        wc.hbrBackground = (HBRUSH)(COLOR_3DFACE+1);
        wc.lpszMenuName  = NULL;
        wc.lpszClassName = g_szChildClassName;
        wc.hIconSm                = LoadIcon(NULL, IDI_APPLICATION);

        if(!RegisterClassEx(&wc))
        {
                MessageBox(0, "Could Not Register Child Window", "Oh Oh...",
                        MB_ICONEXCLAMATION | MB_OK);
                return FALSE;
        }
        else
                return TRUE;
}


int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance,
        LPSTR lpCmdLine, int nCmdShow)
{
    InitCommonControls();
   
        WNDCLASSEX wc;
        HWND hwnd;
        MSG Msg;

       

        wc.cbSize                = sizeof(WNDCLASSEX);
        wc.style                = 0;
        wc.lpfnWndProc        = WndProc;
        wc.cbClsExtra        = 0;
        wc.cbWndExtra        = 0;
        wc.hInstance        = hInstance;
        wc.hIcon                = LoadIcon(NULL, IDI_APPLICATION);
        wc.hCursor                = LoadCursor(NULL, IDC_ARROW);
        wc.hbrBackground = (HBRUSH)(COLOR_WINDOW+1);
        wc.lpszMenuName  = MAKEINTRESOURCE(IDR_MAINMENU);
        wc.lpszClassName = g_szClassName;
        wc.hIconSm                = LoadIcon(NULL, IDI_APPLICATION);

        if(!RegisterClassEx(&wc))
        {
                MessageBox(NULL, "Window Registration Failed!", "Error!",
                        MB_ICONEXCLAMATION | MB_OK);
                return 0;
        }

        if(!SetUpMDIChildWindowClass(hInstance))
                return 0;

        hwnd = CreateWindowEx(
                0,
                g_szClassName,
                "Jinky - Livijnproductions.se",
                WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN,
                CW_USEDEFAULT, CW_USEDEFAULT, 480, 320,
                NULL, NULL, hInstance, NULL);

        if(hwnd == NULL)
        {
                MessageBox(NULL, "Window Creation Failed!", "Error!",
                        MB_ICONEXCLAMATION | MB_OK);
                return 0;
        }

        g_hMainWindow = hwnd;

        ShowWindow(hwnd, nCmdShow);
        UpdateWindow(hwnd);

        while(GetMessage(&Msg, NULL, 0, 0) > 0)
        {
                if (!TranslateMDISysAccel(g_hMDIClient, &Msg))
                {
                        TranslateMessage(&Msg);
                        DispatchMessage(&Msg);
                }
        }
        return Msg.wParam;
}

---

resource.h

Code:

---

//{{NO_DEPENDENCIES}}
// Microsoft Developer Studio generated include file.
// Used by app_four.rc
//
#define IDR_MAINMENU                    102
#define ID_FILE_EXIT                    40001
#define ID_FILE_NEW                    40002
#define ID_FILE_OPEN                    40003
#define ID_FILE_SAVEAS                  40005
#define ID_WINDOW_CASCADE              40008
#define ID_WINDOW_TILE                  40009
#define ID_FILE_CLOSE                  40010
#define ID_FILE_CLOSEALL                40011
#define ID_EDIT_CUT                    40015
#define ID_EDIT_COPY                    40016
#define ID_EDIT_PASTE                  40017

// Next default values for new objects
//
#ifdef APSTUDIO_INVOKED
#ifndef APSTUDIO_READONLY_SYMBOLS
#define _APS_NEXT_RESOURCE_VALUE        101
#define _APS_NEXT_COMMAND_VALUE        40020
#define _APS_NEXT_CONTROL_VALUE        1000
#define _APS_NEXT_SYMED_VALUE          101
#endif
#endif

---

app_four.rc

Code:

---

//Microsoft Developer Studio generated resource script.
//
#include "resource.h"

#define APSTUDIO_READONLY_SYMBOLS
/////////////////////////////////////////////////////////////////////////////
//
// Generated from the TEXTINCLUDE 2 resource.
//
#ifndef __BORLANDC__
#include "winres.h"
#endif

/////////////////////////////////////////////////////////////////////////////
#undef APSTUDIO_READONLY_SYMBOLS

/////////////////////////////////////////////////////////////////////////////
// English (Canada) resources

#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENC)
#ifdef _WIN32
LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_CAN
#pragma code_page(1252)
#endif //_WIN32

#ifdef APSTUDIO_INVOKED
/////////////////////////////////////////////////////////////////////////////
//
// TEXTINCLUDE
//

1 TEXTINCLUDE DISCARDABLE
BEGIN
    "resource.h\0"
END

2 TEXTINCLUDE DISCARDABLE
BEGIN
    "#ifndef __BORLANDC__\r\n"
    "#include ""winres.h""\r\n"
    "#endif\r\n"
    "\0"
END

3 TEXTINCLUDE DISCARDABLE
BEGIN
    "\r\n"
    "\0"
END

#endif    // APSTUDIO_INVOKED


/////////////////////////////////////////////////////////////////////////////
//
// Menu
//

IDR_MAINMENU MENU DISCARDABLE
BEGIN
    POPUP "&File"
    BEGIN
        MENUITEM "&New",                        ID_FILE_NEW
        MENUITEM "&Open...",                    ID_FILE_OPEN
        MENUITEM "Save &As...",                ID_FILE_SAVEAS, GRAYED
        MENUITEM SEPARATOR
        MENUITEM "&Close",                      ID_FILE_CLOSE, GRAYED
        MENUITEM SEPARATOR
        MENUITEM "E&xit",                      ID_FILE_EXIT
    END
    POPUP "&Edit", GRAYED
    BEGIN
        MENUITEM "C&ut",                        ID_EDIT_CUT
        MENUITEM "&Copy",                      ID_EDIT_COPY
        MENUITEM "&Paste",                      ID_EDIT_PASTE
    END
    POPUP "&Window", GRAYED
    BEGIN
        MENUITEM "&Tile",                      ID_WINDOW_TILE
        MENUITEM "&Cascade",                    ID_WINDOW_CASCADE
    END
END

#endif    // English (Canada) resources
/////////////////////////////////////////////////////////////////////////////



#ifndef APSTUDIO_INVOKED
/////////////////////////////////////////////////////////////////////////////
//
// Generated from the TEXTINCLUDE 3 resource.
//


/////////////////////////////////////////////////////////////////////////////
#endif    // not APSTUDIO_INVOKED

---

PLEASE! IT'S URGENT! I can't get it...

Don't double post. Don't say your problem is urgent. I find it rude. I also find it rude that you plageurize [relatively popular] code from the internet.

Now, I see that you have tried to add a menu by using the WNDCLASS::lpszMenuName element. I can't see why that would not work, but there are other methods of applying a menu to your window. You can use the HMENU parameter of CreateWindowEx, and the SetMenu function. See if those work.

Ok, sorry for being rude. I'm a total newbie, so i thought that i could learn from this project, but it have to work off course. If it doesn't, i'm learning the wrong thing.

Where should i put mu CreateWindowEx then? And what should i remove from the code?

If your a total newbie, then you shouldn't be working with win32 code. If you have no prior C++ experience, you will not understand the code, and not learn.

i read a bit and maybe i should change

Code:

---

hwnd = CreateWindowEx(
                0,
                g_szClassName,
                "Jinky - Livijnproductions.se",
                WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN,
                CW_USEDEFAULT, CW_USEDEFAULT, 480, 320,
                NULL, NULL, hInstance, NULL);

---

I just don't know to what, i tested to set the 2nd NULL, the on before hInstance, to hMenu and HMENU but i just get errors. What am i doing wrong? I still use the same code as above.

Quote:

---

Originally Posted by Sentral

If your a total newbie, then you shouldn't be working with win32 code. If you have no prior C++ experience, you will not understand the code, and not learn.

---

i hate when people say that. Help me instead, i know i can learn from programs. I did with PHP, and some people say that PHP is harder than C++...

Quote:

---

Originally Posted by Livijn

i hate when people say that. Help me instead, i know i can learn from programs. I did with PHP, and some people say that PHP is harder than C++...

---

Others have already suggested ways for you to fix your code. You don't even know where to look in the code to change it! Also, you cross-posted. PHP is not harder then C++. If you don't want to take the time to learn something correctly, don't expect success.

Perhaps, you should listen to advice if it's given to you more than once?

Yeah, but i just want to finish this one. I'm trying, right? How should i know which code is worng, etc. It would be fun if someone could help me, nice and slow. With some code...

I've searched for SetMeny and CreateWindowEx but i haven't got a good result. If you have a good tutorial, please, post it. Or you can just tell me what to do...

Here

I ment about menus...

i think i know the problem, i have to link the .rc file...
but i can only link .lib and .o ...

when i have a project in Dev-C++ with these three documents i posted, and i try to compile. It doesn't work. Don't know why, a new document creates by Dev-C++ and it sais:

Code:

---

/* THIS FILE WILL BE OVERWRITTEN BY DEV-C++ */
/* DO NOT EDIT! */

#include "app.rc"

---

Is that the problem? Because if it is, i've got Visual Studio too. But i can't compile with Visual Studio. Only create solution. Annoying...

First, Sentral is right. Do console programming first. Second, have you looked at the tutorial links at the top of this board? I think not. Third, have you googled? I think not.

I'd say both of you guys should just go away if you don't have anything but discouragement to contribute. The definition of your menu resource is within a conditional (#if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENC), can't see why that would not evaluate to true but whatever) and full of a bunch of trash. I know I got it to work for me by just using:

Code:

---

#include "resource.h"


IDR_MAINMENU MENU DISCARDABLE
BEGIN
    POPUP "&File"
    BEGIN
        MENUITEM "&New",                        ID_FILE_NEW
        MENUITEM "&Open...",                    ID_FILE_OPEN
        MENUITEM "Save &As...",                ID_FILE_SAVEAS, GRAYED
        MENUITEM SEPARATOR
        MENUITEM "&Close",                      ID_FILE_CLOSE, GRAYED
        MENUITEM SEPARATOR
        MENUITEM "E&xit",                      ID_FILE_EXIT
    END
    POPUP "&Edit", GRAYED
    BEGIN
        MENUITEM "C&ut",                        ID_EDIT_CUT
        MENUITEM "&Copy",                      ID_EDIT_COPY
        MENUITEM "&Paste",                      ID_EDIT_PASTE
    END
    POPUP "&Window", GRAYED
    BEGIN
        MENUITEM "&Tile",                      ID_WINDOW_TILE
        MENUITEM "&Cascade",                    ID_WINDOW_CASCADE
    END
END

---

I wasn't discouraging anything. I told him the right things to do. If someone is not ready for Windows programming, they'll learn more by doing console programming.

Actually, i got it right yesterday when Cboard were offline. Nice of you helping me anyway Tonto! :D I really aprichiate it. I changed #include "windows.h" to #include <windows.h>, but it didn't give me a error that the file doesn't exist, thats wierd. Well, thank you all for the help!

Now i want to ad things to my meny...
How should i define it? Is there som speciall defining or can i just choose a number.
In the main.c, if the user clicks at livijnproductions under help i want it to open a webpage and them to http://livijnproductions.se

The code:
main.c

Code:

---

                                case ID_HELP_LIVIJN:
                                       
                                break;

---

app.rc

Code:

---

        POPUP "&Help"
    BEGIN
        MENUITEM "&Livijnproductions",          ID_HELP_LIVIJN

---

resource.h

Code:

---

#define ID_HELP_LIVIJN                  40018

---

I have tested the code, and it works. Just that it don't send me to my page. That's all i need to know now.

EDIT:
I've also got ID_HELP_README and if the user press it, i want it to open a file... :D
Like C://Program/Jinky/readme.txt

I'm really sorry for beeing rude. I didn't mean to. I still need help, if you know any website you can give me a link to, please do that. Or just write your code.

Thank You!

Clicky.

No, i mean seriously...

I am being serious. Then look at this library.

and do what? i have downloaded the file... which lib?
how should i use it, and what is it for?

Thank You!

It's a HUGE library, complicated to link, etc. You can use wxDev-C++ to do the linking for you, after which you only need to look at some basic tutorials and this class.

Quote:

---

Originally Posted by Livijn

i hate when people say that. Help me instead, i know i can learn from programs. I did with PHP, and some people say that PHP is harder than C++...

---

PHP is harder that C++? PHP is kind of the easiest (web)language in the world...

Quote:

---

Originally Posted by Sentral

PHP is not harder then C++.

---

Note the bold. It's not harder.

Clicked on the wrong "Quote" button. :)

I don't understand, i want the file to open a new window. Must i use wx? I don't want to really, it's like cheating :D

Isn't there any code like GotoURL("http://....", _Blank....);
or something like that...

Not in the C++ language, nor in Win32. Both of these do not interact with the internet. WinSock is a lower level way to do the same thing.

But i just want to open a new window... Not get contents...
And i use C, not C++ :P

wx is probably the best way to do this. But, there is a registry key HKCR\htmlfile\shell\open\command that for me (using IE 7.0) like this:
"C:\Program Files\Internet Explorer\IEXPLORE.EXE" -nohome
This last part shows the default browser. So if in your prog you loaded this key and then ran that program in your program with the correct arguments, I guess it's possible.

Quote:

---

Originally Posted by Livijn

Isn't there any code like GotoURL("http://....", _Blank....);

---

FAQ > How do I... (Level 2) > Run a program from within a program - scroll to the bottom of that faq page; ShellExecute is the simplest option.

I was talking about how to know which browser was the user's default.

I guess you mean this code...

Code:

---

#include <windows.h>  //You need shell32.lib for this one

int main(void)
{
  char szPath[] = "C:\Program Files\Internet Explorer\IEXPLORE.EXE"                                                                                          ;

  HINSTANCE hRet = ShellExecute(
        HWND_DESKTOP, //Parent window
        "open",      //Operation to perform
        szPath,      //Path to program
        NULL,        //Parameters
        NULL,        //Default directory
        SW_SHOW);    //How to open

  /*
  The function returns a HINSTANCE (not really useful in this case)
  So therefore, to test its result, we cast it to a LONG.
  Any value over 32 represents success!
  */

  if((LONG)hRet <= 32)
  {
    MessageBox(HWND_DESKTOP,"Unable to start program","",MB_OK);
    return 1;
  }

  return 0;
}

---

Can i change the int main (void) to int call (void) or something

Is this what you need?

Code:

---

#include <windows.h>

int main(void)
{     
  ShellExecute(NULL, "open","http://livijnproductions.se",  NULL, NULL,SW_SHOWNORMAL);
  return 0;
}

---

i think it is, but if i want to open a file...

Code:

---

#include <windows.h>

int main(void)
{     
  ShellExecute(NULL, "open","C://Program/Jinky/README.html",  NULL, NULL,SW_SHOWNORMAL);
  return 0;
}

---

is this right?

That'll work as long as the path to the HTML file is legit.

I'm not english, what does legit mean? Guilty?

It's short for 'legitimate' - in this context it means the url/path must be to a valid web address or html file, otherwise your default browser (or whatever is the default application for html files on your system) will start but will report an error.

it doesn't start for me... the C:// path file but the http// starts... wh`yh?

maybe it is because c:/ should have only 1 slash?

Does it matter if i write C:\ or C:/ ?

Quote:

---

Originally Posted by Livijn

Does it matter if i write C:\ or C:/ ?

---

Oh yes it does. / is only for web sites. Also, you should use \\ everywhere unless you want to use something like \n or \r or \0.

Windows seems to accept both slashes in some cases (for example Start>Run on XP Home), but \ is correct and / might work but not always. And \ needs to be escaped.

aka

Code:

---

std::string a = "C:\\";
std::string b = "C:/";

---