Hi first time here :)

I need some help with my first program. It compiles just fine... but that is just about it. It is supposed to be a simple calculator but has many problems.
First of all I cant seem to get the program to return to the menu after each calculation. Also it always performs addition first than division...doesnt matter which choice you make.

Code:

---

#include <cstdlib>
#include <iostream>
#include <cstdio>
using namespace std;

int nChc;
int nValue1;
int nValue2;

int main(int argc, char *argv[])
{
  cout << "Welcome to the DOS Calculator!!!\n"
      << "Please choose from a list of choices:\n"
      << "1) Addition\n"
      << "2) Subtraction\n"
      << "3) Multiplication\n"
      << "4) Division\n"
      << "Enter 1-4: ";
  cin  >> nChc;
  if (nChc = 1)
  {
          cout << "Enter two values to be added:\n"
              << "Value 1: ";
          cin  >> nValue1;
          cout << "Value 2: ";
          cin  >> nValue2;
          int sum = nValue1 + nValue2;
          cout << nValue1 << " + " << nValue2 << " = " << sum << "\n";
          }
 
  else if (nChc = 2)
      {
        cout << "Enter two numbers to be subtracted\n"
            << "Value 1: ";
        cin  >> nValue1;
        cout << "Value 2: ";
        cin  >> nValue2;
        int minus = nValue1 - nValue2;
        cout << nValue1 << " - " << nValue2 << " = " << minus << "\n";
        }
  else if (nChc = 3)
    {
        cout << "Enter two numbers to be multiplied\n"
            << "Value 1: ";
        cin  >> nValue1;
        cout << "Value 2: ";
        cin  >> nValue2;
        int product = nValue1 * nValue2;
        cout << nValue1 << " * " << nValue2 <<  " = " << product << "\n";
        }
  else (nChc = 4);
        {
        cout << "Enter two numbers to be divided\n"
            << "Value 1: ";
        cin  >> nValue1;
        cout << "Value 2: ";
        cin  >> nValue2;
        float quotient = nValue1 / nValue2;
        cout << nValue1 << " / " << nValue2 << " = " << quotient << "\n";
        }
  system("PAUSE");
    return EXIT_SUCCESS;
}

---

should I be using boolean variables instead?

why do you need cstdio?
replace system("PAUSE") by cin.get() and you can also remove cstdlib
why do you need globals?

x=4 is assignment
x == 4 is comparison

PS. Note that for integer values 5/2 == 2

Quote:

---

should I be using boolean variables instead?

---

No need to use Bools in C++, use integers instead, 0 is false, anything other than 0 is true.

the include files are already "included" in with my dev C++ compiler.

thanks!! that solves my first problem. I keep forgetting that the = is actually not a =, but assign a value to an variable

how do I get the program to return to the menu?

Quote:

---

Originally Posted by eaane74

the include files are already "included" in with my dev C++ compiler.

thanks!! that solves my first problem. I keep forgetting that the = is actually not a =, but assign a value to an variable

how do I get the program to return to the menu?

---

Use a do-while loop, and prompt the user if he wants to do another calculation or if he wants to quit.

If you just want it to loop forever just put a while(1) loop around your code.

Quote:

---

Originally Posted by Neo1

No need to use Bools in C++, use integers instead, 0 is false, anything other than 0 is true.

---

No Bool is needed. Bool was introduced for very good reasons. One of them was exactly the problem of people using int as a replacement. It isn't type safe and led to an host of very different forms of "bool". Some 0 was false, anything else was true, others 0 was false, 1 was true, others -1 was true, ... not to mention the myriad of ways coders then chose to implement their own bool hack...

Code:

---

enum bool { FALSE, TRUE };

enum bool { false, true };

typedef int bool;

#define TRUE 1
#define FALSE 0

#define true 1
#define false 0

---

etc... etc... etc... and also where these things were introduced in the code. Some on headers, others not. Files with different names... absolutely no standard way of doing it.

Bool is a datatype now. Type safe and standard. Use it. It's smarter to do it.

Also, I would recommend that you do something like this:

(pseudo code)

Code:

---

int choice=0, num1=0, num2=0, result=0;

while ( choice != exit_value )
{
  print: [Your addition/subtraction/division/multiplication question add an exit option]
  get: choice

  print: "Enter number 1:"
  get: num1

  print: "Enter number 2:"
  get: num2

  /* Now use the value of choice to determine the result */

  if choice == addition_value { [...] }
  else if choice == subtraction_value { [...] }
  else if choice == multiplication_value { [...] }
  else if choice == division_value { [...] }

  /* inside the { [..] }'s you assign a value to result
    depending on what the user wants to do with the numbers */

  print: "Result = " result

}

---

This just cuts down on the number of lines of code. Will do the same as what you initially wanted, just with less lines. Professor may be happier with it.

You are also using global variables, place these inside main and make them local.

this compiles but still doesnt run...what am I doing wrong? :(

Code:

---

#include <cstdlib>
#include <iostream>

using namespace std;

int main(int argc, char *argv[])
{
int choice=0, num1=0, num2=0, result=0;
while ( choice != 0 )
{
  cout << "Enter 1 for addition\n"
      << "Enter 2 for subtraction\n"
      << "Enter 3 for multiplication\n"
      << "Enter 4 for Division\n"
      << "Enter 0 to exit program";
  cin  >> choice;

  cout << "Enter number 1:";
  cin  >> num1;

  cout << "Enter number 2:";
  cin  >> num2;

  /* Now use the value of choice to determine the result */

  if (choice == 1)
  {
            result = num1 + num2;
              }
  else if (choice == 2)
  {
      result =  num1 - num2;
        }
  else if (choice == 3)
  {
      result =  num1 * num2;
        }
  else if (choice == 4)
  {
      result =  num1 / num2;
        }

  /* inside the { [..] }'s you assign a value to result
    depending on what the user wants to do with the numbers */

  cout << "Result = " << result;
}
    return EXIT_SUCCESS;
}

---

Choice is initialised to 0 :rolleyes: start it at -1 or anything really. You should also do some error checking to make sure that the choice is within the right range.That was my fault, sorry. Didn't compile my pseudo-code :)

:p oops...my bad lol...works just fine now. THANKS