Struct list

ooh i was creating an program for dictionary and words....and
the problem is that it ships over the loop for putting a word for container and goes to definition.

Code:

---

#include <stdio.h>


struct entry
{
        char *word;
        char *definition;
};



int main(void)
{
    //char *word = "Justin";
    //printf("%s",word);

char letter,answer,array[80];



int num,temp=0;
printf("How many entries to define?\n");
scanf("%d",&num);



struct entry list[num];



do
{

printf("Enter words\n");

int i=0;


do
{
            letter = getchar();
            array[i] = letter;
            ++i;
}while(letter != '\n');

array[i-1] = '\0';

list[temp].word = array;

printf("%s\n",list->word);


printf("---------------------------------------\n");

printf("Enter definitions\n");

i=0;


do //inputing sentences into definition
{
            letter = getchar();
            array[i] = letter;
            ++i;
}while(letter != '\n');

array[i-1] = '\0';

          list[temp].definition= array;

++temp;

printf("%s\n",list -> definition);

printf("Do you wish to  make another entry(y/n)?");

scanf("%c",&answer);



}  while(answer != 'y'); //end entire loop


}

---

oooh by the way if u see the while weird is because im was going to change the struct entry list[num];, and make it soo that every time it loops there would be 1 additional more memory location for list but i'll do that later seen the problem is with the word loop...

Code:

---

  printf("How many entries to define?\n");
    scanf("%d",&num);

    struct entry list[num];

---

First of all your code need a proper indentation. And in the above code while declaring an array your array size need to be const. something like this

Code:

---

    struct entry list[10];

---

it cant depend on a variable. C standard.

Code:

---

void clear_buffer(void)
{
    int ch;
   
    while((ch=getchar()) != '\n' && ch != EOF);
}

---

use this function here

Code:

---

printf("Enter words\n");
        j =0;
        clear_buffer();
        do
        {
            letter = getchar();
            array[j] = letter;
            ++j;

---

This clears the input buffer. That u got avoid using scanf funtion. And the problemw which u where getting likely because of scanf.

Code:

---

        printf("%s\n",list -> definition);
        printf("Do you wish to  make another entry(y/n)?");
        scanf("%c",&answer);
    }while(answer != 'n' && i < num); //end entire loop

---

and u got tocheck for boundry of the array. becuase C dosn't check for array boundries

ssharish2005

Are you using some language extension for C90 or C++, or C99?

I'll assume you want C, and recommend looking into malloc to dynamically allocate space into which you can write strings. A pointer to unallocated memory should not be written to.

Also, look in the FAQ for improved methods for user input. My short version: always read user input as a string, convert to this string to numeric if necessary (fgets and sscanf to begin).

Perhaps some application of the fine art of indenting code as well Darkinyuasha1

thanks but can u explain the clear_buffer func..a bit more soo i can get a better understand of it...sorry im a bit slow ^_^ heh. oooh and this is C without no extension but i was thinking about using link list and malloc...


p.s const struct entry list[10]; wouldn't work or const would work in most of this program because your inputing variables into the container

Quote:

---

Originally Posted by Salem

Perhaps some application of the fine art of indenting code as well Darkinyuasha1

---

Yes the art of indention is powerful lol....

> thanks but can u explain the clear_buffer func
Looking a little different it's

Code:

---

int junk;
do
{
  junk = getc(stdin);
}
while(junk != EOF && junk != '\n');

---

Now you can clearly see that we're just looping a call to one of the getc* functions in an attempt to clean up the input stream, because we were supplied with more data than we needed.

Quote:

---

Originally Posted by citizen

> thanks but can u explain the clear_buffer func
Looking a little different it's

Code:

---

int junk;
do
{
  junk = getc(stdin);
}
while(junk != EOF && junk != '\n');

---

Now you can clearly see that we're just looping a call to one of the getc* functions in an attempt to clean up the input stream, because we were supplied with more data than we needed.

---

thanks now thats clear up and my program works..i can go back to do my other side programs ^_^