Need help with HybridList class errors......

I am in desperate need to figuring out why my program has 11 errors on line 191 and 1 error on line 130. If someone could please assist me, I would greatly appreciate your help.

Code:

---


//************************************************************
 void HybridList::Print() const

// Postcondition:
//    component members of all nodes (if any) in linked list
//    have been output
   
{
    mePtr currPtr = head;                                // Loop control pointer

    while (currPtr != NULL)
    {
        cout << currPtr->lName << endl;            // Line 130 Error C2679
        currPtr = currPtr->link;
    }
}
//*************************************************************
void HybridList::Insert( /* in */ ComponentType item )

// Precondition:
//    component members of list nodes are in ascending order
//  && item is assigned
// Postcondition:
//    New node containing item is in its proper place
//      in linked list
//  && component members of list nodes are in ascending order

{
    mePtr currPtr;      // Moving pointer
    mePtr prevPtr;      // Pointer to node before *currPtr
    mePtr newMePtr;    // Pointer to new node

    // Set up node to be inserted

    newMePtr = new me;
    newMePtr->lName = item;

    // Find previous insertion point
    prevPtr = NULL;
    currPtr = head;

    while (currPtr != NULL && item > currPtr->lName)  // Line 191 Error C2784
    {
        prevPtr = currPtr;
        currPtr = currPtr->link;
    }

    // Insert new node

    newMePtr->link = currPtr;
    if (prevPtr == NULL)
        head = newMePtr;
    else
        prevPtr->link = newMePtr;
}

---

And the errors are?

These are the errors:

1. Hybrid List Assignment\HybridList.cpp(130): error C2679: binary '<<' : no operator found which takes a right-hand operand of type 'ComponentType' (or there is no acceptable conversion)

2. HybridList.cpp(191):error C2784: 'bool std::operator >(const std::_Ptrit<_Ty,_Diff,_Pointer2,_Reference2,_Point er2,_Reference2> &,const std::_Ptrit<_Ty,_Diff,//_Pointer,_Reference,_Pointer2,_Reference2> &)' : could not deduce template argument for 'const std::_Ptrit<_Ty,_Diff,_Pointer2,_Reference2,_Point er2,_Reference2> &' from 'ComponentType'

Does ComponentType have operator<< and operator> defined?

What is mePtr defined as?

ComponentType is a string. This is how I declared it:

Code:

---

// This is the file that declares the itemType data type

#ifndef COMPONENTTYPE_H
#define COMPONENTTYPE_H

#include <iostream>

using namespace std;

typedef string ComponentType;

#endif

---

Code:

---

typedef me* mePtr;
struct me
{
        ComponentType lName;
        ComponentType fName;
        ComponentType mName;
        ComponentType title;
        ComponentType companyName;
        ComponentType streetAddress;
        ComponentType city;
        ComponentType state;
        ComponentType zipCode;
        ComponentType phoneNumber;
        ComponentType faxNumber;
        ComponentType emailAddress;
        mePtr link;
};

---

Why typedef string as ComponentType?

I used typedef string as ComponentType for an easier string variable pass to the Hybrid class.

You didn't #include <string>.

That solved that problem. Thanks

Since you don't use anything from <iostream> in the ComponentType header, and since there is no need for a using directive when you are only using one name from the std namespace, that header would be better to look like this:

Code:

---

#ifndef COMPONENTTYPE_H
#define COMPONENTTYPE_H

#include <string>

typedef std::string ComponentType;

#endif

---

Another problem but it's in the Print function of the Hybrid class. I don't get any errors but the output is not what I expected. I need all of the elements of the struct to display as output but the program only display the first element of the struct and the other elements are blank lines. So the program knows that the elements are there but instead of text it's several blank lines.

My code is below. Thanks.

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include "HybridList.h"

using namespace std;

struct me
{
        ComponentType lName;
        ComponentType fName;
        ComponentType mName;
        ComponentType title;
        ComponentType companyName;
        ComponentType streetAddress;
        ComponentType city;
        ComponentType state;
        ComponentType zipCode;
        ComponentType phoneNumber;
        ComponentType faxNumber;
        ComponentType emailAddress;
};

int main()
{
        HybridList list1;
        me contact;
       
        char another;
       
        cout << "Enter last name: ";
        getline(cin, contact.lName);
        cout << "Enter first name: ";
        getline(cin, contact.fName);
        cout << "Enter middle name: ";
        getline(cin, contact.mName);
        cout << "Enter title: ";
        getline(cin, contact.title);
        cout << "Enter company name: ";
        getline(cin, contact.companyName);
        cout << "Enter street address: ";
        getline(cin, contact.streetAddress);
        cout << "Enter city: ";
        getline(cin, contact.city);
        cout << "Enter state: ";
        getline(cin, contact.state);
        cout << "Enter zip code: ";
        getline(cin, contact.zipCode);
        cout << "Enter phone number: ";
        getline(cin, contact.phoneNumber);
        cout << "Enter fax number: ";
        getline(cin, contact.faxNumber);
        cout << "Enter e-mail address: ";
        getline(cin, contact.emailAddress);

        list1.Insert(contact.lName);
        list1.Print();

        cout << "Would you like to enter another contact(Y/N): ";
        cin >> another;

                .....  program continues .....
}
//*************************************************************
void HybridList::Print() const

// Postcondition:
//    component members of all nodes (if any) in linked list
//    have been output

{
    mePtr currPtr = head;    // Loop control pointer

    while (currPtr != NULL)
    {
        cout << currPtr->lName << endl;         
        cout << currPtr->fName << endl;
        cout << currPtr->mName << endl;
        cout << currPtr->title << endl;
        cout << currPtr->companyName << endl;
        cout << currPtr->streetAddress << endl;
        cout << currPtr->city << endl;
        cout << currPtr->state << endl;
        cout << currPtr->zipCode << endl;
        cout << currPtr->phoneNumber << endl;
        cout << currPtr->faxNumber << endl;
        cout << currPtr->emailAddress << endl;
        currPtr = currPtr->link;
    }
}

---

I think it have something to do with passing the struct to the class.

Your Insert function should probably be taking a me object instead of a ComponentType. You aren't inserting the lname into the list, you are inserting an entire me object.

So I should pass contact to the insert function because contact is an object of the me struct. So item would then be an object of me.

That makes sense to me.

I made the changes and some errors occured so I changed the things in bold. It executes without errors but my output is still displaying only the first element as before with blank lines for the other elements.

I am going crazy with this program. Please help me, if you can. Thanks.

Code:

---

void HybridList::Insert( /* in */ me item )

// Precondition:
//    component members of list nodes are in ascending order
//  && item is assigned
// Postcondition:
//    New node containing item is in its proper place
//      in linked list
//  && component members of list nodes are in ascending order

{
    mePtr currPtr;      // Moving pointer
    mePtr prevPtr;      // Pointer to node before *currPtr
    mePtr newMePtr;      // Pointer to new node

    // Set up node to be inserted

    newMePtr = new me;
    newMePtr->lName = item.lName;

    // Find previous insertion point
    prevPtr = NULL;
    currPtr = head;

        while (currPtr != NULL && item.lName > currPtr->lName)  // Error with this line
        {
        prevPtr = currPtr;
        currPtr = currPtr->link;
    }

    // Insert new node

    newMePtr->link = currPtr;
    if (prevPtr == NULL)
        head = newMePtr;
    else
        prevPtr->link = newMePtr;
}

---

What I see
newMePtr->lName = item.lName;
you initialize only lName in your stored data

If you want to store all strings you should copy all strings...
maybe something like
*newMePtr = item;
will work

also - to avoid unnecesary copying, I think you should pass me as const reference
void HybridList::Insert( /* in */ const me& item )

It works vart. Thank you.

Last question, I am currently outputting the list to the screen but I need it to print to a file called 'contact.dat'. How can I go about that in the Hybrid class print function?

Thanks

Look at a tutorial on file I/O. It's not a difficult thing.

I figured it out. I was forgetting to use include <fstream>. Thanks for all of the help and I really appreciate the help.

Code:

---

            #include <fstream>
            fstream binary_file("'contact.dat'.",ios::binary|ios::out);
            binary_file.write(reinterpret_cast<char *>(currPtr),sizeof(me));
            binary_file.close();

---

Check out this link to know more.

EDIT: It seems like I didn't post it in time. :D Sorry can't help much.