Trying to count numbers in file

So I am using file stream to see in a file. Then read the contents of the file. I am supposed to be counting the number of words, sentences, digits etc. I am working on the digit count right now and this is not working! It should work- unless I am seeing something small that I dont have. Please someone help me! Heres the code:

Code:

---

int numdigits(ifstream& name)
{
  string words;
  char ch;
  int count = 0;

 name >> words;
 while(!name.eof())
  {
    name >> ch;
    if (ch == 1)
      {
      count ++;
      }
    name >> words;
  }
  return count;
}

---

Iwant it to count the number of digits in the file. Thanks!

Code:

---

if (ch == 1)

---

Should be:

Code:

---

if (ch == '1')

---

hey i tried that- still doesnt work- i just forgot to put them back in.

All it is returning is a 0. But if i change the int count to int count = 1 it will return a 1. So is it only reading my count variable and returning that without going through the while loop?

hmm, why just '1'? there are 10 digits

Code:

---

ch >= '0' && ch <= '9'

---

maybe?

I am just trying to get it working with the 1 digit and then i will add the rest in. I purposely put a couple 1's in my file to see if it will read it and its not. but thanks!

Notice how you are reading into the words variable, and later reading into the ch variable. Every time you read into words, it will read in an entire string until it finds whitespace (skipping leading whitespace). Your code is ignoring what is read into words.

If you are only checking for digits, you should remove the name >> ch line, and then change words to ch in the other two places that read from name. You only need to read in single characters, not whole strings.

Daved-

Normally you help me but this time it still didnt work. Still returning a 0. Am i calling the function right?

Code:

---

while(!name.eof())
    {
    getwords(name);
    numdigits(name);
    }

---

There is nothing that I have not tried- that is why I had to come here and see if someone could help.

Won't this check for EOF twice? I'm not so sure that function is your problem. Post all your code.

Reread Daved post, ammochck21. It's all there ;)

Code:

---


#include <iostream>
#include <fstream>
#include <string>
using namespace std;


string getwords(ifstream&);
int numwords(ifstream&);
int numsent(ifstream&);
int numdigits(ifstream&);
int numsearch(ifstream&);
int numletters(ifstream&);

int main()
{
  string filename;
  string search;
  string words;
  string x;
  ifstream name;

  cout << endl;
  cout << "Please enter the name of the input file" << endl;
  cin >> filename;
  cout << endl;
  name.open(filename.c_str());
  cout << "Please enter your search string" << endl;
  cin >> search;
  cout << endl;

  cout << "The reformatted content of " << filename << " is:" << endl;
  cout << endl;

  while(!name.eof())
    {
    getwords(name);
    numdigits(name);
    }

  cout << endl;
  cout << endl;
  cout << "# of words: " << endl;                            //getwords(name) << endl;
  cout << "# of sentences: " << endl;                        //<< numsent(name);
  cout << "# of letters: " << endl;                          //<< numletters(name);
  cout << "# of digits: " << numdigits(name) << endl;
  cout << "# of occurrences of " << search << ":" << endl;    // << numsearch(name);
  cout << endl;
}

string getwords(ifstream& name)
{
  int sum;
  string words;
  int wlen;
  int sumline;
  int count;

  name >> words;
  while(!name.eof())
  {
    //wlen = words.length();
    //sum = sum + wlen;
    //while (sum <= 40)
    // {

      cout << words << " ";
    // }
    name >> words;
    }

 return words;
}


int numdigits(ifstream& name)
{
  string words;
  char ch;
  int count = 0;

 name >> ch;
 while(!name.eof())
  {
    if (ch =='1')
      {
      count ++;
      cout << count;
      }
    name >> ch;
  }
  return count;
}

---

All the cout << endl is just because I like spacing. Please some tell me you see the problem!

disregard the cout << count in the loop- i was just trying to test it.

What about rewind before you starting count from the beginning? Or just count everything at one scan

You read through the file once to get the words, but then you try to read through it again to count the digits. You can do it that way if you like (it might not be the best solution), but you have to re-open the file or seek to the beginning, then clear the flags before starting over.

Your numdigits function looks ok by itself. Try commenting out the call to getwords to test whether numdigits is working properly. Then work on re-opening the file or changing your code to test them all at once.

Thank you! I will try that- time for class. I am sure I will back with other questions. Thanks again everyone!

ok so here is the updated version:

Code:

---



  name >> words;
  while(!name.eof())
    {
    getwords(words);
    numdigits(words);

    name >> words;
    }

  cout << endl;
  cout << endl;
  cout << "# of words: " << endl;                            //getwords(words) << endl;
  cout << "# of sentences: " << endl;                        //<< numsent(words);
  cout << "# of letters: " << endl;                          //<< numletters(words);
  cout << "# of digits: " << numdigits(words) << endl;
  cout << "# of occurrences of " << search << ":" << endl;    // << numsearch(words);
  cout << endl;
}


int numdigits(string& name)
{
  char ch;
  int count = 0;

    if (ch == '1')
      {
      count++;
      }

  return count;
}

---

she said i have to pass in each string word and have it go through each of the functions but the problem i am having with my digits function is how can i pass a string word in and have it see if its a character?? it is obvisouly giving me error of words cant = character. how do i get it to convert. and i know i only have 1 there but i am just trying to see if it will recognize anything. I also need it to keep going through the loop for all of the words in the file. Help!!!

You can access each character of a string with operator[]. So name[0] is the first character and name[name.length() - 1] is the last character. Just loop through all the characters in the string.

Another note- you will have to keep a count inside your main function of the number of digits. Right now when you call numdigits, you ignore the return value. You need to look at that return value, and keep a running count of all the values returned from that function to get the total number of digits.

ok then what is my count++ doing in my digits function? nothing? i am trying not to have anything in my main function expect the cout statements and the calling of the functions. Can i just fix my digits function to make it count right?

>> what is my count++ doing in my digits function?
It is counting the digits in the current word. This is necessary. You still have to return the information back to main so that it can be output. As it is right now, main doesn't know anything about the count variable in the numdigits function. It needs to know the value in order to output it.

ok but if i am returning count to main, and then in my output i am printing that whole function- shouldnt it print what i return? I mean it would have the number stored in count in the digits function right? So when i call the digits function from main in my print statement- why wouldnt it print the number?

Code:

---

cout << "# of digits: " << numdigits(words) << endl;

---

i think i am going to scratch this whole thing and start over. i am having such a hard time with this. thanks though

You call numdigits once for each word in the file. Each time you call it, count starts over at 0 and returns only the number of digits in that particular word. Your output code won't work because you are only calling numdigits with a single word when you are outputting it. Functions just don't work that way.

All you need is a variable in main to remember the total count. Add the return value of numdigits to it for each word, then output that variable when you are done.

ok i get that but heres my new idea-

have one function that does all the counting for number of digits, number of sentences, number of words, numbers of letters, and number of occurences of the search string. I will also print out from this function after everything i counted.

then have another function that will do the formatting of the whole file. We have to reformat the whole file to have only 40 characters on each line. so i will have one function that will count each word and then add up the lengths and have it do less than 40 kinda thing.

then i have int main which will just call the functions.

please tell me this sounds good because i am just not understanding!

About counting all at once I would start with something like that:

in psevdocode

Code:

---

int main()
{
        open_file
        parse_file
        close_file
}

void parse_file()
{
        initialize counters
        for(;;)
        {
                read line
                if(eof reached)
                        break;

                sentences += count_sentences(line);
                words += count_words(line);
                digits += count_digits(line);
                ...
        }
        print counters
}

---

If you want to "format" file at the same moment, you can add possibility to write the string aftere you finish counting elements in this string, formatting it before writing, to another file.

In this case you read file only once but parse every line several times.
But I would start solving this problem only aftere the more simple solution is working fine..

that is what i need to do- read through the file only once and count everything in it. she only wants one pass through. so the sample code you posted will do all my counting at once? thanks for your help

Ok well i got the digits to work finally!!!!!!

now i am working on doing a find in the file. I am asking the user to enter in a searcg string. I then need to go through my file and count how many times that word is found. this is what i have but it is returning 0 to me again. I am sure my for loop is not correct.

Code:

---


int count(ifstream& name, string search)
{
  int count = 0;
  char ch;
  string words;
  int wordsearch;

  name >> words;
  while(!name.eof())
    {
      name >> ch;
      if(ch == '0'|| ch == '1'||ch == '2'||ch == '3'||ch == '4'||ch == '5'||ch == '6'||ch== '7'||ch == '8'||ch== '9')
        {
          count++;
        }
      name >> words;

    }

  cout << "# of digits: " << count << endl;

 while(!name.eof())
    {
  int i = 0;
  int wordsearch = 0;

  // getline(name, words, '\n');

    for(i = words.find(search, 0); i != string::npos; i = words.find(search, i))
      {
      wordsearch++;
      i++;  // Move past the last discovered instance to avoid finding same
            // string
      }
    }
  cout << "# of occurrences of " << search << ":" << wordsearch << endl;
}

---

Unfortunately you are back to the same problems again. You are reading into the words variable and the ch variable, but whatever you read into words will not be checked by ch and vice versa. You are also going through the file twice even though your teacher suggested that you not do that.

Look at vart's pseudocode again. It is very different from your code.