Hangman Game - Need Help!!

I need help to improve below program interface, store a list of words in a file and read the words randomly for each game the player guess. Anyone can help? TQ.

Code:

---

// Hangman game
//

 #include <iostream>
 #include <string>
#include <cctype>


using namespace std;

const int KILL_COUNT = 9;

// Makes a string consisting of only '_' with same length
string make_display_word(string s)
{
  string t = "";
  for (int i = 0; i < s.size(); i++)
    t += '_';
  return t;
}

// return true if char ch is in string s
bool ch_in_string(char ch, string s)
{
  for (int i=0; i < s.size(); i++)
    if (ch == s[i])
      return true;
  return false;
}

// enter ch into display at position where it appears
// in secret
void enter_char(char ch, string secret, string &display)
{
  for (int i = 0; i < secret.size(); i++) {
    if (secret[i] == ch)
      display[i] = ch;
  }
}

int main()
{
  // The word to guess
  string secret_word = "superposition";

  // How many wrong guesses
  int wrong_count = 0;

  string display_word = make_display_word(secret_word);
  string already_guessed = "";

  while (true) {
    cout << "\nYour guess so far: " << display_word
        << "\nWrong guesses: " << wrong_count
        << "  Letters guessed: " << already_guessed
        << endl;
    if (display_word == secret_word) {
      cout << "You got it!\n";
      exit(0);
    }
    if (wrong_count >= KILL_COUNT) {
      cout << "You are dead!\n";
      exit(0);
    }
    cout << "\nGuess a letter: ";
    char ch;
    cin >> ch;
    ch = tolower(ch);
    if (!isalpha(ch)) {
      cout << "Only letters!\n\n";
    } else {
      if (ch_in_string(ch, already_guessed)) {
        cout << "You already guessed '" << ch << "'\n";
      } else {
        already_guessed += ch;
        if (ch_in_string(ch, secret_word)) {
          enter_char(ch, secret_word, display_word);
        } else {
          cout << "Sorry, wrong guess!\n";
          wrong_count++;
       
      }
        }
        }
  }
  return 0;
}

---

Well, how you want to improve the program's interface is largely up to you. You could store a file of words, delimited by whitespace, then read each word using fscanf (be sure to specify a character limit in case someone tampers with the file to cause a buffer overflow) and pick a random one.

Alternatively, you could store each word using a fixed number of characters (not a problem unless you have several long words), possibly padding shorter words with whitespace (so you can use words of different lengths). Then you just generate a random number, seek to that position in the file and read it in.

Code:

---


make_display_word may exhibit ndefined behaviour because it returns a copy of a local variable. You can deprecate this function by using a string constructor to initialise the display word string.

http://www.cppreference.com/cppstring

string display_word(secret_word.length(), '_');


Deprecate ch_in_string by using the std::string::find method.

if (already_guessed.find(ch, 0) != std::string::npos)
{
    // do stuff
}


You can use std::string API to deprecate enter_char aswell.

Regards string the words to file. You might consider parsing the strem content using an ifstream (or relative) into a string and then tokenising that string using std::string::substr.
Something like....

size_type start=0;
size_type end=0;
vector<string> words;

const string DELIM(" ");

while (start != string::npos)
{
  end=myString.find(DELIM, start);
  std::string mySubStr=myString.substr(start, end);
  words.push_back(mySubStr);
  start=end;
}



Off the top of my head. I haven't compiled it, but I hope it helps...

---

You'll also need to include <vector> to use vectors.