Sorting two lists into one?

Hello I must merge two text files which contain a variable number of numbers. Both of these text files are sorted from lowest to highest value and when they are merged into one list must retain this property.

My friend and I were working on developing code for this but we have no idea if this is right. This is what we have so far...

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <sstream>
#include <cstdlib>
#include <vector>
#include <list>

int main(int argc, char argv[])
{

using namespace std;

ifstream in_stream1;
ofstream out_stream;
ifstream in_stream2;

in_stream1.open("prob2list1.txt");
in_stream2.open("prob2list2.txt");
out_stream.open("prob2merged.txt");

int num1;
int num2;
int i;
int j;

int mergeList[10000];


while(in_stream1.eof!=0)
{
in_stream1>>num1;
mergeList[i]= num1;
i++;
}

while(j<i)
{
in_stream2>>num2;
if(mergeList[j]>num2)
j++;
else
{
if(j==0)
{
mergeList.insert(j,1);
mergeList[0]=num2;
}
else
{
mergeList.insert(j,1);
mergeList[j-1]=num2;
}
j++;
}
}

return 0;
}

---

We're really quite confused and so we just tried to sort if using a really,really large array but when we try to compile it we receive these errors:

Line 30 - Error:Invalid use of member<did you forget the &?>
Line 46 - Error:Request for member 'insert' in 'mergeList', which is of non-class type 'int[10000]'
Line 51 - Error:Request for member 'insert' in 'mergeList', which is of non-class type 'int[10000]'

I know this code probably won't do the job in the first place and so any assistance would be greatly appreciated,thanks.

I'm quite new at this so please excuse any errors.

Whoa, why do you need a Ten THOUSAND element array if you are using lists and vectors! Just read both files into the list and then sort the list.

Or you can read the first value you of both files, which ever is the lowest/highest (depending on the sort order in the files) you put into your list first, then read a new value from that file and compare again untill you hit EOF in one file, then write the rest of it to your list.

Or you can skip the list and write directly to the output file.

Thanks for your suggestions,I'll try working on them tomorrow morning and I'll tell you how they go.

If we wanted to do the exact same thing as the above but this time sort a list of a KNOWN size(say 1000 numbers in each file),could we use a bubble sort function to do so?

We have this code...

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <sstream>
#include <cstdlib>
#include <vector>
#include <list>

int main( )
{

  using namespace std;
 
  ifstream in_stream1;
  ofstream out_stream;
  ifstream in_stream2;

  in_stream1.open("prob2list1.txt");
  in_stream2.open("prob2list2.txt");
  out_stream.open("prob2merged.txt");
 
  int numbers[2000];
  int array_size;
  int num;
  int i,j;

    while(i<2000)
    {
      in_stream1>>num;
      numbers[i]=num;
      i++;
    }
 

  void bubbleSort(int numbers[], int array_size);
  {
  int i, j, temp;

  for (i = (array_size - 1); i >= 0; i--)
  {
    for (j = 1; j <= i; j++)
    {
      if (numbers[j-1] > numbers[j])
      {
        temp = numbers[j-1];
        numbers[j-1] = numbers[j];
        numbers[j] = temp;
      }
    }
  }
  }

  bubbleSort(numbers, 2000);

    while(j<2000)
      {
        numbers[j]=num;
        out_stream<<num<<"\n";
          }
 
  return 0;
 }

---

We only have one error and its this...

"undefined reference to 'bubbleSort<int*, int>'
collect2: ld returned 1 exit status"


I have never seen this error before,whats up?

You can't define a function -- in this case bubbleSort() -- within another function -- also in this case, main().

Incidentally, this is a programming assignment, correct?

If you have two sorted lists or vectors, you might be able to use std::merge or std::inplace_merge from the "algorithm" header to merge them.

To sort something, "algorithm" contains a std::sort function and this works with regular arrays too. It's usually a lot faster than bubble sort (except if the array is already sorted, bubble sort would take O(n) time - if the algorithm also checks if the array is sorted.

Quote:

---

Originally Posted by zx-1

You can't define a function -- in this case bubbleSort() -- within another function -- also in this case, main().

Incidentally, this is a programming assignment, correct?

---

How would I go about solving this problem?

1. Grab your mouse and highlight everything from void bubbleSort(int numbers[], int array_size); down to its closing brace.
2. Press CTRL-X.
3. Move the cursor after the last closing brace of main().
4. Press CTRL-V.
5. Delete the trailing semicolon marked in red above.
6. Move the cursor in between #include <list> and int main().
7. Type void bubbleSort(int numbers[], int array_size);.

Alright so I did as you suggested and it compiled just fine but when I ran it it created the output file but the file size was increasing at an astronomical rate(when it crashed it was at 300mb). Is this an infinite loop of some sort?

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <sstream>
#include <cstdlib>
#include <vector>
#include <list>
void bubbleSort(int numbers[], int array_size);

int main( )
{

  using namespace std;
 
  ifstream in_stream1;
  ofstream out_stream;
  ifstream in_stream2;

  in_stream1.open("prob2list1.txt");
  in_stream2.open("prob2list2.txt");
  out_stream.open("prob2merged.txt");
 
  int numbers[2000];
  int array_size;
  int num;
  int i,j;

    while(i<2000)
    {
      in_stream1>>num;
      numbers[i]=num;
      i++;
    }
 

bubbleSort(numbers, 2000);

    while(j<2000)
      {
        numbers[j]=num;
        out_stream<<num<<"\n";
          }

 
 



 
  return 0;
 }


void bubbleSort(int numbers[], int array_size)
  {
  int i, j, temp;

  for (i = (array_size - 1); i >= 0; i--)
  {
    for (j = 1; j <= i; j++)
    {
      if (numbers[j-1] > numbers[j])
      {
        temp = numbers[j-1];
        numbers[j-1] = numbers[j];
        numbers[j] = temp;
      }
    }
  }
}

---

See your second while loop.

And you are using i and j uninitialized.

And bubble sort is going to yield horrendous performance if the files have any size to them, but no need to worry about that just yet.