File creating with string for name

I am trying to make a text editor using console and char array[100] strings.

If this isn't possible, tell me now :D My error code is as follows:

Code:

---

    char fileName[100];
    cout << "What do you want you're .editor to be today?\n";
    cin.getline ( fileName, 100, ' ');
    ofstream file(fileName ".editor");

---

The compiler error is 'expected ) before string constant'

Is it possible to use c style strings in this case?

I'd do it like this -

Code:

---

std::string NameOfFile;
std::cout<< "What do you want to call it: ";
std::cin >> NameOfFile;

// or std::getline( cin, NameOfFile );

ofstream out ( (NameOfFile + ".editor").c_str() );

// do stuff

out.close();

---

Yours doesn't work because

>> (fileName ".editor");

doesn't work. If you wish to remain with c style strings, instead of std::strings, use strcpy(), or strcat() or something. std::strings .c_str() returns a const char*, so it can be used for all sorts of things. They're great, research them, and you'll never use char*'s when there's a choice of use, IMO.

Quote:

---

ofstream file(fileName ".editor");

---

I don't think this is legal
Try using strncat to append ".editor" to the end of filename, then try

Code:

---

ofstream file(filename);

---

or you can use strings instead of char arrays and just add the ".editor" to the end of the filename.

>ofstream file(fileName ".editor");
There's nothing between fileName and ".editor", which in this case is a syntax error. C-style strings are harder to work with. If you were using C++ strings then the fix would be as simple as:

Code:

---

ofstream file((fileName + ".editor").c_str());

---

But as it is, you need to concatenate ".editor" onto the end of fileName using something like strcat:

Code:

---

#include <cstring>

// ...

char fileName[100];

cout << "What do you want you're .editor to be today?\n";

// Leave room for the extension
if (cin.getline (fileName, 93, ' ')) {
  strcat(fileName, ".editor");

  ofstream file(fileName);

  // ...
}

---

Ok, thanks. I was just using C style because I didn't know how to get input to C++ style strings

Heh

#include <string>

:p

Code:

---

#include <string>
#include <iostream>

using namespace std;

int main() {
    string str;
    cout<<"Enter a string : ";
    getline(cin, str);
    cout<<"\n" <<str;
    cin.get();
    return 0;
}

---

>> cout"\n" <<str;

Change to - cout << "\n" <<str;

And the use of code tags is always good!

dang, I thought I edited that fast enough so no one would notice:p

[Offtopic] That's why a code tag button would be good for the quick reply!! [/offtopic]

Still forgot the << :p

EDIT - Whoops, just edited in. heh.

Okay, there is another problem I don't know how to solve.

I use a while loop to dictate wether to continue asking the user for input, or end at their request. If they type the number 1, the loop stops and the file is closed, program ends. The problem is that 1 is still sent to the file. Here is the loop:

Code:

---

while(toFile != "1")
    {
    cout << "Type in your text, pressing 'enter' when finished with the line (typing 1 will end the loop and close your file): \n";
    getline(cin, toFile);
    out << toFile;
    }

---

Are you using CStrings or std strings? If it's C strings, you'll need to use strcmp()

You need a conditional statment to test if ToFile is a '1' or not, maybe something like this

Code:

---

while (true) {
    cout << "Type in your text, pressing 'enter' when finished with the line (typing 1 will end the loop and close your file): \n";
    getline(cin, toFile);
    if (toFile != "1")
        out << toFile;
    else
        break;
}

---

Std strings. I fixed it with an if statment before the line that prints to the file, though.

EDIT: Typing the code tags in Quick Reply doesn't work ?