Whats wrong with this statement?

The following statement compiles perfectly with g++.
But the sun compiler gives me a warning:
"Warning: String literal converted to char* in initialization."

char *bstr =
"ABCDEFGHIJKLMNOPQ"
"RSTUVWXYZabcdefgh"
"ijklmnopqrstuvwxy"
"z0123456789+/";

What is the meaning of this warning? Isnt this statement legal?
Is it not as per coding standards?

Thanks.
lawina

That's a strange way to init a string literal but I honestly don't know if it is dangeous or "incorrect" why not be safe and just make it one long string

Change char *bstr to char bstr[], or better yet string bstr(/* string literal*/);

"strings" are const, so perhaps it's really moaning about the loss of const in the assignment.

So perhaps
const char *bstr = "foo";

I believe that is because a string literal is a const char*, so you should declare the null terminated string const char* as well.

There is not absolutely nothing to worry. String literals in C/C++ are always null terminated char* const. Two continius string literals concaternated in one "ABC" "DEF" -> "ABCDEF"
Maybe your compiler considers it const char* const. See combilers documentation about this message.

Quote:

---

String literals in C/C++ are always null terminated char* const

---

Did a check of the C++ Standard, and in section 2.13.4, it states:
"An ordinary string literal has type "array of n const char" and static storage duration, where n is the size of the string as defined below, and is initialized with the given characters."

The "as defined below" part is:
"The size of a wide string literal is the total number of escape sequences, universal-character-names, and other characters, plus one for the terminating L'\0'. The size of a narrow string literal is the total number of escape sequences and other characters, plus at least one for the multibyte encoding of each universal-character-name, plus one for the terminating '\0'."

From what I understand, a const char[n] array decays to a const char* pointer, not a char* const pointer.

I managed to get a similar warning using g++ with the option -Wwrite-strings:

$ g++ -o test1 test1.cc -Wwrite-strings

In function `int main()':
warning: deprecated conversion from string constant to `char*'

Thanks for all the replies.
Lawina