I simple little problem but i cant figure it out

alright my code works perfectly and it runs but my only problem is that whether or not i input the proper responce it always does the else statement

Code:

---

void Character::Command()
{
    cout<<"\n";
    cout<<"Your Turn\n";
    cin>>command;
    cin.ignore();
    if(command=="Attack"||command=="attack"){Character::Attack();}
    else if(command=="Skill"||command=="skill"){Character::Skill();}
    else if(command=="Magic"||command=="magic"){Character::Magic();}
    else if(command=="Summon"||command=="summon"){Character::Summon();}
    else if(command=="Item"||command=="item"){Character::Item();}
    else{cout<<"(I don't think I should do that.)\n";Character::Command();}
}

---

whats my problem?

If needed I can add the full program so you can look at it all

nevermind i fixed it but now it doesnt do something else its supposed to do

I replaced the calls to member functions with couts and it worked fine for me....

[edit]What did you fix? What is it doing that it shouldn't[/edit]

what did you do??
I just put string command; and it fixed that problem i post the new problem in a sec

Quote:

---

Originally Posted by Decrypt

I replaced the calls to member functions with couts and it worked fine for me....

[edit]What did you fix? What is it doing that it shouldn't[/edit]

---

ok i fixed it thanks everything works now i just need to integrate the random so everything will make sence and not be pointless

oops, I forgot I declared command, too. I figured you had it elsewhere since it shouldn't compile without it....

Do you have another string named command valid in that scope? If so, you should change the name one of them.

no i have char command[15]; which is what i was using as the string but appearntly it wasnt working so do I still need it?

Quote:

---

Originally Posted by SebastionV3

no i have char command[15]; which is what i was using as the string but appearntly it wasnt working so do I still need it?

---

Apparently not. The string container overloads the equality operator (==) to work as you were using it. If command is made to be a character array however, what you end up doing in that code fragment is trying to compare the address of the first array element with the address of those various string literals which are NEVER going to be equal... hence the else statement always being executed.

In addition to what the above poster said, you also might want to transform the user's command to lower-case or something so that you have less comparisons to make. Here's an example.

Code:

---

#include <algorithm>
#include <cctype>
#include <iostream>
#include <string>

int main(int argc, char *argv[])
{
    std::string s("sTRIng to LowEr CAse");
    std::cout << s <<"\n";
    std::transform(s.begin(), s.end(), s.begin(), ::tolower);
    std::cout << s <<"\n";
    return 0;
}

---