deleting arrays

Hi,
I am creating a 2D array. 1 Array will contain pointers to integer arrays.

Code:

---

idArray = new int *[numberOfNodes*2];/*Create array of pointers to the x and y arrays of int*/

for(int i=0;i<numberOfNodes*2;i++) {
                        idArray[i] = new int[simulationTime*2];/*Create array of range and x position*/
                }

---

My question is how do I clean it up afterwards. Will doing a

delete idArray be enough to clean everything; both the memory allocated for idArray and new int[simulationTime*2]. Thanks
Amish

delete in the opposite order that they were allocated.

Code:

---

for(int i=0;i<numberOfNodes*2;i++) {
                delete[] idArray[i];
}
delete[] idArray;

---

>> delete[] idArray[i];

do you need to have the "[]" before the idArray if it's not a whole array you want to delete, like if it's only a certain element of the array?? I thought that was for the entire array ...

It so happens that each element of the array in question is in fact an array, since the array is a 2D array.

Quote:

---

Originally Posted by twomers

>> delete[] idArray[i];

do you need to have the "[]" before the idArray if it's not a whole array you want to delete, like if it's only a certain element of the array?? I thought that was for the entire array ...

---

as previously mentioned, whenever you use new[] you have to use delete[]. idArray[i] is an array that was allocated with new[]

>>is that deleting an element of the array?

which array -- idArray itself is an array of pointers to integers. Each element of idArray is an array of integers. delete[] idArray[i] is deleteing the ith array of integers.

cool thanks.
Amish

Hi,
I got some major error from the debugger of ms vs 2005 with this code:

Code:

---

int **idArray; /*This array contains the pointer to the x and y arrays*/
int **rangeArray; /*This array contains the range*/

idArray = new int *[numberOfNodes*2];/*Create array of pointers to the x and y arrays of int*/
memset(idArray,0,sizeof(int *)*(numberOfNodes*2));

rangeArray = new int *[numberOfNodes];/*Create array of pointers to the range of the nodes*/
memset(rangeArray,0,sizeof(int *)*(numberOfNodes));

for(int i=0;i<numberOfNodes*2;i++) {
  idArray[i] = new int[simulationTime];/*Create arrays of x and y position*/
  memset(idArray[i],0,sizeof(int)*(simulationTime));
}
               
for(int i=0;i<numberOfNodes;i++) {
  rangeArray[i] = new int[simulationTime];/*Create arrays of range*/
  memset(rangeArray[i],0,sizeof(int)*(simulationTime));
}

*(rangeArray[(currentId+2)/2 - 1]+counter) = range; /*Put the rage in for the time interval*/

*(idArray[currentId]+counter) =  (int) (subInt*cos((direction-0)*PI/180) + *(idArray[currentId]+counter-1)); /*Puts in the x position*/


*(idArray[currentId+1]+counter) = (int) (subInt*sin((direction-0)*PI/180) + *(idArray[currentId+1]+counter-1)); /*Puts in the y position*/

counter++;

---

The code is basically calculating position and range for different times. CurrentId is always less that numberOfNodes, counter does not go beyond simulationTime.

To delete the arrays, I used this code:

Code:

---

if(rangeArray != NULL) {
               
 for(int i=0;i<numberOfNodes;i++) {
  delete[] rangeArray[i];
 }
       
 delete[] rangeArray;
 rangeArray = NULL;
}

if(idArray != NULL) {
 for(int i=0;i<numberOfNodes*2;i++) {
  delete[] idArray[i];
 }

 delete[] idArray;
 idArray = NULL;
}

---

Whenever the debugger hits the line delete[] rangeArray[i]; I get the following error:
Debug error
program ...
HEAP CORRUPTION DETECTED: after normal block (#128) at 0x003682F0. CRT detected that the application wrote to memory after end of heap buffer.

I am completely confused. I thought memory was being deallocated at this point. So the program should not be writing any additional stuff to the heap. Hopefully somebody can point me in the right direction for this. Thanks
Amish

Code:

---

delete[] idArray[i];

---

Unless idarray is a three dimensional array, which it isn't, you should use this instead:

Code:

---

delete idArray[i];

---

delete[] is only for arrays.

Quote:

---

Originally Posted by dwks

Code:

---

delete[] idArray[i];

---

Unless idarray is a three dimensional array, which it isn't, you should use this instead:

Code:

---

delete idArray[i];

---

delete[] is only for arrays.

---

idArray is a 2D array so it would make sense to delete the array in one of the dimensions and then delete the array in the second dimension. idArray[i] is in fact an array and not just an element. OR am I wrong. Thanks
Amish

Quote:

---

Originally Posted by dwks

Code:

---

delete[] idArray[i];

---

Unless idarray is a three dimensional array, which it isn't, you should use this instead:

Code:

---

delete idArray[i];

---

delete[] is only for arrays.

---

But ... idArray[i] was allocated with new[], so delete[] would be correct. there could be some other unrelated problem in program, such as index out-of-bounds.

Your delete code is correct.

>> CRT detected that the application wrote to memory after end of heap buffer.

In other words, at some you wrote past the end of your array, probably the rangeArray. Try checking the indexes that are used with these arrays. Make sure they are less than (not equal to) simulationTime for the inner arrays, less than numberOfNodes for the rangeArray, and less than numberOfNodes*2 for the idArray. Use the debugger or output statements, or add an assert on the code you are using to get the indexes.

For example: assert(((currentId+2)/2 - 1) < numberOfNodes);

or assert(counter < simulationTime);

An array out of bounds was causing the problem. I was using a for loop with i=0;i<=somenumber;i++
It should have been i<somenumber. Well the debug version of this program works now. Now time to go see if the release is gonna f...k up :) Thanks everybody
Amish