Needing assistance with pointers

Hey, I'm trying to break in to my OWN computer so I can make it more secure and develop skills but I am getting confused with pointers...

Code:

---

#include <iostream>
#include <windows.h>
#define cmd.exe "C;\windows\system32\cmd.exe"
using namespace std;
int main()
{
    char *Input[128];
    char Command[128];
    Input=&Command;
    cin>>Command;
    cout<<*Input;
    Command="MSG.exe * Hi";
    system("cmd.exe"+" "+Command);


}

---

Is there also any other way I can substitute system() for winexec()?

i don't know abt the later half of ur code , but u can improve the first half quite a lot ..

Code:

---

#include <iostream.h>
#include <stdio.h>
using namespace std;
int main(){
    char Command[128];
    cin.get(Command,128);
    cout<<Command;
    return 0;
}

---

You don't need to use pointer there. Your program will not even compile. You should do it this way:

Code:

---

#include <iostream>
#include <cstdlib>
using namespace std;
int main()
{
        char input[128];
        cout<<"Enter command> ";
        cin>>input;
        system(input);
        return 0;
}

---

agarwaga, it's great that you know about the std namespace, but it really doesn't help to use it if you aren't using libraries that are defined under that namespace. <iostream.h> should be <iostream>, <stdio.h> should be <cstdio>, and siavoshkc, <stdlib.h> should be <cstdlib>

i am returning back to C++ after quite some time ...

i want to use pointers though, yes their is an easier way of doing it, but i am not challenged from that

With pointer:

Code:

---

#include <iostream>
#include <cstdlib>
using namespace std;
int main()
{
        char input[128];
        char* ptr=&input[0];
        cout<<"Enter command> ";
        cin>>ptr;
        system(ptr);
        return 0;
}

---

Or better:

Code:

---

int main()
{
          char *ptr = new char[128];
          cout<<"Enter command> ";
          cin>>ptr;
          system(ptr);
          return 0;
}

---

Quote:

---

Originally Posted by siavoshkc

With pointer:

Code:

---

#include <iostream>
#include <cstdlib>
using namespace std;
int main()
{
        char input[128];
        char* ptr=&input[0];
        cout<<"Enter command> ";
        cin>>ptr;
        system(ptr);
        return 0;
}

---

Or better:

Code:

---

int main()
{
          char *ptr = new char[128];
          cout<<"Enter command> ";
          cin>>ptr;
          system(ptr);
          return 0;
}

---

---

better still

Code:

---

#include <iostream>
#include <string>
#include <cstdlib>
using namespace std;
int main()
{
        string input;
        cout<<"Enter command> ";
        cin>>input;
        system(input.c_str());
        return 0;
}

---

Try using pointers, ChaosEngine.

Quote:

---

Originally Posted by siavoshkc

Try using pointers, ChaosEngine.

---

No. Pointers are completely unneccessary for this task. Anytime you can avoid them, you should. C++ provides several features (references, auto_ptr, vector, string) to avoid using pointers, which are notoriously error-prone.

Learn to use them.

Yes, but starter of the thread wants to practice pointers I think. Look at the posts before sending new one please.

Quote:

---

i want to use pointers though, yes their is an easier way of doing it, but i am not challenged from that

---

I believe there are better ways to learn pointers than the problem given :) For example, the OP could learn pointers by creating his own linked list (something which inevitably all programmers end up doing at least once in their lives)

I agree. pointer should be used in its own place, minimum required.

Quote:

---

Originally Posted by bikr692002

Hey, I'm trying to break in to my OWN computer so I can make it more secure and develop skills but I am getting confused with pointers...

Code:

---

#include <iostream>
#include <windows.h>
#define cmd.exe "C;\windows\system32\cmd.exe" // improper format 1
using namespace std;
int main()
{
    char *Input[128];  // problem #2
    char Command[128];
    Input=&Command;
    cin>>Command;
    cout<<*Input;
    Command="MSG.exe * Hi";
    system("cmd.exe"+" "+Command);  // problem #3


}

---

Is there also any other way I can substitute system() for winexec()?

---

#1
#define cmd.exe "C;\windows\system32\cmd.exe"
the . is illegal, cmd is not a structure
the ; should be :
each \ should be \\

#2
char *Input[128];
why create 128 pointers? simply
char *Input;
should suffice.

#3
system("cmd.exe"+" "+Command);
character arrays cannot be added. Use strcat() to combine them then call the function.

Other errors can be fixed after these, unless everyone else has pulled you away from fixing your original project.

There are more errors than those.

siavoshkc, your program has a memory leak. you did not delete your dynamically allocated memory. you should definitely stick with the standard string class for this kind of task, like ChaosEngine said.
sure it's more of a challenge to use pointers, but it's even MORE of a challenge debugging your memory leaks when you start to have problems...

I didn't want to use pointers. Look at my first code.

Here it is so far, got one error now :(

Code:

---

#include <iostream>
#include <windows.h>

using namespace std;
int main()
{
    char *Input;
    char Command[64];
    Input=&Command;
    cin>>Command;
    cout<<*Input; 
    WinExec(Command, 1);
}

---

Oh yeah why do I have to put the number in the WinExec, does it matter what the number is?

I dont think char needs refrence operators...

Code:

---

#include <iostream>
#include <windows.h>

using namespace std;
int main()
{
    char *Input;
    char Command[64];

    Input = Command;

    cin >> Command;
    cout << Input;

    WinExec(Command, SW_SHOW);
}

---

The number is a nCmdShow parameter, the same as those you would pass to ShowWindow(..)