trun string input into if output

Hi, I need help on some colde, when I type anything in it just prints out "hi" when the input wasnt "hi" ~> so on.

Code:

---

#include "tt.h"

using namespace std;

int main()
{
string say;

cout << "Naby-> Hi, my name is Naby." <<endl;
getline(cin, say);
    if(say == "HI"||"Hi"||"hi"||"Hello"||"hello"||"HOLA"||"Hola"||"hola")
        cout<<"Naby-> Hi"<<endl;
    else if(say == "Play music for me")
        mciSendString ( "Play CL.mp3", 0, 0, 0 );
    else
        cout<<"Naby-> Finde don't talk with me"<<endl;
        getchar();
}

---

Code:

---

if(say == "HI"||"Hi"||"hi"||"Hello"||"hello"||"HOLA"||"Hola"||"hola")

---

"Hola"||"hola" etc is always true. Compare say with each individually.

So I should show them individually?

Code:

---

else if(say = bla bla)

---

He means like this:

Code:

---

if(say == "Hi" || say == "Hola")

---

Just the word "Hola" is as good as saying not zero... which is true.

Oh ok, I get it now, Thanks all.

you may want to look into creating something to capitalize your input to help you out...

Code:

---

#include <iostream>
#include <cstring>

char*capitalize(char*in);        //warning: this changes the input string

int main()
{
        char*buffer=new char[1024];

        std::cout<<"Enter a word: ";
        std::cin.getline(buffer,1024,'\n');
       
        if(!strcmp(capitalize(buffer),"HELLO"))
        {
                std::cout<<"Why Hello There";
        }
        else
        {
                std::cout<<"No Hello first?";
        }
       
        std::cout<<std::endl;
        delete[]buffer;
        return 0;
}

char*capitalize(char*in)
{
        short int len=strlen(in);
        for(register short int i=0;i<len;i++)
        {
                in[i]=toupper(in[i]);
        }
        return in;
}

---

This is using char*'s, but it'd be a quick easy change to convert it to stl strings.

toupper() is in <cctype>, not <cstring>.

And adr, getchar() is a C function, in <cstdio>. I don't know if you've included this or not since you didn't post tt.h.

[edit]

Code:

---

short int len=strlen(in);

---

And strlen() returns a size_t. I think size_t is typedefed in <cstdio> or <cstddef>.
[/edit]

well, strlen is from <cstring>, and if it returns a type, that type must have been defined, so therefore if you've included strlen(), you must have indirectly included size_t as well ;)

Yes, but the fact remains that you tried to stuff a size_t into a short int. :)