string object problem

hello guys,
i got small problem with my code can any check that cout for me please.

this is skeleton of my structure

Code:

---

struct emp
{
    string type;
    int empid;
    string surname;
    string firstname;
};

struct manag
{
    struct emp details;
    struct manag *left;
    int empno;
    int *empid;
    struct manag *right;
    struct tech *tec;
    struct admin *admi;
};

---

and this is one of the fucntion where actaully i an using this struct

Code:

---

void inserttree(string str)
{
    char *p,*q;
   
   
    p=(char *)str.c_str();
   
    if((q=strtok(p," "))!=NULL)
    {
        if(strcmp(p,"manager")==0)
        {
            struct manag *manag;
            manag->details.type += q;
            cout<<manag->details.type<<endl;
            cin.get();
    }
           
    }
}

---

does any one find anything wrong with this code. i am just getting the first work from the string and copy that string into my struct. but when i run this code it just give an runtime error. i belive that its soemhting to do with the string which i am copying. can any one check that out for me please

ssharihs2005

> p=(char *)str.c_str();
c_str() is supposed to be a const char *, so removing the const with a cast, and then trashing the string using strtok() is generally a bad idea.

Yeah strtok() is evil it modifies the passed string.
You cast away the constness of string.c_str(). It gets modified ->boom
Kurt

right thax very much, so is there any better way of doing that and i think it's better to go with the normal string char * :rolleyes:

ssharish2005

>> so is there any better way of doing that and i think it's better to go with the normal string char *
shure there is. use a stringstream e.g.

Code:

---

void inserttree(string str)
{
    stringstream sstr(str);
    string manager;
    sstr >> manager;
    if ( manager == "manager" ) {
      string add;
      sstr >> add; // if add can contain spaces you could use getline()
      struct manag *manag; // you should allocate a manag struct here
      manag->details.type += add;    // this I don't understand
      cout<<manag->details.type<<endl;
      cin.get(); // ???   
    }
    // ....
}

---

Kurt

thax ZuK for the solution. i got this problem check out this

Code:

---

#include<iostream>
#include<cstring>

using namespace std;

struct emp
{
    char type[25];
    int empid;
    char surname[25];
    char firstname[25];
};

struct manag
{
    struct manag *lef;
    struct manag *right;
    struct tech *tec;
    struct admin *admi;
    struct emp details;
    int empno;
    int *empid;
   
};

int main()
{
    struct manag *man;
    char *p="helloword";
   
    strcpy(man->details.type,p);
   
    cout<<man->details.type<<endl;
   
    cin.get();
}

---

why dons't this print me the string. it gives Seg Fault.

ssharish2005

You don't allocate anything for man

Code:

---

int main() {
    // struct manag *man;    // C++ doesn't need struct here
    manag *man = new manag;  // allocate
    char *p="helloword";
   
    // strcpy(man->details.type,p); // wrong man->details.type is a std::string
    man->details.type=p;            // there is an assignement operator for string
    cout<<man->details.type<<endl;
   
    cin.get();
}

---

This should work

Quote:

---

Originally Posted by ZuK

man->details.type=p; // there is an assignement operator for string

---

well, this dont work Zuk as i have declared a type as char string thats is

Code:

---

char type[25];

---

when i do it like what u say i will an error like incompatiable assigment.

ssharish2005

not to worry i solved the problem, any way thax for all your help

ssharish2005