Help with my Questionaire Program

hii guys, i am new to c++ and i wrote this basic program but i cant seem to make it work right. Here is the code:-

Code:

---

// questionaire.cpp

#include <iostream>
#include <string.h>
using namespace std;
const int ANS = 80;


int main()
      {
     
      char choice = 'x';
      char Answer[ANS];
     
     
      cout << "\nQ1. What is the capital of Turkey?";
      cout << "\n My Answer is:- ";
      cin >> Answer[ANS];
      if( Answer == "Ankara" || "ankara" )
      cout << "You got the right answer!";
      else
      cout << "The answer is wrong.";         
               
               
      cout << "\nQ2. What is the capital of Egypt?";
      cout << "\n My Answer is:- ";
      cin >> Answer[ANS];
      if( Answer == "Cairo" || "cairo")
      cout << "You got the right answer!";
      else
      cout << "The answer is wrong.";
     
     
      cout << "\nQ3. What is the capital of Iraq?";
      cout << "\n My Answer is:- ";
      cin >> Answer[ANS];
      if( Answer == "Baghdad" || "baghdad")
      cout << "You got the right answer!";
      else
      cout << "The answer is wrong.";

}

---

What i want it to do is make it go to the next question if the user types in the right answer, for example, if the person types "Ankara", or "ankara" for the first question it goes directly to the next question, or if the question is wrong, it says "please try again" and goes back to the question again. But after 3 tries and the user cannot answer the question, then it finally goes to the next. you guys understand me?? thanks a lot

Code:

---

      cout << "\nQ1. What is the capital of Turkey?";
      cout << "\n My Answer is:- ";
      cin.getline(Answer,ANS,'\n');
      if( Answer == "Ankara" || "ankara" )
      cout << "You got the right answer!";
      else
      cout << "The answer is wrong.";

---

Use cin.getline() for C-style strings.

Prototype: cin.getline(<variable>,<size of buffer>,<delimeter>)

...and this marks the third time I've had to answer this question tonight. :)

it still doesnt work. when i type in any word it still says "you got the right answer"

Oh I'm sorry, I didn't even look at the if statement.

Code:

---

if( Answer == "Ankara" || "ankara" )  // This is always true

if( Answer == "Ankara" || Answer == "ankara" ) // This is conditional

---

hey thanks for your help, it doesnt say "you got the right answer", now everytime i type something it keeps saying the answer is wrong. lol. could you please check it again :S

Did you change all your if() statements?

Post your latest code - we've no way of knowing what you've done to break it.

here is the code now:-

BTW i got a friend to help me fix it but i have a new problem..

Code:

---

// questionaire.cpp

#include <iostream>
#include <windows.h>
#include <string.h>
using namespace std;
const int ANS = 80;

void fullscreen()
{
keybd_event(VK_MENU,0x38,0,0);
keybd_event(VK_RETURN,0x1c,0,0);
keybd_event(VK_RETURN,0x1c,KEYEVENTF_KEYUP,0);
keybd_event(VK_MENU,0x38,KEYEVENTF_KEYUP,0);
}

class Questionaire
{
      public:
      void Showcreator()
      {
          cout << "        **********[QUESTIONAIRE 1.0 by aBz]**********                Score";
      }
      void Myansweris()
      {
          cout << "\n My Answer is:- ";
      }
      void Right()
      {
          cout << "\nCONGRATULATIONS! You got the right answer!";
          cout << "\nPress any key to proceed.";
          cin.ignore();
          system("cls");
      }
      void Wrong()
      {
          cout << "\nWRONG!!!";
          cout << "\nPress any key to try again.";
          cin.ignore();
          system("cls");
      }
};

int main()

{
     
      char choice = 'x';
      char Answer[ANS];
     
      Questionaire selection;
     
q1:
      selection.Showcreator();
      cout << "\n\nQ1. What is the capital of Turkey?";
      selection.Myansweris();
      cin.getline(Answer,ANS);
      if( strcmp(Answer,"Ankara") == 0 || strcmp(Answer,"ankara") == 0 )
          {
          selection.Right();
      }
          else
      {
                  selection.Wrong();                 
          goto q1;
          }
q2:
      selection.Showcreator();
      cout << "\n\nQ2. What is the capital of Egypt?";
      selection.Myansweris();
      cin.getline(Answer,ANS);
      if( strcmp(Answer,"Cairo") == 0 || strcmp(Answer,"cairo") == 0 )
          {
          selection.Right();
      }
          else
      {
                  selection.Wrong();         
                  goto q2;
          }
q3:
      selection.Showcreator();
      cout << "\n\nQ3. What is the capital of Iraq?";
      selection.Myansweris();
      cin.getline(Answer,ANS);
      if( strcmp(Answer,"Baghdad") == 0 || strcmp(Answer,"baghdad") == 0 )
      {
          selection.Right();
          }
      else
      {
                  selection.Wrong();       
          goto q3;
          }
         
}

---

I want to put in a basic score system. what code do i use to add integers to a variable?

Ah, sorry again. Didn't even notice you were using C style strings. :D I was a bit tired last night, me guesses.

Anyway, the score system should be easy to add, just ask your friend. I got turkey to eat.

If your friend said to use goto's, then you need a more knowledgeable friend.

lol well he helped me fix the score system as well now. Now i got 1 final problem. is there a way to make it so the questions come randomly? He said he couldnt help me with that..

Quote:

---

Originally Posted by danepporambo

lol well he helped me fix the score system as well now. Now i got 1 final problem. is there a way to make it so the questions come randomly? He said he couldnt help me with that..

---

Wow, I hate to see goto's used like that.

Since the purpose of using a class in your code is lost, I would.. Put the question and the answer strings in the class. Then make an array of instances and add the question/answer to each instance (well actually I wouldnt do that grunt work personally, I'd load them from a text file, but thats me). Then simply use rand() (seeded with srand) (thats your random part, you can find info on it in the FAQ) as the element of the array. You could then make a method in the class say called ask() and put the body of each question there, use the variable in the class for the question and answer, and in main() simply call selection[rand() % 3].ask(); or whatever amount of elements are in the array.

Note: if you did do this then you'd have a real purpose to using a class, and could add variables to flag if the person already answered the question, how long it took, how many guesses, the id of the question (use a static variable to keep track of the amount of instances), etc. You turn it into a linked list, with nodes, to give it extra functionality (search by id, or question name, part of the question, blah blah blah).

----------------------------------------

If thats not an option.. just call the rand() function and use that value in some if/if else statements that lead to the goto's. It may be the simplest way, but I wouldn't call it the best - at all.

Code:

---

int random = rand() % 3;
if(random == 1)
  goto q1;
else if(random == 2)
  goto q2;
else if(random == 3)
  goto q3;
else
  cout << "Sorry, question doesn't exist";

---

Alternatively you could use a switch statement and use rand to go to one of the cases, and use a while statement around the switch statement to go back to ask more questions. Usually theres an equally good or better way to do something with if/switch/while statements than using goto.

---------------------------------------

I would suggest to stop using c-style strings (char[]) and use the string object, and import <string> not <string.h>. Theres a good tutorial on the main site on how to use them, and its much easier than c-style strings.

rand() is in <cstdio>, and srand() is in <cstdlib>.

Try the FAQ here: http://faq.cprogramming.com/cgi-bin/...arch&match=all. There's also a page on it at Prelude's site: http://www.eternallyconfuzzled.com/articles/rand.html.

BTW, SlyMaelstrom, your avatar's down again. :) It must be hosted remotely.