Question about the System() function...

I am writing a program that acts like a shell. I used the System() function to compute the commands, however, I realized that exit and cd do not work. I figured out how to make my own exit, however, I cannot figure out how to get cd to work...if anyone could help that'd be great, I appreciate it in advance....here's my code...

Code:

---

#include <iostream>
#include <stdlib.h>
#include <string>


void main()
{
        char cmd[100] = " ";

        cout << "Please enter command: ";
        cin.getline(cmd, 100);

        while (strcmp (cmd, "exit") !=0)
                {

                        system (cmd);
                        cout << "Please enter command: ";
                        cin.getline(cmd,100);
                }
                exit(1);
}

---

this is the updated code...

Code:

---

#include <iostream>
#include <stdlib.h>
#include <string>
#include <unistd.h>

void main()
{
        char cmd[100] = " ";
        char * pch;

        cout << "Please enter command: ";
        cin.getline(cmd, 100);

        while (strcmp (cmd, "exit") !=0)
        {
                if((cmd[0] == "c") && (cmd[1] == "d"))
                {
                        pch = strtok(cmd," ");
                        pch = strtok(NULL," ");
                        chdir(pch);
                }
                else
                {
                        system (cmd);
                        cout << "Please enter command: ";
                        cin.getline(cmd,100);
                }
        }
        exit(1);
}

---

and there are the errors im recieving from my linux compiler

test.cpp:16: ISO C++ forbids comparison between pointer and integer
test.cpp:16: ISO C++ forbids comparison between pointer and integer

any ideas?

You're getting those errors because you're comparing a string (char pointer) and an int.

You should change the line that says

Code:

---

if((cmd[0] == "c") && (cmd[1] == "d")

---

to

Code:

---

if((cmd[0] == 'd') && (cmd[1] == 'd')

---

and there you go. No more warning, and a working piece of code.

Also, please change the return value of main to int. Void is just wrong (see the FAQ or search the forums for the reason(s)).

It might be better to fork() and then exec(), but that's a bit more complicated.

Im wondering why you wouldn't be getting errors with this, since cin and cout are in the std namespace, and I don't see a "using namespace std;" or any thing like that in your code. Also, its int main, not void.

He's probably using some very permissive compiler. My g++ erros out on void main().

Also, I suspect this is not the code verbatim, because the line where he's got the error and it's actual line in the code he posted are different.