randoming problem...

now i'm using the for loop things for my mastermind game,but.....it still got a randoming problem just like the first time i use with if else..

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <time.h>

int guess(int);

int main()
{

int digits;
srand((unsigned)time(NULL));
printf("\nWelcome To Mastermind!\n");
printf("How Much Digits Do You Want To Play:\n");
scanf("%d",&digits);
guess(digits);
return 0;

}

int guess(int code)
{
int get_random,get_guess,checking,checking2,right,place;
int guess_code[code-1];
int secret_code[code-1];

right = 0;
place = 0;

for(get_random=0;get_random<code;get_random++)
        {
                secret_code[get_random] = rand()%10;
                printf("%d",secret_code[get_random]);
        }
printf("\n I Have Made %d Digit For You To Guess..\n",code);

for(get_guess=0;get_guess<code;get_guess++)
{      printf("Guess #%d:",get_guess+1);
        scanf("%d",&guess_code[get_guess]);
}

for(checking=0;checking<code;checking++)
{
        if(secret_code[checking]==guess_code[checking])
        {
                right = right + 1;
                secret_code[checking] = -1;
        }
        for(checking2=0;checking2<code;checking2++)
        {
                if(secret_code[checking] == guess_code[checking2])
                {
                        place = place + 1;
                        secret_code[checking] = -1;
                }
        }
}

printf("\nYou have placing %d code at a right place and %d code at a wrong place..\n",right,place);

if(right==code)
{
        printf("\nCongratulations,You have won the game!!\n");
        return 0;
}
else
{
        guess(code);
}
}

---

this is what i do,anyone can help me?? :confused:

There are several syntax errors -- your compiler should have complained

Code:

---

int guess_code[code-1];
int secret_code[code-1];

---

arrays allocated like the above must use a const int value -- code is not a const int. When you need variable size of array, then use malloc() to allocate them, like this:

Code:

---

int* guess_code = malloc((code-1) * sizeof(int));
int* secret_code = malloc((code-1) * sizeof(int))

---

Quote:

---

Originally Posted by Ancient Dragon

There are several syntax errors -- your compiler should have complained

Code:

---

int guess_code[code-1];
int secret_code[code-1];

---

arrays allocated like the above must use a const int value -- code is not a const int.

---

Well according to new standard....these statements are valid...you can have non-const value like that

The standards may allow it, but does your compiler? VC++ 6.0 does not because it is older than the current standard by quite a few years. Dev-C++ probably will allow it.

Yes my compiler does...i am using dev c++ 4.9.9.2.....it conforms to most of the new standards....i have stopped using VC++6.0 compiler.....but the latest version of VC must be supporting it(though i haven't used them)

Quote:

---

Originally Posted by sunnypalsingh

Yes my compiler does...i am using dev c++ 4.9.9.2.....it conforms to most of the new standards....i have stopped using VC++6.0 compiler.....but the latest version of VC must be supporting it(though i haven't used them)

---

Your compiler is supporting because it is based on c99 where variable length arrays are allowed.Every compiler will not do that.You can use this if Code portability is not an issue for you.

I just tried it with VC++ .net 2003 -- not supprised that that M$ compiler doesn't like it either

I got it to compile using malloc() as I previously posted, and ran it with 5 digits. What exactly is the program doing that you think is wrong? The function guess() generates randon numbers between 0 and 9 just as you coded it. rand() does NOT guarantee UNIQUE numbers, just random ones. If you don't want duplicates, then you will have to add code to filter them out.

A good Mastermind game should allow duplicates. Otherwise the game is much easier.

frankly,my compiler is supporting the code,but when i get the wrong place number and looping to function guess,the random generator will create a new random number again..what can i do if i want the random generator just create one random number...

delete these lines

Code:

---

else
{
        guess(code);
}

---

i need to back to the guess function because if it has a wrong numbers,we must retype the guess number..