s(n)printf weird things happening...

Running code like this, weird things happen:

Code:

---

char SBD_FULL_PATH[1024];
/* a ways down */
printf("SFP1: %s\n",SBD_FULL_PATH);
snprintf(SBD_FULL_PATH,sizeof(SBD_FULL_PATH),
    "%s\\%s%s\"",SBD_FULL_PATH,argv[0],SBD_EXTENSION);
printf("SFP2: %s\n",SBD_FULL_PATH);
snprintf(SBD_FULL_PATH,sizeof(SBD_FULL_PATH),
    "\"%s",SBD_FULL_PATH);
printf("SFP3: %s\n",SBD_FULL_PATH);

---

Output:

Code:

---

SFP1: C:\folder
SFP2: C:\folder\file.txt"
SFP3: """""""""""""""""""

---

Is snprintf or _snprintf in Windows broken? (Yes, both functions output the same thing.) Using MinGW on Windows XP.

Can't see anything wrong, although one of your string literals has an extra \" at the end, which is producing this output:

Code:

---

SFP2: C:\folder\file.txt"

---

Is it possible for you to post the source code for a program that demonstrates the said problem? It would be easier for us to compile and test and see if snprintf is really broken.

Yes, I want to quote the string, so I broke what i was doing into parts.

Code:

---

#include <stdio.h>
#include <windows.h>

int main(int argc, char **argv)
{
        char str[1024];
        GetCurrentDirectory(sizeof(str),str);
        printf("Str1: %s\n",str);
        _snprintf(str,sizeof(str),"\"%s\\%s\"",str,argv[0]);
        printf("Str2: %s\n",str);
        return 0;
}

---

Sample output:

Code:

---

Str1: C:\folder
Str2: """"""""""\C:\folder\test.exe"

---

Well, perhaps your problem lies in using SBD_FULL_PATH as the output and input.

Code:

---

snprintf(SBD_FULL_PATH,sizeof(SBD_FULL_PATH),  "\"%s",SBD_FULL_PATH);

---

Yes, that's the problem, I wonder why that happens.

From the documentation

Quote:

---

Originally Posted by MSDN

If copying occurs between strings that overlap, the behavior is undefined.

---

SBD_FULL_PATH definitely overlaps SBD_FULL_PATH.