Fatal error in fprintf

Hi, im trying to write a bunch of strings into a text file which are received through the com port.

every so often though the program gives a fatal error and i get a dialog box which go's something like

Quote:

---

fatal error....

...

str != NULL

---

it points to line 56 of fprintf.c and says that an "assertion failure" was caused.

i think it might be because its trying to write a string when it hasnt received anything.

im using the code below to write my strings into the file

Code:

---

        fprintf(fp,"%s", decoded);

---

i have modified it so it doesnt continue when it cant write the string so my new code looks like

Code:

---

if((fprintf(fp, "\n") || fprintf( fp,"%s", decoded)) == EOF)
          {
                  printf("No string/String error");
          }
          else{                                       
                  fprintf(fp,"%s", decoded);
                  }

---

howver, its still giving me the same error after a few hours

Could someone tell me what the error is and what i might be doing wrong?

thanks

VC++ , windows XP

Quote:

---

Originally Posted by shoobsie

Code:

---

if((fprintf(fp, "\n") || fprintf( fp,"%s", decoded)) == EOF)
          {
                  printf("No string/String error");
          }
          else{                                       
                  fprintf(fp,"%s", decoded);
                  }

---

---

This code is horrible for multiple reasons:
1) In the if check, it writes out a newline. It also writes out decoded.
2) It takes the retrun value of both of those, and if either one is true (non-zero) it compares it to EOF. Read: It compares TRUE to EOF.
3) Then, it simply writes decoded again.
4) "No string/String error" will never display.

I suspect that if the rest of your code is in the same vein as this simple portion here, you'll be a while in tracking down your error.


Quzah.

hi, thanks for the reply.

what i thought i was doing there was comparing initially to see if the two strings had an error in them and if they did then the error message would be displayed.

otherwise, it would write the two strings down.

i see you are right since what you said is occuring, can you suggest a remedy for this section?

thanks

Check the return value of whatever is acquiring your strings for you. Typically these types of functions return something useful, such as the amount of data read or the like. Use that to see if your string contains something useful. In addition to that, consider using something like strlen to test the length of the string. If it's less than 1, or some other number you decide on for whatever reason, then treat it as a garbage string.


Quzah.

Quote:

---

Originally Posted by quzah

Check the return value of whatever is acquiring your strings for you. Typically these types of functions return something useful, such as the amount of data read or the like. Use that to see if your string contains something useful. In addition to that, consider using something like strlen to test the length of the string. If it's less than 1, or some other number you decide on for whatever reason, then treat it as a garbage string.


Quzah.

---

thanks alot :)