is there a better option to strlen()

It is my understanding that 'strlen()' is recursive and is not the most efficient way to derive the length of a string. Would it be better to just use the maximum size of the string instead? Is there a more efficient way to do this?

Code:

---


char buffer[15]

~ code
        for(int i=0; i<strlen(buffer);i++)
  { if(isdigit(buffer[i]==0)
        {cout<< "This is not a valid number";}
    }
   
// Or should I use

for(int i=0;i<15;i++)
  { if(isdigit(buffer[i])==0)
        {cout<< "This is not a valid number";}
    }

~ code

---

If possible (depends what you want to do with the string) use a std::string, which has it's own length() function. It probably works in a similar way to strlen() actually, but I don't know.

> It is my understanding that 'strlen()' is recursive
Then you are wrong - only the most lame-brained student exercise would make it recursive.

Your use of it however is very inefficient.

Try
for(int i=0;buffer[i] != '\0';i++)
If you want to step through a string.

You could just use a loop like:

Code:

---

for (int i=0;buffer[i];i++)
{
  //...
}

---

Thank you everyone.

I appreciate the help.

~Rich

Code:

---

int strlen(char *inp)
{
    char *p = inp;

    while(*p)
        p++;

    return p - inp;
}

---

there is no real better alternative to strlen, but it essentially does the same as the above code.

Quote:

---

Originally Posted by ahluka

If possible (depends what you want to do with the string) use a std::string, which has it's own length() function. It probably works in a similar way to strlen() actually, but I don't know.

---

It's not defined in the C++ standard, so it depends on implementation. Some implementations of std::string implement strings with a structure that keeps the size of the string, how much space is reserved for the string, a pointer to the buffer of characters, and some other information. For example, my copy of Visual Studio .NET 2003 uses 28 bytes for the std::string struct, and if you look at the memory, you can see the length of the string hard-coded. Then the .length() member function takes a constant amount of time, every time. Also, this makes push_back and += much more efficient.

But on the port of g++ that comes with Dev-C++ 5 Beta, the std::string class is simply a wrapper for a char *, which points to a nul-terminated array, so I imagine it would use strlen.

Quote:

---

Originally Posted by Rashakil Fol

But on the port of g++ that comes with Dev-C++ 5 Beta, the std::string class is simply a wrapper for a char *, which points to a nul-terminated array, so I imagine it would use strlen.

---

Excuse me, this information is incorrect. The std::string class's content consisted of exactly one pointer, and it did indeed point to an array of characters. But the size of and amount of space allocated for the string could be found if you backed up this pointer eight and twelve bytes.

Quote:

---

Originally Posted by Rashakil Fol

But the size of and amount of space allocated for the string could be found if you backed up this pointer eight and twelve bytes.

---

Aye, that's almost my suggestion for the OP. Use Pascal strings, not null-terminanted strings.