Bug in my barely-started text-based game program

Here's the code, explanation of what's wrong at the moment at the bottom.

Code:

---

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main () {
    string select;
   
    cout << "Welcome to Link's Grand Quest!\n";
    cout << "Select an option:" << endl << endl;
    cout << "Create Character (press c)\n";
    cout << "Load Character (press l)\n";
    cout << "Creator (press r)\n";
    cout << "Exit (press e)\n";
    cin.ignore(80, '\n');
    cin >> select;
    if (select == "c" || select == "C") {
              cout << "I'm sorry, this feature is not available yet";
    }
    else if (select == "l" || select == "L") {
        cout << "I'm sorry, this feature is not available yet";
    }
    else if (select == "r" || select == "R") {
        cout << "I'm sorry, this feature is not available yet";
    }
    else if (select == "e" || select == "E") {
    }
    else {
//        while (select != "c" || select != "C" || select != "l" || select != "L" || select != "r" || select != "R" || select != "e" || select != "E") {
//              cout << "I'm sorry, you did not select an option. Please select from below:\n\n";
//              cout << "Create Character (press c)\n";
//              cout << "Load Character (press l)\n";
//              cout << "Creator (press r)\n";
//              cout << "Exit (press e)\n";
//              cin >> select;
//              if (select == "c" || select == "C") {
//                          cout << "I'm sorry, this feature is not available yet";
//              }
//              else if (select == "l" || select == "L") {
//                    cout << "I'm sorry, this feature is not available yet";
//              }
//              else if (select == "r" || select == "R") {
//                    cout << "I'm sorry, this feature is not available yet";
//              }
//              else if (select == "e" || select == "E") {
//                    cout << "I'm sorry, this feature is not available yet";
//              }
//              else {
//              }
//        }
    }
    cin.get();
}

---

I commented out the parts I don't want running in the program for now, and the bug still exists, so I know the bug resides somewhere in the first cin >> select;'s area. When I type "c", it doesn't output a single thing, and you have to input something else (although enters don't seem to work) to get the program to close after that point. No matter what I use on cin >> select;, it does this. Any help?

Scratch that, it requires two of typing the same selection to get it to output, but the "Create Character option" doesn't do anything but close the program.

Please don't make multiple consecutive posts. It is often considered spamming or thread-bumping, both of which are specifically prohibited in the forum rules. Instead, please use the 'edit' feature in the bottom-right-hand corner of each post.

aside from your really uneasy on the eye choice of
bracket positioning, your problem is location
of cin.ignore() , here your revised copy

Code:

---

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

int main ()
{
        string select;
         
        cout << "Welcome to Link's Grand Quest!\n";
        cout << "Select an option:" << endl << endl;
        cout << "Create Character (press c)\n";
        cout << "Load Character (press l)\n";
        cout << "Creator (press r)\n";
        cout << "Exit (press e)\n";
        cin >> select;
        cin.ignore(80, '\n');
       
        if (select == "c" || select == "C")
        {
                cout << "I'm sorry, this feature is not available yet";
        }
        else if (select == "l" || select == "L")
        {
                cout << "I'm sorry, this feature is not available yet";
        }
        else if (select == "r" || select == "R")
        {
                cout << "I'm sorry, this feature is not available yet";
        }
        else if (select == "e" || select == "E")
        {
        }
        else if(select != "c" || select != "C" || select != "l" || select != "L" || select != "r" || select != "R" || select != "e" || select != "E")
        {
                cout << "I'm sorry, you did not select an option. Please select from below:\n\n";
                cout << "Create Character (press c)\n";
                cout << "Load Character (press l)\n";
                cout << "Creator (press r)\n";
                cout << "Exit (press e)\n";
                cin >> select;
                cin.ignore(80, '\n');
                if (select == "c" || select == "C")
                {
                        cout << "I'm sorry, this feature is not available yet";
                }
                else if (select == "l" || select == "L")
                {
                        cout << "I'm sorry, this feature is not available yet";
                }
                else if (select == "r" || select == "R")
                {
                        cout << "I'm sorry, this feature is not available yet";
                }
                else if (select == "e" || select == "E")
                {
                        cout << "I'm sorry, this feature is not available yet";
                }
        }
        cin.get();
      return 0;
}

---

then again you never said what your problem was.

Get rid of this.

Code:

---

    cin.ignore(80, '\n');

---

I've fixed that, and taken some time to at capabilities to the program, but now there's a minor bug on when I select the Dragon option in create(), then select the Main Menu option in the same function. When I choose to exit (type e) at that point, it repeats the main menu text, and requires me to enter it again to exit. Weird. Here's my updated code:

Code:

---

#include <iostream>
#include <fstream>
#include <string>

using namespace std;

void create();

int main () {
    string select;
   
    cout << "Welcome to Link's Grand Quest!\n";
    cout << "Select an option:" << endl << endl;
    cout << "Create Character (press c)\n";
    cout << "Load Character (press l)\n";
    cout << "Creator (press r)\n";
    cout << "Exit (press e)\n";
    cin >> select;
    if (select == "c" || select == "C")
    {
              create();
              main();
    }
    else if (select == "l" || select == "L")
    {
        cout << "I'm sorry, this feature is not available yet.\n\n";
        main();
    }
    else if (select == "r" || select == "R")
    {
        cout << "Creator: linkofazeroth\n\n";
        main();
    }
    else if (select == "e" || select == "E")
    {
        cout << endl;
    }
    else
    {
        while (select != "c" || select != "C" || select != "l" || select != "L" || select != "r" || select != "R" || select != "e" || select != "E")
        {
              cout << "I'm sorry, you did not select an option. Please select from below:\n\n";
              cout << "Create Character (press c)\n";
              cout << "Load Character (press l)\n";
              cout << "Creator (press r)\n";
              cout << "Exit (press e)\n";
              cin >> select;
              if (select == "c" || select == "C")
              {
                          create();
              }
              else if (select == "l" || select == "L")
              {
                    cout << "I'm sorry, this feature is not available yet.\n\n";
                    main();
              }
              else if (select == "r" || select == "R")
              {
                    cout << "Creator: linkofazeroth\n\n";
                    main();
              }
              else if (select == "e" || select == "E")
              {
              }
        }
    }
}

void create() {
    string rac;
   
    cout << "Which race do you wish to be?\n\n";
    cout << "Dragon (press d)        WARNING! Level 10 must be attained to become a Dragon.\n";
    cout << "Elf (press e)\n";
    cout << "Human (press h)\n";
    cout << "Dwarf (press w)\n";
    cout << "Gnome (press g)\n";
    cout << "Main Menu (press m)\n";
    cin >> rac;
    cout << endl;
    if (rac == "d" || rac == "D")
    {
            cout << "Dragons are the most powerful race on Couria, and require you to be level 10" << endl << "before being useable.\n";
            cout << "Dragons have the best vision, and with their specially fit DragonBows, only" << endl << "Elves come close to their mastery of archery.\n";
            cout << "The claws of a dragon, when properly taken care of, are the hardest substance" << endl << "found anywhere. Only the warhammers of the dwarves are more powerful.\n";
            cout << "Dragon scales are nearly as hard as dragon claws, and provide defense that is" << endl << "second-to-none.\n";
            cout << "With the power of flight, Dragons are so agile that only the Gnomes, with their mechanical creations, can keep up.\n\n";
            cin.get();
            create();
    }
    else if (rac == "e" || rac == "E")
    {
          cout << "Elves are the smartest race on Couria, being masterful archers and mages.\n";
          cout << "Elves have keen sight, better than a cat's, and thus their archery is second" << endl << "only to the Dragon's.\n";
          cout << "Unfortunately, as Elves are very slim, they're lacking in brute force. The same condition makes them easy prey when off guard.\n";
          cout << "The agility of the Elves are enviable by lesser races, but the Dragons, with" << endl << "their wings, and Gnomes, with their mechanical contraptions, are faster.\n\n";
          cin.get();
          create();
    }
    else if (rac == "m" || rac == "M")
    {
          main();
    }
    else
    {
        main();
    }
}

---

no need to call main(), it takes you right back to main, when
it done running. anyways stop saying you have an error.

start posting your error, the responses will be much
quicker if you do that.

also look the code i posted above...
main() returns an int, correct?
wonderful so where your return 0; at
you should have it at the end of your program for good measure.

I didn't say I had an error, I said I had a bug, and the compiler didn't catch this one, so I can't show you the error report.

It'd be a good idea to take my code and run it on your end so you can actually see the output. Follow these steps to get to my bug:

1. Press c.
2. Press d or e.
3. Press m.
4. Press e.

EDIT: Solved the bug, ILoveVectors was right about the main();'s not needing to be there in create().

yea that what i was saying, that just because the compiler
doesnt show you the error, doesnt mean you cant
give us a explination of the error.

such as what you do and what the program does
to that response then mention what it should be
doing.

im not harrassing you so dont get upset im just letting
you know the best course of action once you need
help agian.

I did say what the problem was, including at the very beginning. For the current (sorta) problem, I said "when I select the Dragon option in create(), then select the Main Menu option in the same function. When I choose to exit at that point, it repeats the main menu text, and requires me to enter it again to exit"

Quote:

---

Originally Posted by ILoveVectors

main() returns an int, correct?
wonderful so where your return 0; at
you should have it at the end of your program for good measure.

---

Actually, main implicitly returns 0 if you don't specify a return value. And I'm pretty sure recursively calling main() is undefined (so don't do it!)

Ok, I just finished the function that's supposed to load the data from separate files and save them into separate variables, but when I tested the contents of the variables after loading them from the files, all that came out was a 0 for each variable. THe variables are global; could that be the cause? Here's some of my code:

load()

Code:

---

void load() {
    string nam;
    string sel;
   
    cout << "Which character do you want to play as?\n\n";

//...

    ifstream enam("enam.txt"); //Elf name

//...

    if ( !enam.is_open() ) //Check for existence.
    {
    }
    else
    {
        enam >> nam;
        cout << nam << " the Elf (press e)\n";
    }

//...

    else if (sel == "e" && enam.is_open())
    {
          ofstream char2("elev.txt"); //Start at char2 for consistency with createdata().
          ofstream char3("eatt.txt");
          ofstream char4("edef.txt");
          ofstream char5("eagi.txt");
          ofstream char6("emon.txt");
          ofstream char7("eexp.txt");
          char2 << lev; //Input into global variables
          char3 << att;
          char4 << def;
          char5 << agi;
          char6 << mon;
          char7 << exp;
          dnam.close(); //Close the name files
          enam.close();
          hnam.close();
          wnam.close();
          gnam.close();
          char2.close(); //Close the statistics files
          char3.close();
          char4.close();
          char5.close();
          char6.close();
          char7.close();
    }

//...

    cout << lev << " " << att << " " << def << " " << agi << " " << mon << " " << exp << ".";
    cin.ignore(80,'\n');
    cin.get();
}

---

And here's createdata()

Code:

---

void createdata(string rac) {

//...

    else if (rac == "e" || rac == "E")
    {
            string enam;
           
            ofstream char1("enam.txt"); //Name
            ofstream char2("elev.txt"); //Level
            ofstream char3("eatt.txt"); //Attack
            ofstream char4("edef.txt"); //Defense
            ofstream char5("eagi.txt"); //Agility
            ofstream char6("emon.txt"); //Money
            ofstream char7("eexp.txt"); //Experience
            cout << endl << "What is your character's name? ";
            cin >> enam;
            char1 << enam;
            char2 << "1"; //Starting level
            char3 << "50"; //Starting attack
            char4 << "40"; //Starting defense
            char5 << "65"; //Starting agility
            char6 << "0"; //Starting money
            char7 << "1"; //Starting experience
            char1.close();
            char2.close();
            char3.close();
            char4.close();
            char5.close();
            char6.close();
            char7.close();
    }
//...

---

EDIT: Also, the files themselves contain 0, so it's not load() that's the problem. I think it's just how I'm sending the numbers to the files.

I figured it out, the problem was I was using the wrong type of fstream.

The problem this time is that I implemented my variables into a struct, but the compiler says "stats" does not name a type". Here's the format of my struct:

Code:

---

#include <iostream>
#include <fstream>
#include <string>
#include <cstdlib>

using namespace std;

void create();
//Function to display race information. Leads to createdata().
void createdata(string rac);
//Function to create date files for use in the game.
void load();
//Function to load a character's data files and start the game.
void game();
//Storyline function. Not much else to say.
void battle();
//Battling function, gives exp and money if you win.
void monst();
//Randomly generate monsters for battle() according to level.
void attack();
//Attack the opponent generated in monst().
void defend();
//Increase defense temporarily.

struct stats
{
      string nam;
      int lev;
      int att;
      int def;
      int agi;
      int mon;
      int sta;
      float exp;
}

int main () {
    string select;
    stats player;
    stats enemy;

//...

---

Code:

---

struct stats
{
      string nam;
      int lev;
      int att;
      int def;
      int agi;
      int mon;
      int sta;
      float exp;
};

---

...Oh. Thanks. :)

How would I let my program be able to "delete" a character (that is, the save files for your in-game player)? Is there a keyword "delete" or something?

if you have a file that containsa single character and you want to
remove it, you can either use remove("file path");

or you can open the file only ios::out and it will erase the contents
of the file but keep the actual file.

No, I want to actually delete the file itself.

Actually, delete("") worked perfectly. Now I have a new, unrelated bug, though... My monst() function (it randomly pulls up a monster and loads the opponent's struct with the enemy info) isn't reloading the enemy stats every time I start a "quick battle". Also, when I run away from a battle (this problem seems to be in battle() ), I still gain exp and money even though I don't want it to. Here are the two functions (and the function that calls them):

monst()

Code:

---

void monst() {
    int rando = 1+rand()%500;
    if (player.lev >= 1 && player.lev <= 3)
    {
            if (rando <= 50 && rando >= 0)
            {
                    opponent.nam = "Bug";
                    opponent.lev = 1;
                    opponent.att = 3;
                    opponent.def = 2;
                    opponent.agi = 2;
                    opponent.mon = 10;
                    opponent.sta = 10;
                    opponent.exp = 5;
            }
            else if (rando > 50)
            {
                opponent.nam = "Rabbit";
                opponent.lev = 1;
                opponent.att = 3;
                opponent.def = 3;
                opponent.agi = 3;
                opponent.mon = 5;
                opponent.sta = 15;
                opponent.exp = 10;
            }
    }
}

---

battle() -- which calls monst()

Code:

---

void battle() {
    string sel;
   
    monst();
    while (player.tempsta > 0 || opponent.sta > 0)
    {
          cout << player.nam << ": Level " << player.lev << "; Stamina: " << player.tempsta << endl;
          cout << opponent.nam << ": Level " << opponent.lev << "; Stamina: " << opponent.sta << endl << endl;
          cout << "Attack (press a)\n";
          cout << "Defend (press d)\n";
          cout << "Run (press r)\n\n";
          cin >> sel;
          if (sel == "a" || sel == "A")
          {
                  attack();
                  if (opponent.sta < 1)
                  {
                          break;
                  }
                  else if (player.tempsta < 1)
                  {
                        break;
                  }
                  else if (player.tempsta > 0 && opponent.sta > 0)
                  {
                  }
                  else
                  {
                        cout << "Error\n\n";
                        break;
                  }
          }
          else if (sel == "d" || sel == "D")
          {
                defend();
                if (opponent.sta < 1)
                {
                        break;
                }
                else if (player.tempsta < 1)
                {
                    break;
                }
                else if (player.tempsta > 0 && opponent.sta > 0)
                {
                }
                else
                {
                    cout << "Error\n\n";
                    break;
                }
          }
          else if (sel == "r" || sel == "R")
          {
          break;
          }
          else
          {
              cout << "Error\n\n";
              break;
          }
    }
    if (player.tempsta > 0 && opponent.sta <= 0)
    {
            player.exp += opponent.exp;
            player.mon += opponent.mon;
            player.tempsta = player.sta;
            cout << "You gained " << opponent.mon << " money and " << opponent.exp << " experience points.\n";
            exp();
    }
    else if (player.tempsta <=0 && opponent.sta > 0)
    {
          cout << "You lost the battle!\n";
    }
    else if (player.tempsta > 0 && opponent.sta > 0)
    {
          cout << "You escaped from the enemy.\n";
    }
}

---

gamemenu() -- which calls battle()

Code:

---

void gamemenu() {
    string opti;

    while (opti != "e" || opti != "E")
    {
          cout << "Story Mode (press s)\nQuick Battle (press q)\nCharacter Info (press i)\nExit (press e)\n";
          cin.ignore(100,'\n');
          cin >> opti;
          if (opti == "i" || opti == "I")
          {
                    cout << "\nName: " << player.nam << "\nLevel: " << player.lev << "\nAttack: ";
                    cout << player.att << "\nDefense: " << player.def << "\nAgility: ";
                    cout << player.agi << "\nStamina: " << player.sta << "\nMoney: ";
                    cout << player.mon << "\nExperience: " << player.exp << "\n\n";
          }
          else if (opti == "q" || opti == "Q")
          {
                cout << endl;
                battle();
                cout << endl;
          }
          else if (opti == "e" || opti == "E")
          {
                cout << endl;
                break;
          }
          else if (opti == "s" || opti == "S")
          {
                game();
          }
    }
}

---

EDIT: Oh, I forgot to post the struct containing the "player." and "opponent." variables. Here it is:

Code:

---

struct statistics {
      string nam; //Name
      int lev; //Level
      int att; //Attack
      int def; //Defense
      int tempdef; //To heighten defense for a turn.
      int agi; //Agility (not currrently used in the program)
      int mon; //Money
      int sta; //Stamina
      int tempsta; //To keep track of player health while regenerating it after battle.
      float gloc; //To keep track of your location in Story Mode.
      float exp; //Experience (for leveling up, not currently used)
};

---