A nested if inside the switch

here's the code(roughly of course), wondered if it can be done:

Code:

---

Case ‘2’:
                /*Find hourly workers salary */
       
Printf “Please enter hours worked”
        Scanf(%d, &hours)
Printf (“Please enter hourly wage”)
scanF(%d, &wage)
        If(hours <= 40){
        Salary_2= hours * wage
}
        If(Hours > 40 ){
        Salary_2 hours * wage + hours> 40 *wage * 1.5{
}
Printf(“The employee’s pay is : %d” , salary_2)

---

That's the gist of it, is it legal? and of not, maybe someone can suggest something. I also have a hunch the calculation for hours > 40 is wrong if anyone can tell me what that is I'd really appreciate it - math just aint working for me today :)
Thanks, everyone here is a big help.
Regards,
Extro

Yes.

ok cool, thanks - but I still have a logic error. Here's the code.
the problem is in case 2:

Code:

---


#include <stdio.h>
int main()
{

        int pay;       
        float salary_1;
        float weekly_salary;
        int hours;
        float wage;
        float salary_2;
        int overtime;

        printf("Please enter paycode( enter EOF to end): ");

               

        while (pay != 1 ){
                        switch(pay){
               
                        case '1':        /*find managers weekly salary */
                                        printf("Please enter annual salary: ");
                                        scanf("%f" , &salary_1);
                                        weekly_salary = salary_1 / 52;
                                        printf("Salary is: ", weekly_salary);
                                        break;

                        case '2':                /*Find hourly workers salary */
       
                        printf("Please enter hours worked: ");
                        scanf("%d", &hours);
                        printf ("Please enter hourly wage: ");
                        scanf("%d", &wage);
                                if(hours <= 40){
                                        salary_2= hours * (float)wage;
                                }
                                if(Hours > 40 ){
                                        printf("Please enter overtime hours");
                                        scanf("%d" , &overtime);

                                        salary_2 = (float)salary_2 + (overtime * (float)wage * 1.5);
}
                                        printf("The employee's pay is : %d" , salary_2);
                                        break;

                        default:
                                printf("Please enter a correct paycode.");
                                break;
}
        }

        return 0;
}

---

How do I properly set it up to calculate overtime pay?
Thanks,
Extro

> while (pay != 1 )
You enter the loop with pay uninitialised.

> scanf("%d", &wage);
It's a float, not an int - change the type, or change the conversion.
Better yet, start using gcc and use the -Wall command line option to tell you when you mess up with printf and scanf conversions.

> salary_2= hours * (float)wage;
It's already a float, casting isn't going to make a bean of difference.

You are entering the while loop with pay variable uninitialized moreover you are checking it with !=1.but you have a switch statement doing action if it has a value 1.
You are asking user to give input for paycode but you are not taking it.You want user to enter in while loop if he has not entered EOF????if yes,declare a variable named int paycode and put scanf statment after your first input.and change while loop to while(paycode!=-1)..again put scanf statement after printf of your default statement

Ok here's the working code I have a couple of questions about:

Code:

---


#include <stdio.h>
int main()
{


    int    pay;
    float  salary_1;
    float  weekly_salary;
    int    hours;
    float  wage;
    float  salary_2;
    int    overtime;
    float  wage2;
    int    weekly_sales;
    float  pay_3;
    float  sales;
    int    items;
    float  pay_4;


        printf("Please enter paycode(Enter -1 to end): ");


            while((pay = getchar()) != -1){
                        switch(pay){
               
                        case '1':        /*find managers weekly salary */
                                        printf("Please enter annual salary: ");
                                        scanf("%f" , &salary_1);
                                        weekly_salary = salary_1 / 52;
                                        printf("Salary is: $%.2f \n ", weekly_salary);
                    break;


                        case '2':                /*Find hourly workers salary */
       
                        printf("Please enter hours worked: ");
                        scanf("%d", &hours);
                        printf ("Please enter hourly wage: ");
                        scanf("%f", &wage);
                                if(hours <= 40){
                                        salary_2= hours * wage;
                                }
                                if(hours > 40 ){
                                        printf("Please enter overtime hours");
                                        scanf("%d" , &overtime);
                                        wage2 = wage * hours;

                                        salary_2 = wage2 + (overtime * wage * 1.5);
}
                                        printf("The employee's pay is: $%.2f \n" , salary_2);
                            break;
                  case '3':
                  printf("Enter gross weekly sales: ");
                  scanf("%f" , &sales);
                  pay_3 = 250 + (sales * 5.7 / 100);
                  printf("This week's pay is: $%.2f" , pay_3);
                        break;
                  case '4':
                        printf("Enter number of items produced: ");
                        scanf("%d" , &items);
                        pay_4 = 250 * items;
                        printf("Amount earned: $%/2f");
                                  break;
                        case '\n':
                        break;

                        default:
                printf("You have entered an incorrect paycode.");
                printf("Please enter a correct paycode:\n");
                break;
}
                printf("Please enter a paycode(Enter -1 to end): ");
}

        return 0;
}

---

The trouble is asking for another paycode, I noticed if I enter another number after it calculates pay it goes into the right case, trouble is it doesnt acutally for a paycode.
I put in that last printf statement so it does but it displays it twice :confused:
Any suggestions on how I might get it to ask for another paycode after the initial one has been finished?

Thanks,
Extro

You should read the FAQ on getting input from a user. What's happening is when you call scanf, it leaves the newline (enter) in the input buffer. Thus, the next call to scanf reads it as its input. You should ideally use a better way to read input. If not, you should account for the newline and clear it out of the input stream before you read for use further.


Quzah.

I still don't understand why 'Please enter a paycode(Enter -1 to end): ' would come up twice one immediately following the other when its done the first case, like this:
Please enter a paycode(Enter -1 to end): Please enter a paycode(Enter -1 to end):

Why is it doing this?
Thanks,
Extro

Code:

---

while((pay = getchar()) != -1){
    switch(pay){
        case '1':        /*find managers weekly salary */
            ...
        break;

        case '2':                /*Find hourly workers salary */
            ...
        break;

        case '3':
            ...
        break;

        case '4':
        break;

        case '\n':
        break;

        default:
            printf("You have entered an incorrect paycode.");
            printf("Please enter a correct paycode:\n");
        break;
    }
    printf("Please enter a paycode(Enter -1 to end): ");
}

---

Well for starters, 'getchar' isn't going to return -1 ever. The 'getchar' function returns a keystroke (not entirely accurate, but close enough). What single key on your keyboard is '-1'?

Ok, now let's examine the loop itself:

Code:

---

while the key read isn't something
    switch this key
        lets say we match
            oh, there's an enter left because of 'getchar'(enter)
            that skips your first scanf call
            lets say you have another, so you type 'foo'(enter)
            that stores foo
        we break from the getchar match

        we're out of the switch, but in the loop, so we display
        printf("Please enter a paycode(Enter -1 to end): ");

        (enter) from the last scanf is here
        this runs us through the loop, to the '\n' case
            all this does is 'break'

        we're out of the switch, but in the loop, so we display
        printf("Please enter a paycode(Enter -1 to end): ");

---

That's the general idea. And there you have it, your message displayed twice, just like I said it would, for the reason I stated.


Quzah.

Ok I fixed the code up a bit but its still not asking for another code, its just waiting for one. How do I get it to ask again?
Thanks for all the help.

Code:

---

       
#include <stdio.h>
int main()
{


    int    pay;
    float  salary_1;
    float  weekly_salary;
    int    hours;
    float  wage;
    float  salary_2;
    int    overtime;
    float  wage2;
    int    weekly_sales;
    float  pay_3;
    float  sales;
    int    items;
    float  pay_4;


        printf("Please enter paycode(Enter EOF to end): ");


            while((pay = getchar()) != EOF){
                        switch(pay){
               
                        case '1':        /*find managers weekly salary */
                                        printf("Please enter annual salary: ");
                                        scanf("%f" , &salary_1);
                                        weekly_salary = salary_1 / 52;
                                        printf("Salary is: $%.2f \n ", weekly_salary);
                    break;


                        case '2':                /*Find hourly workers salary */
       
                        printf("Please enter hours worked: ");
                        scanf("%d", &hours);
                        printf ("Please enter hourly wage: ");
                        scanf("%f", &wage);
                                if(hours <= 40){
                                        salary_2= hours * wage;
                                }
                                if(hours > 40 ){
                                        printf("Please enter overtime hours");
                                        scanf("%d" , &overtime);
                                        wage2 = wage * hours;

                                        salary_2 = wage2 + (overtime * wage * 1.5);
}
                                        printf("The employee's pay is: $%.2f \n" , salary_2);
                            break;
                  case '3':
                  printf("Enter gross weekly sales: ");
                  scanf("%f" , &sales);
                  pay_3 = 250 + (sales * 5.7 / 100);
                  printf("This week's pay is: $%.2f" , pay_3);
                        break;
                  case '4':
                        printf("Enter number of items produced: ");
                        scanf("%d" , &items);
                        pay_4 = 250 * items;
                        printf("Amount earned: $%/2f");
                                  break;

                  case '\n':
                        break;

                        default:
                printf("You have entered an incorrect paycode.");
                printf("Please enter a correct paycode:\n");
                break;
}

}
          return 0;
}

---

Code:

---

#include<stdio.h>

void fflushstdin( void ) /* we write our own to flush input */
{
    int c;
    while( (c = getchar()) != EOF && c != '\n' ); /* junk the buffered input */
}

int main( void )
{
    int choice = 0;

    do
    {
        printf("Enter a character and press enter. (q to quit) :"); /* prompt */
        fflush( stdout ); /* flush the output buffer, fflush is only for output */

        choice = getchar( ); /* we want one character... */
        fflushstdin( ); /* after reading input, clear anything extra we don't want */

        printf("You entered %c.\n", choice );
    } while( c != 'q' );

    return 0;
}

---

Tinker with that and see if that's what you're looking for.


Quzah.

I appreciate the help but being a first year student I haven't yet been taught things like fflush so IU'm not sure how to work with it. I went with a do...while and I'm still getting
Please enter paycode(Enter EOF to end):Please enter paycode(Enter EOF to end):
everytime it loops through

Code:

---

#include <stdio.h>
int main()
{


    int    pay;
    float  salary_1;
    float  weekly_salary;
    int    hours;
    float  wage;
    float  salary_2;
    int    overtime;
    float  wage2;
    int    weekly_sales;
    float  pay_3;
    float  sales;
    int    items;
    float  pay_4;



            do{
            printf("Please enter paycode(Enter EOF to end): ");
            pay = getchar();
                        switch(pay){
               
                        case '1':        /*find managers weekly salary */
                                        printf("Please enter annual salary: ");
                                        scanf("%f" , &salary_1);
                                        weekly_salary = salary_1 / 52;
                                        printf("Salary is: $%.2f \n ", weekly_salary);
                    break;


                        case '2':                /*Find hourly workers salary */
       
                        printf("Please enter hours worked: ");
                        scanf("%d", &hours);
                        printf ("Please enter hourly wage: ");
                        scanf("%f", &wage);
                                if(hours <= 40){
                                        salary_2= hours * wage;
                                }
                                if(hours > 40 ){
                                        printf("Please enter overtime hours");
                                        scanf("%d" , &overtime);
                                        wage2 = wage * hours;

                                        salary_2 = wage2 + (overtime * wage * 1.5);
}
                                        printf("The employee's pay is: $%.2f \n" , salary_2);
                            break;
                  case '3':
                  printf("Enter gross weekly sales: ");
                  scanf("%f" , &sales);
                  pay_3 = 250 + (sales * 5.7 / 100);
                  printf("This week's pay is: $%.2f" , pay_3);
                        break;
                  case '4':
                        printf("Enter number of items produced: ");
                        scanf("%d" , &items);
                        pay_4 = 250 * items;
                        printf("Amount earned: $%/2f");
                                  break;

                  case '\n':
                        break;

                        default:
                printf("You have entered an incorrect paycode.");
                printf("Please enter a correct paycode:\n");
                break;
}
  }
    while(pay != EOF);
          return 0;
}

---

...any help is appreciated more than ya know.
Thanks,
Extro

Extro
Just a couple of observations:

You have declared 'pay' as an int and then go on to use it as a char

Second; the '\n' left in the buffer is causing the second prompt for input. There is a '\n' left in the buffer after the last call for input which is being immediately assigned to 'pay' in your while statement second time through satisfying the '\n' case. While I know that it’s frowned on, using fflush(stdin) as the last line of your 'while' loop should take care of this.

Thirdly getchar() only reads in one character, so using '-1' or 'EOF' to end your program wont work. getchar() will only load the '-' or the 'E'. Maybe scanf is a better choice.

One novice to an other I hope this helps.
;)

EDIT: Missed your last post, so this refers to the code from post befor the do while change.

I got it to work! here's the code:

Code:

---

#include <stdio.h>
int main()
{


    char    pay;
    float  salary_1;
    float  weekly_salary;
    int    hours;
    float  wage;
    float  salary_2;
    int    overtime;
    float  wage2;
    int    weekly_sales;
    float  pay_3;
    float  sales;
    int    items;
    float  pay_4;




            do{
            fflush(stdin);
            printf("Please enter paycode(Enter EOF to end): ");
            pay = getchar();
                        switch(pay){
               
                        case '1':        /*find managers weekly salary */
                                        printf("Please enter annual salary: ");
                                        scanf("%f" , &salary_1);
                                        weekly_salary = salary_1 / 52;
                                        printf("Salary is: $%.2f \n ", weekly_salary);
                    break;

                        case '2':                /*Find hourly workers salary */
       
                        printf("Please enter hours worked: ");
                        scanf("%d", &hours);
                        printf ("Please enter hourly wage: ");
                        scanf("%f", &wage);
                                if(hours <= 40){
                                        salary_2= hours * wage;
                                }
                                if(hours > 40 ){
                                        printf("Please enter overtime hours");
                                        scanf("%d" , &overtime);
                                        wage2 = wage * hours;

                                        salary_2 = wage2 + (overtime * wage * 1.5);
}
                                        printf("The employee's pay is: $%.2f \n" , salary_2);
                            break;
                  case '3':
                  printf("Enter gross weekly sales: ");
                  scanf("%f" , &sales);
                  pay_3 = 250 + (sales * 5.7 / 100);
                  printf("This week's pay is: $%.2f \n" , pay_3);
                        break;
                  case '4':
                        printf("Enter number of items produced: ");
                        scanf("%d" , &items);
                        pay_4 = 250 * items;
                        printf("Amount earned: $%.2f \n" , pay_4);
                                  break;



                        default:
                printf("You have entered an incorrect paycode.");
                printf("Please enter a correct paycode:\n");
                break;
}
  }
                  while(pay != EOF);

          return 0;
}

---

Wow - crazy indentation and fflush(stdin)
1. Turn OFF tabs in your text editor, the board and everyones browser treats them differently, so it never looks good.
2. Why you shouldn't use fflush(stdin) is in the FAQ

Here's a sample to get you going.

Code:

---

#include <stdio.h>

char *promptAndAnswer ( char *buff, size_t size ) {
  printf( "Please enter paycode(Enter EOF to end): " );
  fflush( stdout );
  return fgets( buff, size, stdin );
}

void doManager ( void ) {
  char buff[BUFSIZ];
  float salary_1,weekly_salary;
 
  printf("Please enter annual salary: ");
  fflush( stdout );
  fgets( buff, sizeof(buff), stdin );
  sscanf( buff, "%f", &salary_1 );
  weekly_salary = salary_1 / 52;
  printf("Salary is: $%.2f\n", weekly_salary);
}

void doWorker ( void ) {
  printf( "doWorker\n" );
}

int main ( ) {
  char buff[BUFSIZ];

  while ( promptAndAnswer( buff, sizeof(buff) ) != NULL ) {
    char pay = buff[0];
    switch ( pay ) {
      case '1':
        doManager();
        break;
      case '2':
        doWorker();
        break;
      default:
        printf( "Not valid\n" );
        break;
    }
  }
  return 0;
}

---

Quote:

---

Originally Posted by Syked4

Extro
Just a couple of observations:

You have declared 'pay' as an int and then go on to use it as a char

---

That's the correct way to do it, since getchar actually returns an integer. Read the FAQ as to why you have to use an int to test for EOF when using characters.

Quote:

---

Originally Posted by Syked4

Second; the '\n' left in the buffer is causing the second prompt for input. There is a '\n' left in the buffer after the last call for input which is being immediately assigned to 'pay' in your while statement second time through satisfying the '\n' case.

---

:reads his last post: Yep, that's already been covered quite clearly.

Quote:

---

Originally Posted by Syked4

While I know that it’s frowned on, using fflush(stdin) as the last line of your 'while' loop should take care of this.

---

No it shouldn't. There's nothing at all in the standard that says this should ever work. In fact, it should never work. The only reason it "works" ever is because Microsoft decided to ........ up^H^H^H^H^H^H^Hextend the language and make the function do something it should never do. fflush is used for output streams only. :reads his last post: Wait a minute, I already covered that too. :rolleyes:

Quote:

---

Originally Posted by Syked4

Thirdly getchar() only reads in one character, so using '-1' or 'EOF' to end your program wont work.getchar() will only load the '-' or the 'E'.

---

:reads last post again: Holy Deja Vu, Batman! I covered this too!

Quote:

---

Originally Posted by Syked4

Maybe scanf is a better choice.

---

I wouldn't go that far. Wait a second! I already showed a better way to do this too!

Quote:

---

Originally Posted by Syked4

EDIT: Missed your last post, so this refers to the code from post befor the do while change.

---

Apparently you missed my last post too, because I showed a better way to do everything you mentioned.


Quzah.

Salem
In doManager and main you declare a string of BUFSIZ elements. Can you explain the use of this for me.
Also in *promptAndAnswer, can you explain the use of the '*' and is size_t a type.

1) BUFSIZ is a macro defined in stdio.h. It is defined by the C standard.

2) The * denotes that you're using a pointer. A pointer is a variable that stores the address (memory location) of another variable. In this case:

Code:

---

char *promptAndAnswer ( char *buff, size_t size ) {

---

promptAndAnswer returns a pointer to a character. (Read it from right to left to easier understand it:

Code:

---

promptAndAnswer  /* the function... */
* /* returns a pointer to... */
char /* a character... */

---

)
Also, it as an argument takes a pointer to a character:

Code:

---

promptAndAnswer ( char *buff,

---

buff is a * pointer to a char

3) size_t is a data type defined by the C standard. It is defined to be an unsigned integeral type. Usually defined as an unsigned long, but it doesn't have to be. It only has to be unsigned, integeral. It's guarinteed to be safe for indexing arrays, as you can't run off the lower boundry. (Nothing stops you from running off the top end though, except your careful attention.)


Quzah.

quzah
Thanks for the slap and the fflushstdin() function. Both appreciated. In main should c be choice?

OPPS Two pages now. Thanks also for the explanations.

Well I got it to work with fflush(stdin) and so I think it's best to leave well enough alone. Also, I dont wanna get too much into into c commands and functions we havent covered or he(my teacher) may not think it was me that did it, a risk I'd rather not run.
Thanks for all the help Quzah and others.
Regards,
Extro

If your teacher thinks fflush(stdin) is a good idea, ask them what they think of gets().
If they don't recognise it's faults, then you're not going to learn anything useful from them, because they do not know enough C themselves.