Point out my error please

I thought this would be pretty simple but Windows keeps giving me this message "This application has requested the Runtime to terminate it in an unusal way." Why is this happening?

Note: At frist I wrote the split function by myself, but when that didn't work, i took one straight from my book, so i can't imagine it being wrong. maybe it's in my main() function?

Code:

---

#include <iostream>
#include <string>
#include <vector>
#include <cctype>

using std::cout;
using std::cin;
using std::string;
using std::vector;
using std::endl;

vector<string> split( const string& s ){
             
              vector<string> ret;
              typedef string::size_type string_size;
              string_size i = 0;
             
              while ( i != s.size() ){
                   
                    while ( i != s.size() && isspace(s[i]))
                    i++;
                   
                    string_size j = i;
                    while ( j != s.size() && !isspace(s[j]))
                    j++;
                   
                    if ( i != j ){
                         
                          ret.push_back(s.substr(i, j - i));
                          }
                    }
                    return ret;
                    }

int main(){
   
    cout << "Enter a sentence: " << endl;
    string v;
    cin >> v;
    vector<string> sen = split(v);
   
    cout << "The words in the sentence are: " << endl;
    vector<string>::size_type i = 0;
    while ( i != sen.size() ){
          cout << sen[i] << endl;
          i++;
    }
   
   
    }

---

EDIT: Problem solved. There was something wrong with the program's logic that i completely overlooked.

You have forgotten to return something in your main() function. Not that this is causing your error, but it's still not good.

Quote:

---

Originally Posted by Jaken Veina

You have forgotten to return something in your main() function. Not that this is causing your error, but it's still not good.

---

there's no need to return anything in main... sometimes that sparks a holy-war, but that's where I stand: you don't have to, but it's good to explicitly do so.

I don't know much about vectors, but one thing I noticed in your main function: you tried to use cin to get a sentence. cin stops on the first whitespace (space, tab, newline, etc.)--what you want to use here is getline:

Code:

---

std::string v;
std::cout<<"Enter a Sentence:\n> "<<std::flush;
getline(std::cin,v,'\n');

---

the way you had it, v contained the first word of whatever they put in. this way, v will include everything they put in until a newline. in other words, whatever sentence they enter.

This is a link for getline,
http://msdn.microsoft.com/library/de...line_class.asp

You might want to add some debugging statements.

Code:

---

        while ( i != s.size() )
        {
                cout << "i = " << i << "\ns.size() = " << s.size() << endl;
                while ( i != s.size() && isspace(s[i]))
                {
                        cout << "Do I ever get here!!" << endl;
                        i++;
                }

---

and add cin.get here,

Code:

---

                if( i != j )
                {
                        ret.push_back(s.substr(i, j - i));
                }
                cin.get();
        }

---

are you getting the result you wanted?

Quote:

---

Originally Posted by Anubis

This is a link for getline,
http://msdn.microsoft.com/library/de...line_class.asp

---

I'm sorry, but that's a terrible reference for getline: http://www.cppreference.com/cppstring/getline.html

Quote:

---

Originally Posted by major_small

I'm sorry, but that's a terrible reference for getline: http://www.cppreference.com/cppstring/getline.html

---

I'm sorry, but are your post alway so pointless.
I will not argue the value of the link I posted. If you wish to post another link fine. But you should be a little more open minded. If everyone thought like you there would only be one book and one website for reference.
I am also interested your explanation as to why the link you posted is better?

because I don't like you.

here's your MSDN link, if it'll make you happier.

and if everybody thought like me, there would not be one book/resource. that's just stupid of you to think. If everybody thought like me, you'd have readable resources that made sense for people who are trying to grasp the concept as well as people who already have a firm grasp on it. like the links I posted.

Quote:

---

Originally Posted by Anubis

I'm sorry, but are your post alway so pointless.
I will not argue the value of the link I posted. If you wish to post another link fine. But you should be a little more open minded. If everyone thought like you there would only be one book and one website for reference.
I am also interested your explanation as to why the link you posted is better?

---

Sorry I didnt find your link (Anubis) that usefull especially for beginners. It didnt give examples or really much explanation only syntax which also wasn't really worded great for beginners.

Quote:

---

Originally Posted by JoshR

Sorry I didnt find your link (Anubis) that usefull especially for beginners. It didnt give examples or really much explanation only syntax which also wasn't really worded great for beginners.

---

Well you are just as stupid as major_small. Clearly if you can read,
it has a link to an example at bottom.

Quote:

---

Originally Posted by major_small

because I don't like you.

---

You are must have a major small brain.

Quote:

---

Originally Posted by major_small

I don't know much about vectors

---

Well my conclusion that you do not know much is true.

Quote:

---

Originally Posted by major_small

getline(std::cin,v,'\n');

---

Does not have a clue.

what's wrong with that last one?

Quote:

---

Originally Posted by major_small

there's no need to return anything in main...

---

If you've declared main() to return something, you should return something. void main() doesn't have to return anything, no, but int main() must.

Quote:

---

If you've declared main() to return something, you should return something.

---

That rule applies to all functions except the global main() function.

Quote:

---

void main() doesn't have to return anything, no, but int main() must.

---

That's only true if main() here is not the global main() function. Generally, the global main() function cannot have a return type of void.

Quote:

---

Originally Posted by Anubis

Well you are just as stupid as major_small. Clearly if you can read,
it has a link to an example at bottom.

---

Ya but I dont feel like its that great of an example. Its pure preference dude, no need to get all heated about it.

This thread is awfully close to being locked - take your argument elsewhere.

Sorry actually there WAS something wrong with the split function that I overlooked (do'h!).

I forgot to set the value of i to j after the if statement in the function which i think kept it in an infinite loop that continuously pushed back the same substring into the vector until i got the erorr message (the program it self would take a few seconds, then close with the error message).

Sorry for all the trouble.