print problem while using fgets()

Hi all, I'm still new to C and would like to ask the following questions. When I use fgets(), does it also reads the '\n' character? What should I do if I would like to print in the following manner.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#define MAXSIZE 50

int main(void)
{
  char *input1, *input2;
 
  input1 = malloc(MAXSIZE);
  input2 = malloc(MAXSIZE);
 
  printf("Input string 1: ");
  fgets(input1, MAXSIZE+1, stdin);
  printf("Input string 2: ");
  fgets(input2, MAXSIZE+1, stdin);
 
  printf("String 1\t\tString 2\n");
  printf("--------------------------------------\n");
  printf("%10s", input1);
  printf("%10s", input2);
 
  return 0;
}

---

Also I would like to ask, is it necessary to do casting when I do malloc, as I sometimes see that being done in C programming books that I read. For example:

Code:

---

char *input1, *input2;
 
input1 = (char *)malloc(MAXSIZE);
input2 = (char *)malloc(MAXSIZE);

---

Thanks!

FAQ > How do I... (Level 1) > Get a line of text from the user/keyboard (C)
FAQ > Explanations of... > Casting malloc

Oh thanks! Sorry for not reading the FAQs. Will keep that in mind in the future.

There is no need to have the +1:

Code:

---

fgets(input1, MAXSIZE+1, stdin);

---

Change that to this:

Code:

---

fgets(input1, MAXSIZE, stdin);

---

And about fgets() sucking in a '\n', fgets() replaces the '\n' with a '\0' (null) character.

>>And about fgets() sucking in a '\n', fgets() replaces the '\n' with a '\0' (null) character.

It does, does it?

Code:

---

void flush_newline(char *swap){
  /* replaces every '\n' character with a '\0' */
  char ch;
  int i,len;
  len = strlen(swap);
  for(i=0;i<len;i++){
    ch = swap[i];
    if(ch == '\n')
        swap[i] = '\0';
  }
}

---

Quote:

---

Originally Posted by sand_man

>>And about fgets() sucking in a '\n', fgets() replaces the '\n' with a '\0' (null) character.

It does, does it?

Code:

---

void flush_newline(char *swap){
  /* replaces every '\n' character with a '\0' */
  char ch;
  int i,len;
  len = strlen(swap);
  for(i=0;i<len;i++){
    ch = swap[ i ];
    if(ch == '\n')
        swap[ i ] = '\0';
  }
}

---

---

Which is actually a horrible piece of code because it potentially splits your one string into a bunch of strings. Thus destroying any ability you have to use all of the standard string functions on your one string.

Also, there is no reason at all for the variable ch.

Code:

---

if( swap[ i ] == '\n' )
    swap[ i ] = '\0';

---

Quzah.

Thanks sand_man, I remember now that it brings a newline with it:

Code:

---

#include <stdio.h>
#include <al/etl.h>
#include <sfl.h>

Bool searchNewline( char *userInput )
{
        while( *userInput != '\0' )
                if( *userInput++ == '\n' )
                        return TRUE;
        return FALSE;
}

void destroyNewline( char *userInput )
{
        while( *userInput != '\0' )
        {
                if( *userInput == '\n' )
                {
                        *userInput = '\0';
                        break;
                }
                userInput++;
        }
       
}

int main( void )
{
        /* VARs */
        static char userInput[NAME_MAX];
       
       
        /* Get input */
        fgets( userInput, NAME_MAX, stdin );
       
       
        /* Make sure there are no newlines */
        while( searchNewline( userInput ) )
        {
                puts( "The newline shall vanish" );
                destroyNewline( userInput );
        }
       
       
        /* Leave successfully */
        return EXIT_SUCCESS;
}

---

Output:

Code:

---

hello world!
The newline shall vanish

---

Kleid-0: Why go so far out of your way when the FAQ shows a standard, easier way?

I just like to practice that's all lol. And I wanted to show myself and others where I messed up in my false remark on my last post. I said that fgets() automatically replaces the '\n' with a '\0' character, but that's wrong, and I wanted to show that here.

--EDIT--

omg your right this is a lot easier:

Code:

---

if ((p = strchr(buf, '\n')) != NULL)
      *p = '\0';

---

I was trying to remember this when I was doing the function above but I couldn't remember the code. strchr, strchr, strchr.

Would this work?

Code:

---

if(string[strlen(string)-1] == '\n')
    string[strlen(string)-1] = 0;

---

string[strlen(string)] is the \0 character
Use -1 as you did in the assignment.

If you start out with a string similiar to this:

"Hello, My name is Joe!\n"

And you use fgets(); It gives you the string

"Hello, My name is Joe!\0"

because it scans to the '\n' then stops and replaces it with '\0'. Then when you use fputs() it prints back out:

"Hello, My name is Joe!\n"

because it prints to the '\0' and replaces it with '\n'. When you use strlen(), it scans to the '\0' then stops and does not include the '\0' in the answer. If you have:

"Hello, My name is Joe!\0"

It will return a length of 22 instead of 23. I would also like to add that you can just use gets() and puts() if you want to get the string from stdin and put it to stdout.

Quote:

---

Originally Posted by Brad0407

If you start out with a string similiar to this:

"Hello, My name is Joe!\n"

And you use fgets(); It gives you the string

"Hello, My name is Joe!\0"

because it scans to the '\n' then stops and replaces it with '\0'.

---

No, it doesn't.

Quote:

---

Originally Posted by Brad0407

Then when you use fputs() it prints back out:

"Hello, My name is Joe!\n"

because it prints to the '\0' and replaces it with '\n'.

---

No, it doesn't.

Quote:

---

Originally Posted by Brad0407

I would also like to add that you can just use gets() and puts() if you want to get the string from stdin and put it to stdout.

---

You can use gets if you are a complete idiot, but no one here would recommend it.