help fing the end of file

I get a continuous loop running after the info in the file has finished. The loop is filled with funny y characters.

Code:

---

void open_batch()
{
  int eof = FALSE;
  FILE *fp;
  char f[30];
  char c;
  int a = 0, b = 0;
  int d, e, g = 0, h = 0, i = 0, j = 0, k = 0, l = 0;
  printf("Please enter the file you wish to run: ");
  scanf("%s", &f);
  l = getchar();
  fp = fopen(f,"rt");
  if(fp == NULL)
  {
      printf("No such file\n");
      menu();
  }

  while(eof == FALSE)
  {
      c = fgetc(fp);
      while(c == 32)
      {
        c = fgetc(fp);
      }
      if((c == 'F') || (c == 'U') || (c == 'f') || (c == 'u'))
      {
        for(d = 0; d <= 3; d++)
        {
            u_type[d] = c;
            c = fgetc(fp);
            printf("%c", u_type[d]);
        }
        printf(" ");
        while(c == 32)
        {
            c = fgetc(fp);
        }
        for(e = 0; e <= 2; e++)
        {
            unit_no[e] = c;
            c = fgetc(fp);
            printf("%c", unit_no[e]);
        }
        printf(" ");
        while(c == 32)
        {
            c = fgetc(fp);
            printf("1", c);
        }
        printf(" ");
        sym = fgetc(fp);
        printf("%c", sym);
        c = fgetc(fp);
        while(c == 32)
        {
            c = fgetc(fp);
        }
        printf(" ");
      }
      for(g = 0; g < 3; g++)
      {
        h_no[g] = c;
        c = fgetc(fp);
        printf("%c", h_no[g]);
      }
      printf(" ");
      while(c == 32)
      {
        c = fgetc(fp);
      }
      while(c != 32)
      {
        st_name[h] = c;
        c = fgetc(fp);
        printf("%c", st_name[h]);
        h++;
      }
      printf(" ");
      while(c == 32)
      {
        c = fgetc(fp);
      }
      while(c != 32)
      {
        st_type[j] = c;
        c = fgetc(fp);
        printf("%c", st_type[j]);
        j++;
      }
      printf(" ");
      while(c == 32)
      {
        c = fgetc(fp);
      }
      while(c != 32)
      {
        sub_name[k] = c;
        c = fgetc(fp);
        printf("%c", sub_name[k]);
        k++;
      }
      printf(" ");
      while(c == 32)
      {
        c = fgetc(fp);
      }
      for(l = 0; l < 4; l++)
      {
        postcode[l] = c;
        c = fgetc(fp);
        printf("%c", postcode[l]);
      }
      while(c != '\n')
      {
        c = fgetc(fp);
      }
      if(c == EOF)
      {
        eof = TRUE;
      }
  }fclose(fp);
}

---

First of all, what are you trying to do? Because that code is a mess.

im reading in an file e.g. batch.txt then it is supposed to print the contents out to the screen
but it runs continuously.

Code:

---

    while(c != '\n')
      {
        c = fgetc(fp);
      }

---

how do you know that there is another '\n' in the file?

Quote:

---

Originally Posted by ck1

im reading in an file e.g. batch.txt then it is supposed to print the contents out to the screen

---

If that's all you want to do, it's possible in about two lines of code.

Code:

---

while no file errors occur and EOF is not reached
  read in a character from the file
  print that character to the screen

---

Code:

---

char c;
/* ... */
c = fgetc(fp);

---

FYI: fgetc returns an int.

what ck1 is getting at is what he is reading in is the following in a file:

123 Fake St Fakeville 3092
Flat 234 / 234 Greg Rd Melbit 2309[possibly space space space]
Unit 123 , 213 Pie Cres Hewton 2102[space space space space space]


EOF here....

he wants to read the info and eliminate the spaces between the words which may vary and may occur at the end of the line before '\n'. (yes this can be done with fscanf but its too late to change it now).

is there a way to read the chars to the end of the line and find the end of file, and not fill up the array with null characters (or get funny y's for nulls).

thanks everyone.

Quote:

---

Originally Posted by djwicks

and not fill up the array with null characters (or get funny y's for nulls).

---

The funny y's being the EOF?

the funny y's are the empty spaces in the array. however this problem occurs because he is unable to find the end of file marker and set it to true to break the while loop.

HELP