Remove white space problem

Hi, I am new to programming and I am trying to figure out what I am doing wrong with my code. I want to be able to remove spaces from a string. Using my code I get ! in places where I have white space instead of moving the next character to the position of the white space. Can anyone tell me what I am missing?

Code:

---

#include <iostream.h>
#include <conio.h>
#include <fstream.h>
#include <stdlib.h>
#include <iomanip.h>
#include <math.h>
#include <string.h>

int main()
{
 const int MAXCHARS = 71;
 char temp[MAXCHARS];
 char words[MAXCHARS] = "M y na me is J o hn ";
 int i;
 
 for(i=0; i < MAXCHARS; i++)
 {       
          for(i=0; i < MAXCHARS; i++)
          {

                    if (words[i] == 32) 
                  {
                  temp[i] = words[i] + 1 ;
                  }
                  else
                  temp[i] = words[i];

    }
 cout << temp << endl;

 getch();
 
}
 return 0;
 
}

---

i am not quite sure about this but you can try

Code:

---

#include <iostream.h>
#include <conio.h>
#include <fstream.h>
#include <stdlib.h>
#include <iomanip.h>
#include <math.h>
#include <string.h>

int main()
{
 const int MAXCHARS = 71;
 char temp[MAXCHARS];
 char words[MAXCHARS] = "M y na me is J o hn ";
 int i;
 
 for(i=0; i < MAXCHARS; i++)
 {       
          for(i=0; i < MAXCHARS; i++)
          {

                    if (words[i] == char(32)) 
                  {
                  temp[i] = words[i] +1  ;
                  }
                  else
                  temp[i] = words[i];

    }
 cout << temp << endl;

 getch();
 
}
 return 0;
 
}

---

That gives me the same result. I tried that before. I think it has something more to do with the

Code:

---

temp[i] = words[i] +1  ;

---

portion.

Why do you have two loops that use the same variable i?

You are getting !'s because you are adding 1 to the value of words[i], and 33 is the value of an exlamation point. What you want is temp[i] = words[i+1].

alrighty, I changed it but now I get the following display MyynnammeiisJJoohhn

Code:

---

#include <iostream.h>
#include <conio.h>
#include <fstream.h>
#include <stdlib.h>
#include <iomanip.h>
#include <math.h>
#include <string.h>

int main()
{
 const int MAXCHARS = 71;
 char temp[MAXCHARS];
 char words[MAXCHARS] = "M y na me is J o hn ";
 int i, j;
 
 for(j=0; j < MAXCHARS; j++)
 {       
          for(i=0; i < MAXCHARS; i++)
          {

                    if (words[i] == 32) 
                  {
                  temp[i] = words[i+1]  ;
                  }
                  else
                  temp[i] = words[i];

    }
 cout << temp << endl;

 getch();
 
}
 return 0;
 
}

---

Its because when you hit a space, you store the next letter, move up one, then store the letter again. Instead of storing the next letter, you are better just not storing anything when you hit a space.

You'[ve still got a loop that you aren't using (the for(j...) one).

The other problem is that you're not actually shifting the data you're only copy the next byte in when you have a space. This is how I would do it:

Code:

---

for(i=0, j=0; i<MAX_CHARS; i++)
  if(words[i]!=' ')
      words[j++]=words[i];

---

Thanks that did it!

There's a reason for the STL functios ;)

Code:

---

#include <iostream>
#include <string>

#define Trim(pointer1,pointer2) tTrim<string>(pointer1, pointer2)

template <typename T, typename I>
T tTrim(I i, I f)
{
    T buff;
    std::remove_copy_if(i, f, std::back_insert_iterator<T>(buff), std::bind2nd(std::equal_to<char>(),' '));
    return buff;   
}

int main()
{
    using namespace std;
    string str, buff;
    cout << "Input a string with spaces: "; getline(cin, str);
        buff = Trim(str.begin(), str.end());
    cout << "The same string w/o spaces: " << buff << endl;
    system("pause");
    return 0;
}

---