Works on Dev C++, Doesn't on Visual C++ :(

Hi,

I have this code:

#include <iostream.h>
typedef unsigned short int USI;
float function( USI number1, USI number2 );
int main()
{
USI number1, number2;
float result;
cout<<"Number1: ";
cin>>number1;
cout<<"Number2: ";
cin>>number2;
result = function( number1,number2 );
if ( result == -1 )
cout<<"The sum: "<<number1<<"/"<<number2<<" could not be worked out!";
else
{
cout<<"----------------\n";
cout<<"First Number: "<<number1<<endl;
cout<<"Second Number: "<<number2<<endl;
cout<<"----------------\n";
cout<<number1<<"/"<<number2<<" = "<<result<<endl;
}
return 0;
}

float function( USI a, USI b )
{
if ( b == 0 )
return -1;

else
return a/b;
}

-------------------------------------------

Now on Dev C++ it works perfectly.
When I enter 0 for the second number it reports the error.

When I try to compile it on Visual C++, when I put a 0, it still works it out for me. Something is wrong. :(

Anyone may help me?

Thanks,
Marc

Quote:

---

Something is wrong

---

I cant see it!
nor could my copy of visual c:p

but in Dev C++, when I input 0 as the second number, it tells me it could not work it out blabla....
In visual C++, when I input 0 it still gets the working. I.e. it doesn't say that It could not work it out.

:( What may be wrong?

i have visual c 6 and it ran perfectly for me!

You might want to return an integer from your function rather than a float, as you shouldn't really test for equality with floats (the internal representation may be very slightly different, your function might be returning -1.000000001).

On second thoughts, it looks like you're trying to return a float (you'll have to cast the interger division). You could test for less than zero -

Code:

---

#include <iostream.h>
typedef unsigned short int USI;
float function( USI number1, USI number2 );

int main()
{
        USI number1, number2;
        float result;
        cout<<"Number1: ";
        cin>>number1;
        cout<<"Number2: ";
        cin>>number2;
        result = function( number1,number2 );
        if ( result < 0 )
                cout<<"The sum: "<<number1<<"/"<<number2<<" could not be worked out!";
        else
        {
                cout<<"----------------\n";
                cout<<"First Number: "<<number1<<endl;
                cout<<"Second Number: "<<number2<<endl;
                cout<<"----------------\n";
                cout<<number1<<"/"<<number2<<" = "<<result<<endl;
        }
        return 0;
}

float function( USI a, USI b )
{
        if ( b == 0 )
                return -1;

        else
                return (float)a/b;
}

---

thx!!! it worked :)
I am readin sams teach yourself C++ in 21 days ..3rd version ...seems very good.
I am gonna become a member..I like this place :D