what am i doing wrong : object orientated programming

i basicly want to create a function wich returns a value if value is correct then say welcome to the lines ..

this is my coder can any1 help me im a bit confused

Code:

---

#include <iostream.h>
#include <stdlib.h>
#include <fstream>

// encode
class test{
public:
int test::acces();
int test::menu();
int acces_response;
};

int test::acces(){
cout <<"acces granted 0.0 must be your lucky day";
int acces_response = 123  ;

}

int test::menu(){
cout <<"1. encode\n2. decode\n3. calculator\n4.credits";

}

// decode

// acces

// main function
int main(){
test test  ;
int x;
ofstream a_file ( "LOG.txt" );
a_file<<"starting program at \n";  // still need to add date !!!
cout <<"(c) 2004 \n";
a_file<<"log : function open acces() \n";
int acces = test.acces();
if (test::acces_response == 123){
cout <<"test succesfull... \n welcome to the lines soldier";
cin>>x;
}
}

---

First of all, you're mixing old-style C++ and modern C++. This is how it's done now:

Code:

---

#include <iostream>
 #include <stdlib>
 #include <fstream>
 
 using namespace std;

---

Most compilers are friendly and will accept confusion like this, but it's a good habit to know the difference and start using it.

If you were including some C libraries, you also drop the .h from the header file and precede the name with a C, for example "#include <cstdlib>".

You specify int as the return type for all your functions, but you never actually return anything. You use the return statement to return a value. You can use

Code:

---

return 0;

---

And just specify a constant. You would normally do things like this inside a conditional (if-statement), and in main functions this is just used to end the program and confirm program success with the operating system (0 is used for this, other values can be defined by you for different types of errors). You can also calculate the value you want to return, for example, in a mathematical function, and return that variable.

In your class defintion, you don't need the test:: before each function name. You should probably also know that you're spelling acess wrong - it has 2 s's. From a coding standpoint, spelling doesn't matter as long as you're consistent - but it's good to know when you're dealing with communications with the user.

thx :D

so all i needed to do was

Code:

---

return acces_response;

---

Code:

---

using namespace std;

---

never used it :/ im using dev-cpp 4.0 and it has no problems with it

Code:

---

class test{
public:
int test::acces();
int test::menu();
int acces_response;
};

---

Should be:

Code:

---

class test {
  public:
      int access();
      int menu();
      int access_response;
};

---

Code:

---

test test  ;

---

Give your object unambiguous names:

Code:

---

test obj;

---

Code:

---

test::acces_response

---

Should be

Code:

---

obj.access_response

---

For future reference, it helps to
a) indent your code
b) let us know what errors/problems you are having with the code
c) what it should do (if it isn't obvious from context)