Help with a little piece of code

Hey guys any ideas why this little piece of code is not outputing the results im expecting.

Code:

---


void And(char *Operand1,char *Operand2)

{
        int i;

        printf("%20s","");

        for(i=0;i<8;i++)
        {
       
        if( (Operand1[i] && Operand2[i]) !='1')
                putchar('0');

        else
                putchar('1');
       
        }
                putchar('\n');

        return;
}

---

Operand1 is '10111011' and Operand2 is '00111000'. The output is 00000000 not 00111000 which is what im expecting.

Thanks
Chris

> Operand1[i] && Operand2[i]
The result of this is either 0 or 1
Which is never the value '1'

What you want is probably
if ( Operand1[i] != '1' && Operand2[i] != '1' )

Still geting 00000000 even with those suggestions.

Chris

If both characters equal to 1 then print out a one, else print out a zero...

PHP Code:

---

for(i=0;i<8;i++)
{ 
    if(Operand1[i] == '1' && Operand2[i] == '1') putchar('1'); 
    else putchar('0');
} 


---

Here a mod of your original code, shown working in my terminal.

PHP Code:

---

bash-2.04$ cat ./oi.c
#include <stdio.h>
#include <stdlib.h>

void And(char *Operand1,char *Operand2)
{
        int i;

        for(i=0;i<8;i++)
        {
                if(Operand1[i] == '1' && Operand2[i] == '1') putchar('1');
                else putchar('0');
        }
                putchar('\n');
        return;
}

int main(void)
{
And("10111011","00111000");

return 0;
}

bash-2.04$ gcc oi.c -o oi
bash-2.04$ oi
00111000
bash-2.04$ 


---

Thanks guys I got it working.


Chris