Reading an array in a while not end of file loop

As part of a program, I have to read golf scores for multiple people into arrays. With the structure of the program, I have to load the array, use it to perform basic operations, and then load the next one, until the end of the input file. Here's what I have so far, where strokes[] is the array, golf is the input file, and result is the output file:

Code:

---

i = 1;
while(!feof(golf))
{
    for(i = 1; i <= 18; i++)
    {
        fscanf(golf, "%d", &strokes[i]);
        fprintf(result, "%d", strokes[i]);
    }
    i = 1;
    fscanf(golf, "%d", &strokes[i]);
}

---

I've been using the print for now just as a test to see if the data is reading correctly. I don't know if something is missing or what, but I keep getting infinite loops. I'm new to programming, so any help would be greatly appreciated. Thanks.

A couple of things i noted:
feof is bad
an array starts at 0 and goes to number of elements-1.

And, without knowing exactly what those functions you have there do, you dont seem to have any read function so feof will never be true. (not sure here so correct me if i am wrong).

Well, I have to use feof according to instructions. As far as the array goes, do you mean that I should set i to 0 and set it to less than 18 in the for statement? Would a while loop be better than a for loop for loading the array?

Thanks

A for loop does just fine but the way you have you go out of bounds.

Code:

---

int i;
for(i=0; i<18;i++)
{
    // Do stuff
}

---

Thanks for your help, I figured out what I need to do instead. Each row of scores has a name, so I'm using the name to find EOF, which translates to this:

Code:

---

int i;
char name[15];

fscanf(golf, "%s", name);
while(!feof(golf))
{
    fprintf(result, "\n%-15s\n", name);
    for(i = 0; i < 18, i++);
    {
          fscanf(golf, "%d", &strokes[i]);
          fprintf(result, "%d", &strokes[i]);
    }
    fscanf(golf, "%s", name);
}

---

> Well, I have to use feof according to instructions.
Even if that instruction turns out to be nonsense / inaccurate / wrong / bad advice
Teachers and books are far from infallible.

Your answer works, but you'll notice that you've now got an identical line of code in two different places. This is very bad from a maintenance point of view - what happens if the line has to change and only one of them gets changed?

Assuming an otherwise well-formed file, you can do this

Code:

---

while ( fscanf(golf, "%s", name) == 1 ) {
    fprintf(result, "\n%-15s\n", name);
    for(i = 0; i < 18; i++) /* I hope this ; at the end of this line was a typo! (and the comma) */
    {
          fscanf(golf, "%d", &strokes[i]);
          fprintf(result, "%d", &strokes[i]);
    }
}

---