Can anyone tell me why it displays more than 1 line of the same?

This program everytime twice displays the line for the user to enter C, D or F. Why is that?
Also, if the user enter more than 1 letter for the first prompt, the C, D, F line is printed multiple times in relation to how many letter the user entered.
Help Appreciated

Code:

---

#include <stdio.h>
#include <process.h>
#include <conio.h>

int sort_bytes();
int create_screen();
int initialise_com_port();

char input;
char input2;

int main(void)
{
  initialise_com_port();

  printf("This is the Data Packet Analyser program\n");
  printf("This program does...\n");
  printf("Enter 'C' to make a capture: ");
  scanf("%c", &input);

  sort_bytes();
  create_screen();

  getch();
  return 0;
}


int initialise_com_port()
{
  printf("\nHello from initialise_com_port\n");
}

int sort_bytes()
{
  printf("\n\nHello from sort_bytes!");
}

int create_screen()
{
  printf("\n\nHello from create_screen!\n");
  do
  {
      printf("\n\nEnter 'C', 'D', or 'F': ");
      scanf("%c", &input2);

      switch ( input2 )
      {
        case 'C' : printf("\nFunction sort_bytes and function create_screen");
                    printf(" is called in.");
            break;
        case 'D' : printf("\nFunction create_file is called in");
            break;
      }
  }
  while ( input2 != 'F');

  printf("You have decided to exit from the program\nPress Enter");
}

---

Your first scanf() call in the main() function reads a character from the stdin buffer. Anything else in the buffer gets read by the scanf() function in the create_screen() function which is why the do...while loop goes through a couple times.

One option would be to clear out the input buffer with a fgets() call after a scanf() call.

how come 'scanf()' eliminates when it finds a '\n' in stdin in the first loop??? i thought it doesn't care about it :confused:

oh and here are some tips for your code :

those 3 functions :

Code:

---

int sort_bytes();
int create_screen();
int initialise_com_port();

---

should have the type 'void' not 'int' because they won't return any value. They will just do their stuff and quit their functions without returning any values.


When asking for single characters as input , use two cases for each character instead of one coveing both lower-case and upper-case letters. So this :

Code:

---

case 'C' : printf("\nFunction sort_bytes and function create_screen");
                    printf(" is called in.");

---

should be :

Code:

---

case 'c' :
case 'C' :
      printf("\nFunction sort_bytes and function create_screen");
      printf(" is called in.");

---

you checked for only upper-case letters when people mostly type lower case letters by default.

another thing , you can go to other lines in your program with using only one 'printf()' instead of typing it again on each line. It can be done this way :

Code:

---

printf("First line\n"
      "second line\n"
      "third line\n");

---

and finally , you've included 2 useless header files , conio.h and process.h. You've only used functions that are declared in stdio.h so it should be there alone.