Beginning with classes

Hey, I'm starting up with classes in C++ so I made a little task to aid in learning them. Basically, I'm just wondering how it looks. Is the design good? Any flaws? I'm not worried about the actual car, I'm just trying to get an idea of how things should be done. Thanks!

Code:

---

// car.cpp

#include <iostream>
#include <stdlib.h>
#include <windows.h>

using namespace std;

enum { OFF, STARTED, ACCELE, DECEL };

class Car
{
    public:
        Car();
        ~Car() { /* nothing */ };
        int GetSpeed();
        void Start();
        void Accelerate();
        void Decelerate();
        void Stop();
       
    private:
        int Speed;
        int State;
        int Time;
};

int main()
{
    Car Corvette;
    int n;
   
    cout << "Ultra Car Simulator 3000!!\n\n";
    cout << "Controls:\n";
    cout << "  1. Start\n";
    cout << "  2. Accelerate\n";
    cout << "  3. Decelerate\n";
    cout << "  4. Current Speed\n";
    cout << "  5. Stop\n";
    cout << "  6. Quit\n";
   
    while (n != 6)
    {
        cin >> n;
        switch (n)
        {
            case 1:
                Corvette.Start();
                break;
            case 2:
                Corvette.Accelerate();
                break;
            case 3:
                Corvette.Decelerate();
                break;
            case 4:
                cout << "Current speed: " << Corvette.GetSpeed() << ".\n";
                break;
            case 5:
                Corvette.Stop();
                break;
            case 6:
                break;
            default:
                cout << "The car doesn't understart that command.\n";
                break;
        }
    }

    cout << "\nVroom!\n";
   
    system("PAUSE");
   
    return 0;
}

Car::Car()
{
    Speed = 0;
    State = OFF;
}

int Car::GetSpeed()
{
    int Time2 = GetTickCount();
    if (State == ACCELE)
        Speed += (Time2 - Time)/100;
    else if (State == DECEL)
    {
        Speed -= (Time2 - Time)/100;
        if (Speed < 0)
        {
            Speed = 0;
            State = STARTED;
        }
    }
    Time = GetTickCount();

    return Speed;
}

void Car::Start()
{
    if (State == OFF)
    {
        cout << "Car started.\n";
        State = STARTED;
    }
    else
        cout << "Car already started.\n";
}

void Car::Accelerate()
{
    if (State == OFF)
        cout << "Car needs to be started.\n";
    else if (State == ACCELE)
        cout << "Car already accelerating.\n";
    else
    {
        cout << "Car accelerating.\n";
        State = ACCELE;
        Time = GetTickCount();
    }
}

void Car::Decelerate()
{
    if (State == OFF)
        cout << "Car needs to be started.\n";
    else if (State == DECEL)
        cout << "Car already decelerating.\n";
    else
    {
        cout << "Car decelerating.\n";
        State = DECEL;
        Time = GetTickCount();
    }
}

void Car::Stop()
{
    if (State == OFF)
        cout << "Car already stopped\n";
    else
    {
        cout << "Car stopped\n";
        State = OFF;
        Speed = 0;
    }
}

---

Don't use cout inside of member functions. Pass a reference to an ostream instead (can use a default value however)

Example:

Code:

---

void Car::Start(std::ostream &out)
{
    if (State == OFF)
    {
        out << "Car started.\n";
        State = STARTED;
    }
    else
        out << "Car already started.\n";
}

---

>Pass a reference to an ostream instead (can use a default value however)
Actually, it's better not to print anything at all inside of the class implementation except in a few special cases:

1) Debugging statements (that are turned off with a compile switch for production release)
2) Member functions whose sole purpose is to print something.

Other than that, return values, status flags and exceptions should be preferred for notification purposes. The application knows what messages to print and how to print them if necessary, the object usually does not.

Alrighty, thanks for the input. So basically I need to have the functions return a value and handle the output in the main function, or create a method to handle the output. I'm thinking something like:

Code:

---

void Car::Already(int State)
{
    switch (Type)
    {
    case STARTED:
        cout << "...";
    ...
}

---

But I guess that means I should also pass in a reference to an ostream? Or, could I create an ostream as a member of the class? Alrighty, thanks again for you help!

Sean

Thantos and Prelude have already showed you the method to handle the output, right ?

Quote:

---

int n;
....
while (n != 6)

---

This is bad. You need to initialize 'n'.

after "int n;", the value of 'n' is undefined (could even be 6 in which case your program wouldnt enter the loop).

edit:
>> system("PAUSE");

this is a less than preferable solution, search the board to find out why.

Quote:

---

Originally Posted by Thantos

void Car::Start(std::ostream &out)
{
if (State == OFF)
{
out << "Car started.\n";
State = STARTED;
}
else
out << "Car already started.\n";
}

---

Quote:

---

Originally Posted by Prelude

return values, status flags and exceptions should be preferred for notification purposes

---

Quote:

---

Originally Posted by Hermitsky

Thantos and Prelude have already showed you the method to handle the output, right ?

---

It would appear that way, now wouldn't it?

Please forgive my ignorance almighty C++ Masters!

Thanks Perspective

WOW, you program good cars, my cars going 287023 mph and it still hasn't crashed or come apart!(going all day) :D