Question about memory/allocation/pointers

I have a program that looks something like this:

Code:

---


unsigned char* Data;
unsigned char* TempData;

TempData=new unsigned char[256];
if(TempData!=NULL)
{
  Data=&TempData;
  TempData=NULL;
}

if(Data!=NULL)
{
  delete[] Data;
}


---

It uses a temporary pointer to allocate memory, and if successful makes Data the pointer to this memory.

I get a suspicious pointer conversation warning when compiling. Is there something wrong with this code? It seems to work fine when running the program.

When you say it works fine what do you mean, it doesn't crash?

>>> Data=&TempData;

This line looks wrong to me. Data and TempData are both char pointers, you set the value of one of these pointers to the address of the char array, and then set the other to the address of the first pointer, not the array. I am a little suprised it compiles.

Sorry, it should be:

Data=&TempData[0];

Just use Data=TempData; instead. While your solution is correct, too, the compiler obviously suspects something wrong and for a human reader it looks like a hack, too. The bold version is correct and the easiest way. Anything else just confuses readers.

Ok, thanks :)