Learning C++ - Coded simple program which crashes

I coded this to test FOR loops, but whenever I enter YES it crashes.

Code:

---

// Includes the basic IO functions.
 #include <iostream.h>
 #include <string.h>
 
 // This program is coded simply to test the FOR loop in Visual C++.
 
 int main(void) {
 
        char * response;
 
        cout << "Ready to begin? Type YES if you are.";
 
        cin >> response;
 
        if (response == "YES" || response == "yes") {
       
  cout << "This is the loop:" << endl;
       
  for (int x = 0; x < 100; x++) {
         
          cout << x << endl;
  }
 
  return 0;
 
        }
 
        else {
 
        cout << "Very well. Program terminating.";
 
        }
 
        return 0;
 
 }

---

seems like visual c++ is quite messed up
that ryback guys is also having problems with visual c++

Your trying to put a string of text into a char pointer.
Therefore it crashes because there is no memory allocated for it.

EDIT: Also your not using standard headers.

try this

EDITED AGAIN, I tested it and this works

Code:

---

#include <iostream> //+--Changed to standard header--+
#include <string>
using namespace std;
 
int main(void) {
 
    string response;
 
    cout << "Ready to begin? Type YES if you are.";
 
    cin >> response;
 
    if (response == "YES" || response == "yes") {
       
        cout << "This is the loop:" << endl;
       
        for (int x = 0; x < 100; x++) {
         
            cout << x << endl;

        }
 
    }
 
    else {
 
        cout << "Very well. Program terminating.";
 
    }
 
    cin.ignore();
    cin.get();
    return 0;
 
}

---

@ Vicious :

Quote:

---

cin.ignore();
cin.get();

---

Why using cin.ignore , how does it work?
Thanks.

haha, I have read next post , find this answer:

Quote:

---

The reason is that when you extract a, b, and c from the input stream, the newline from when you hit enter is still there. The cin.get() waits for the next newline, but since there is already one there your console closes. The call to cin.ignore() above fixes that specific problem by ignoring that first newline and allowing the cin.get() to wait for the next one. You could also put cin.get() twice or cin.ignore() twice to achieve the same effect.

---

author: jlou

mate u allocate response as a char. char is used to store a single letter variable and u tryed to make it store 3 (yes). so just make it say(please enter y or n) unless u know hot to use arrays and strings ;)

Quote:

---

Originally Posted by toysoldier

haha, I have read next post , find this answer:

Quote:

---

The reason is that when you extract a, b, and c from the input stream, the newline from when you hit enter is still there. The cin.get() waits for the next newline, but since there is already one there your console closes. The call to cin.ignore() above fixes that specific problem by ignoring that first newline and allowing the cin.get() to wait for the next one. You could also put cin.get() twice or cin.ignore() twice to achieve the same effect.

---

author: jlou

---

You forgot the rest of that quote! Basically:

I'd prefer this code, because more potential problems can be avoided this way.

Code:

---

#include <iostream>
#include <string>
#include <limits>

int main()
{
    std::string response;
    std::cout << "Ready to begin? Type YES if you are.";
    std::cin >> response;

    // ...

    std::cin.ignore(std::numeric_limits<int>::max(), '\n');
    std::cin.get();
    return 0;
}

---

That ignores all characters in the input stream up to and including the newline - which helps in case the user accidentally types in characters after the stored response.